public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
To: git-commits@fedoraproject.org
Subject: [rpms/rpkg] 1.70-1: Fix default value for krb_rdns options
Date: Mon, 10 Aug 2026 21:43:40 GMT [thread overview]
Message-ID: <178639822016.1.16922905962559658074.rpms-rpkg-f4253b544063@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/rpkg
Branch : 1.70-1
Commit : f4253b5440631463a2c34741ec96773c54f1353d
Author : Lubomír Sedlář <lsedlar@redhat.com>
Date : 2016-12-12T15:58:40+01:00
Stats : +42/-1 in 2 file(s)
URL : https://src.fedoraproject.org/rpms/rpkg/c/f4253b5440631463a2c34741ec96773c54f1353d?branch=1.70-1
Log:
Fix default value for krb_rdns options
---
diff --git a/0001-Default-krb_rdns-to-None.patch b/0001-Default-krb_rdns-to-None.patch
new file mode 100644
index 0000000..36ba43d
--- /dev/null
+++ b/0001-Default-krb_rdns-to-None.patch
@@ -0,0 +1,36 @@
+From 65a0d9c726d19ac594de003f83eb69a58ea21a4f Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Lubom=C3=ADr=20Sedl=C3=A1=C5=99?= <lsedlar@redhat.com>
+Date: Mon, 12 Dec 2016 15:08:30 +0100
+Subject: [PATCH] Default krb_rdns to None
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Using `False` as default value will break setups where the value is not
+specified and is expected to be `True`; for example `rhpkg` will not be
+able to talk to Brew.
+
+This patch removes the empty value, so that the option is only used when
+actually specified in config.
+
+Signed-off-by: Lubomír Sedlář <lsedlar@redhat.com>
+---
+ pyrpkg/__init__.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/pyrpkg/__init__.py b/pyrpkg/__init__.py
+index e3fd456..247356f 100644
+--- a/pyrpkg/__init__.py
++++ b/pyrpkg/__init__.py
+@@ -248,7 +248,7 @@ class Commands(object):
+ 'topurl': 'http://localhost/kojiroot',
+ 'use_fast_upload': None,
+ 'weburl': 'http://localhost/koji',
+- 'krb_rdns': False,
++ 'krb_rdns': None,
+ }
+
+ # Process the configs in order, global, user, then any option passed
+--
+2.9.3
+
diff --git a/rpkg.spec b/rpkg.spec
index 0bbca21..4a22d14 100644
--- a/rpkg.spec
+++ b/rpkg.spec
@@ -3,13 +3,14 @@
Name: rpkg
Version: 1.47
-Release: 4%{?dist}
+Release: 5%{?dist}
Summary: Utility for interacting with rpm+git packaging systems
Group: Applications/System
License: GPLv2+ and LGPLv2
URL: https://pagure.io/rpkg
Source0: https://pagure.io/releases/rpkg/rpkg-%{version}.tar.gz
+Patch0: 0001-Default-krb_rdns-to-None.patch
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Requires: pyrpkg >= %{version}-%{release}
@@ -62,6 +63,7 @@ A python library for managing RPM package sources in a git repository.
%prep
%setup -q
+%patch0 -p1
%build
@@ -96,6 +98,9 @@ rm -rf $RPM_BUILD_ROOT
%changelog
+* Mon Dec 12 2016 Lubomír Sedlář <lsedlar@redhat.com> - 1.47-5
+- Fix default value for krb_rdns options
+
* Mon Dec 12 2016 Lubomír Sedlář <lsedlar@redhat.com> - 1.47-4
- Add krb_rdns koji config
reply other threads:[~2026-08-10 21:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178639822016.1.16922905962559658074.rpms-rpkg-f4253b544063@fedoraproject.org \
--to=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox