public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
To: git-commits@fedoraproject.org
Subject: [rpms/fedora-release] f45: Stop modifying the source file
Date: Mon, 10 Aug 2026 09:36:01 GMT	[thread overview]
Message-ID: <178635456173.1.17809386678674438362.rpms-fedora-release-8eeadc450713@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/fedora-release
            Branch : f45
            Commit : 8eeadc450713b6d20cb59717e01e1e191fd05a47
            Author : Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
            Date   : 2023-02-02T10:36:35+01:00
            Stats  : +2/-3 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/fedora-release/c/8eeadc450713b6d20cb59717e01e1e191fd05a47?branch=f45

            Log:
            Stop modifying the source file

This was bad on many levels. In particular, anyone doing 'git commit -a'
would inadvertently commit the changes.

[skip changelog]

---
diff --git a/fedora-release.spec b/fedora-release.spec
index 56c1c0e..f561f8f 100644
--- a/fedora-release.spec
+++ b/fedora-release.spec
@@ -1034,7 +1034,8 @@ itself as Fedora Sericea.
 
 
 %prep
-sed -i 's|@@VERSION@@|%{dist_version}|g' %{SOURCE2}
+mkdir -p licenses
+sed 's|@@VERSION@@|%{dist_version}|g' %{SOURCE2} >licenses/Fedora-Legal-README.txt
 
 %build
 
@@ -1433,9 +1434,7 @@ cat >> %{buildroot}%{_rpmconfigdir}/macros.d/macros.dist << EOF
 EOF
 
 # Install licenses
-mkdir -p licenses
 install -pm 0644 %{SOURCE1} licenses/LICENSE
-install -pm 0644 %{SOURCE2} licenses/Fedora-Legal-README.txt
 
 # Default system wide
 install -Dm0644 %{SOURCE10} -t %{buildroot}%{_prefix}/lib/systemd/system-preset/

                 reply	other threads:[~2026-08-10  9:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178635456173.1.17809386678674438362.rpms-fedora-release-8eeadc450713@fedoraproject.org \
    --to=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox