public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Than Ngo <than@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/chromium] epel9-next: Enable gtk3 for el9 as it still has old gtk4 version
Date: Fri, 07 Aug 2026 16:08:34 GMT	[thread overview]
Message-ID: <178611891466.1.13511154250408729008.rpms-chromium-d0c2893c13e6@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/chromium
Branch : epel9-next
Commit : d0c2893c13e6a9779200a5c90f3f59fdb9e9d5c0
Author : Than Ngo <than@redhat.com>
Date   : 2025-12-12T11:58:21+01:00
Stats  : +14/-4 in 1 file(s)
URL    : https://src.fedoraproject.org/rpms/chromium/c/d0c2893c13e6a9779200a5c90f3f59fdb9e9d5c0?branch=epel9-next

Log:
Enable gtk3 for el9 as it still has old gtk4 version

---
diff --git a/chromium.spec b/chromium.spec
index 8e42f23..472ec62 100644
--- a/chromium.spec
+++ b/chromium.spec
@@ -51,6 +51,12 @@
 %global system_nodejs 0
 %endif
 
+# enable gtk4 for fedora and el>9
+%global gtk_version 4
+%if 0%{?rhel} == 9
+%global gtk_version 3
+%endif
+
 %if 0%{?rhel} == 8
 %global chromium_pybin /usr/bin/python3.9
 %else
@@ -761,6 +767,7 @@ BuildRequires:	opus-devel
 %endif
 
 BuildRequires: %{chromium_pybin}
+%if %{gtk_version} == 4
 BuildRequires: pkgconfig(gtk4)
 BuildRequires: pkgconfig(xrandr)
 BuildRequires: pkgconfig(atspi-2)
@@ -776,7 +783,12 @@ BuildRequires: pkgconfig(xtst)
 BuildRequires: pkgconfig(x11)
 BuildRequires: pkgconfig(xcb-dri3)
 BuildRequires: pkgconfig(xcb-proto)
-
+Requires: gtk4
+%else
+BuildRequires: pkgconfig(gtk+-3.0)
+# GTK modules it expects to find for some reason.
+Requires: libcanberra-gtk3%{_isa}
+%endif
 %if ! %{bundlepylibs}
 %if 0%{?fedora} || 0%{?rhel} >= 8
 BuildRequires: python3-jinja2
@@ -819,8 +831,6 @@ BuildRequires: simdutf-devel
 Requires: nss%{_isa} >= 3.26
 Requires: nss-mdns%{_isa}
 
-Requires: gtk4
-
 %if 0%{?fedora} && %{undefined flatpak}
 # This enables support for u2f tokens
 Requires: u2f-hidraw-policy
@@ -1372,7 +1382,7 @@ CHROMIUM_BROWSER_GN_DEFINES+=" use_qt6=true moc_qt6_path=\"$(%{_qt6_qmake} -quer
 %else
 CHROMIUM_BROWSER_GN_DEFINES+=' use_qt6=false'
 %endif
-CHROMIUM_BROWSER_GN_DEFINES+=' use_gtk=true gtk_version=4'
+CHROMIUM_BROWSER_GN_DEFINES+=' use_gtk=true gtk_version=%{gtk_version}'
 
 CHROMIUM_BROWSER_GN_DEFINES+=' use_gio=true use_pulseaudio=true'
 CHROMIUM_BROWSER_GN_DEFINES+=' enable_hangout_services_extension=true'

                 reply	other threads:[~2026-08-07 16:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178611891466.1.13511154250408729008.rpms-chromium-d0c2893c13e6@fedoraproject.org \
    --to=than@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox