public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Than Ngo <than@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/chromium] epel9-next: Fix FTBFS caused by bindgen-cli-0.71, rust-1.79.0 on EL9
Date: Fri, 07 Aug 2026 16:07:43 GMT	[thread overview]
Message-ID: <178611886379.1.18178944323875052687.rpms-chromium-2275a819c82d@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/chromium
Branch : epel9-next
Commit : 2275a819c82d798252de8f538f532f0c390d008b
Author : Than Ngo <than@redhat.com>
Date   : 2025-05-08T15:07:53+02:00
Stats  : +27/-1 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/chromium/c/2275a819c82d798252de8f538f532f0c390d008b?branch=epel9-next

Log:
Fix FTBFS caused by bindgen-cli-0.71, rust-1.79.0 on EL9

---
diff --git a/chromium-136-el9-bindgen-cli-build-error.patch b/chromium-136-el9-bindgen-cli-build-error.patch
new file mode 100644
index 0000000..caa196e
--- /dev/null
+++ b/chromium-136-el9-bindgen-cli-build-error.patch
@@ -0,0 +1,22 @@
+bindgen generates rust codes that cannot be compiled with rust-1.79.0 on EPEL9
+  https://github.com/rust-lang/rust-bindgen/issues/3052
+
+Add Workaround for this build error on el9
+
+error: extern block cannot be declared unsafe
+ --> ../../third_party/crabbyavif/src/sys/dav1d-sys/src/../../../../../../out/Release/gen/third_party/crabbyavif/crabbyavif_dav1d_sys/dav1d_bindgen.rs:3:18605
+
+Signed-off-by: Than Ngo <than@redhat.com>
+
+diff -up chromium-136.0.7103.92/build/rust/run_bindgen.py.than chromium-136.0.7103.92/build/rust/run_bindgen.py
+--- chromium-136.0.7103.92/build/rust/run_bindgen.py.than	2025-05-08 14:09:50.268246973 +0200
++++ chromium-136.0.7103.92/build/rust/run_bindgen.py	2025-05-08 14:46:22.421719175 +0200
+@@ -68,7 +68,7 @@ def main():
+     # TODO(danakj): We need to point bindgen to
+     # //third_party/rust-toolchain/bin/rustfmt.
+     genargs.append('--no-rustfmt-bindings')
+-    genargs += ['--rust-target', 'nightly']
++    genargs += ['--rust-target', '1.79']
+ 
+     if args.depfile:
+       depfile = stack.enter_context(action_helpers.atomic_output(args.depfile))

diff --git a/chromium.spec b/chromium.spec
index 3bf55ce..044efac 100644
--- a/chromium.spec
+++ b/chromium.spec
@@ -288,6 +288,9 @@ Patch91: chromium-108-system-opus.patch
 # patch for Failed NodeJS version check
 Patch92: chromium-136-checkversion-nodejs.patch
 
+# Fix FTBFS caused by bindgen-cli-0.71, rust-1.79.0 on EL9
+Patch93: chromium-136-el9-bindgen-cli-build-error.patch
+
 # system ffmpeg
 # need for old ffmpeg 5.x on epel9
 Patch129: chromium-125-ffmpeg-5.x-reordered_opaque.patch
@@ -1000,7 +1003,8 @@ Qt6 UI for chromium.
 %patch -P91 -p1 -b .system-opus
 %endif
 
-%patch -P92 -p1 -b .chromium-136-nodejs-checkversion
+%patch -P92 -p1 -b .nodejs-checkversion
+%patch -P93 -p1 -b .bindgen-cli-build-error
 
 %if ! %{bundleffmpegfree}
 %if 0%{?rhel} == 9

                 reply	other threads:[~2026-08-07 16:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178611886379.1.18178944323875052687.rpms-chromium-2275a819c82d@fedoraproject.org \
    --to=than@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox