public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Than Ngo <than@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/chromium] epel9-next: Fix build error due to old clang18 in el 8/9 and f40
Date: Fri, 07 Aug 2026 16:07:20 GMT	[thread overview]
Message-ID: <178611884087.1.13183027939497993166.rpms-chromium-07ebb27a114d@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/chromium
Branch : epel9-next
Commit : 07ebb27a114dd539247ae4bf6a1514d4ddd5c53a
Author : Than Ngo <than@redhat.com>
Date   : 2025-02-10T14:30:40+01:00
Stats  : +15/-0 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/chromium/c/07ebb27a114dd539247ae4bf6a1514d4ddd5c53a?branch=epel9-next

Log:
Fix build error due to old clang18 in el 8/9 and f40

---
diff --git a/chromium-133-clang18-template.patch b/chromium-133-clang18-template.patch
new file mode 100644
index 0000000..f95aa57
--- /dev/null
+++ b/chromium-133-clang18-template.patch
@@ -0,0 +1,12 @@
+diff -up chromium-133.0.6943.53/chrome/browser/compose/compose_session.cc.me chromium-133.0.6943.53/chrome/browser/compose/compose_session.cc
+--- chromium-133.0.6943.53/chrome/browser/compose/compose_session.cc.me	2025-02-10 14:16:34.810693753 +0100
++++ chromium-133.0.6943.53/chrome/browser/compose/compose_session.cc	2025-02-10 14:16:39.747791800 +0100
+@@ -543,7 +543,7 @@ void ComposeSession::RequestWithSession(
+   // execution in case request fails.
+   compose::LogComposeRequestReason(request_reason);
+ 
+-  optimization_guide::ModelExecutionSessionCallbackWithLogging callback =
++  optimization_guide::ModelExecutionSessionCallbackWithLogging<optimization_guide::proto::ComposeLoggingData> callback =
+       base::BindRepeating(&ComposeSession::ModelExecutionCallback,
+                           weak_ptr_factory_.GetWeakPtr(),
+                           std::move(request_timer), request_id_, request_reason,

diff --git a/chromium.spec b/chromium.spec
index fc2691a..893d6eb 100644
--- a/chromium.spec
+++ b/chromium.spec
@@ -333,9 +333,11 @@ Patch306: chromium-127-el8-ifunc-header.patch
 
 # workaround for build error due to old atk version on el8
 Patch307: chromium-133-el8-atk-compiler-error.patch
+# Fix build errors due to old clang18 in el 8/9 and f40
 Patch308: chromium-132-el8-unsupport-clang-flags.patch
 Patch309: chromium-132-el8-unsupport-rustc-flags.patch
 Patch310: chromium-132-el8-clang18-build-error.patch
+Patch311: chromium-133-clang18-template.patch
 
 # enable fstack-protector-strong
 Patch312: chromium-123-fstack-protector-strong.patch
@@ -1029,6 +1031,7 @@ Qt6 UI for chromium.
 %patch -P308 -p1 -b .el8-unsupport-clang-flags
 %patch -P309 -p1 -b .el8-unsupport-rustc-flags
 %patch -P310 -p1 -b .el8-clang18-build-error
+%patch -P311 -p1 -b .clang18-template
 %endif
 
 %patch -P312 -p1 -b .fstack-protector-strong

                 reply	other threads:[~2026-08-07 16:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178611884087.1.13183027939497993166.rpms-chromium-07ebb27a114d@fedoraproject.org \
    --to=than@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox