public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
To: git-commits@fedoraproject.org
Subject: [rpms/chromium] epel9-next: Make building of chromedriver optional
Date: Fri, 07 Aug 2026 16:06:07 GMT	[thread overview]
Message-ID: <178611876707.1.9706862524956482339.rpms-chromium-2b0a759a9fcf@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/chromium
            Branch : epel9-next
            Commit : 2b0a759a9fcffbbf5e212eef6d545ed3361bdb53
            Author : Łukasz Wojniłowicz <lukasz.wojnilowicz@gmail.com>
            Date   : 2024-02-27T18:38:02+00:00
            Stats  : +18/-6 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/chromium/c/2b0a759a9fcffbbf5e212eef6d545ed3361bdb53?branch=epel9-next

            Log:
            Make building of chromedriver optional

It lowers patching effort when this spec is used as a base for
ungoogled-chromium. chromedriver is not the desired outcome then so it
would be disabled by a simple boolean variable.

---
diff --git a/chromium.spec b/chromium.spec
index 6e999b2..e4a07d2 100644
--- a/chromium.spec
+++ b/chromium.spec
@@ -30,6 +30,9 @@
 	export NINJA_STATUS="[%2:%f/%t] " ; \
 	ninja -j %{numjobs} -C '%1' '%2'
 
+# enable|disable chromedriver
+%global build_chromedriver 1
+
 # enable|disable headless client build
 %global build_headless 1
 
@@ -301,7 +304,7 @@
 
 Name:	chromium%{chromium_channel}
 Version: 122.0.6261.69
-Release: 2%{?dist}
+Release: 3%{?dist}
 Summary: A WebKit (Blink) powered web browser that Google doesn't want you to use
 Url: http://www.chromium.org/Home
 License: BSD-3-Clause AND LGPL-2.1-or-later AND Apache-2.0 AND IJG AND MIT AND GPL-2.0-or-later AND ISC AND OpenSSL AND (MPL-1.1 OR GPL-2.0-only OR LGPL-2.0-only)
@@ -1572,7 +1575,10 @@ mkdir -p %{builddir} && cp -a %{_bindir}/gn %{builddir}/
 
 %build_target %{builddir} chrome
 %build_target %{builddir} chrome_sandbox
+
+%if %{build_chromedriver}
 %build_target %{builddir} chromedriver
+%endif
 
 %if %{build_clear_key_cdm}
 %build_target %{builddir} clear_key_cdm
@@ -1661,9 +1667,11 @@ pushd %{builddir}
 		%endif
 	%endif
 
-	# chromedriver
-	cp -a chromedriver %{buildroot}%{chromium_path}/chromedriver
-	ln -s ../..%{chromium_path}/chromedriver %{buildroot}%{_bindir}/chromedriver
+	%if %{build_chromedriver}
+		# chromedriver
+		cp -a chromedriver %{buildroot}%{chromium_path}/chromedriver
+		ln -s ../..%{chromium_path}/chromedriver %{buildroot}%{_bindir}/chromedriver
+	%endif
 
 	%if %{build_remoting}
 		# Remote desktop bits
@@ -1935,13 +1943,18 @@ getent group chrome-remote-desktop >/dev/null || groupadd -r chrome-remote-deskt
 /var/lib/chrome-remote-desktop/
 %endif
 
+%if %{build_chromedriver}
 %files -n chromedriver
 %doc AUTHORS
 %license LICENSE
 %{_bindir}/chromedriver
 %{chromium_path}/chromedriver
+%endif
 
 %changelog
+* Tue Feb 27 2024 Łukasz Wojniłowicz <lukasz.wojnilowicz@gmail.com> - 122.0.6261.69-3
+- Make building of chromedriver optional
+
 * Tue Feb 27 2024 Jiri Vanek <jvanek@redhat.com> - 122.0.6261.69-2
 - Rebuilt for java-21-openjdk as system jdk
 
@@ -3612,5 +3625,4 @@ getent group chrome-remote-desktop >/dev/null || groupadd -r chrome-remote-deskt
 - Compile with Dproprietary_codecs=0 and Dffmpeg_branding=Chromium to disable proprietary codecs (i.e. MP3)
 
 * Mon Sep 9 2013 Tomas Popela <tpopela@redhat.com> 29.0.1547.65-1
-- Initial version based on Tom Callaway's <spot@fedoraproject.org> work
-
+- Initial version based on Tom Callaway's <spot@fedoraproject.org> work
\ No newline at end of file

                 reply	other threads:[~2026-08-07 16:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178611876707.1.9706862524956482339.rpms-chromium-2b0a759a9fcf@fedoraproject.org \
    --to=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox