[rpms/abrt] update-2.17.8: Add patch for possibly unitialized variable

public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed

From: Martin Kutlak <mkutlak@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/abrt] update-2.17.8: Add patch for possibly unitialized variable
Date: Mon, 03 Aug 2026 10:23:59 GMT	[thread overview]
Message-ID: <178575263915.1.1652330478663307758.rpms-abrt-8f4c491a4bd5@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/abrt
            Branch : update-2.17.8
            Commit : 8f4c491a4bd52ff86180e7bf72b614004eaa9b50
            Author : Martin Kutlak <mkutlak@redhat.com>
            Date   : 2020-01-31T10:42:41+01:00
            Stats  : +52/-21 in 2 file(s)
            URL    : https://src.fedoraproject.org/rpms/abrt/c/8f4c491a4bd52ff86180e7bf72b614004eaa9b50?branch=update-2.17.8

            Log:
            Add patch for possibly unitialized variable

Removed comments after endifs.

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>

---
diff --git a/0004-dbus-Fix-possibly-uninitialized-variable.patch b/0004-dbus-Fix-possibly-uninitialized-variable.patch
new file mode 100644
index 0000000..5ad921b
--- /dev/null
+++ b/0004-dbus-Fix-possibly-uninitialized-variable.patch
@@ -0,0 +1,29 @@
+From f81bbaa60ad6c5c99dba499044255fdde5d5ed4a Mon Sep 17 00:00:00 2001
+From: Martin Kutlak <mkutlak@redhat.com>
+Date: Fri, 31 Jan 2020 10:12:37 +0100
+Subject: [PATCH] dbus: Fix possibly uninitialized variable
+
+abrt_problems2_task.c:419:21: error:
+'response' may be used uninitialized in this function [-Werror=maybe-uninitialized]
+
+Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
+---
+ src/dbus/abrt_problems2_task.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/dbus/abrt_problems2_task.c b/src/dbus/abrt_problems2_task.c
+index e6ae171c7..af47660aa 100644
+--- a/src/dbus/abrt_problems2_task.c
++++ b/src/dbus/abrt_problems2_task.c
+@@ -403,7 +403,7 @@ static void abrt_p2_task_autonomous_cb(AbrtP2Task *task,
+ 
+         case ABRT_P2_TASK_STATUS_FAILED:
+             {
+-                GVariant *response;
++                GVariant *response = NULL;
+                 gint32 code;
+                 GError *error = NULL;
+                 abrt_p2_task_finish(task, &response, &code, &error);
+-- 
+2.24.1
+

diff --git a/abrt.spec b/abrt.spec
index 16cad2b..d97225a 100644
--- a/abrt.spec
+++ b/abrt.spec
@@ -54,9 +54,10 @@ License: GPLv2+
 URL: https://abrt.readthedocs.org/
 Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz
 
-Patch0: 0001-python-Use-correct-paths-for-installed-modules.patch
-Patch1: 0002-Fix-build-failure-with-gcc-fno-common.patch
-Patch2: 0003-bodhi-Initialize-karma-values-with-default.patch
+Patch0001: 0001-python-Use-correct-paths-for-installed-modules.patch
+Patch0002: 0002-Fix-build-failure-with-gcc-fno-common.patch
+Patch0003: 0003-bodhi-Initialize-karma-values-with-default.patch
+Patch0004- 0004-dbus-Fix-possibly-uninitialized-variable.patch
 
 BuildRequires: git-core
 BuildRequires: %{dbus_devel}
@@ -83,7 +84,7 @@ BuildRequires: libselinux-devel
 BuildRequires: python3-devel
 BuildRequires: python3-systemd
 BuildRequires: python3-argcomplete
-%endif # with python3
+%endif
 
 Requires: libreport >= %{libreport_ver}
 Requires: satyr >= %{satyr_ver}
@@ -101,7 +102,7 @@ Requires(pre): %{shadow_utils}
 %if %{with python3}
 Requires: python3-augeas
 Requires: python3-dbus
-%endif # with python3
+%endif
 %ifarch aarch64 i686 x86_64
 Requires: dmidecode
 %endif
@@ -138,7 +139,7 @@ BuildRequires: python3-sphinx
 BuildRequires: python3-libreport
 #python3-abrt-doc
 BuildRequires: python3-devel
-%endif # with python3
+%endif
 
 %description
 %{name} is a tool to help users to detect defects in applications and
@@ -203,7 +204,7 @@ Requires: %{name} = %{version}-%{release}
 Requires: abrt-libs = %{version}-%{release}
 %if %{with python3}
 Requires: python3-libreport
-%endif # with python3
+%endif
 Obsoletes: abrt-addon-coredump-helper <= 2.12.2
 
 
@@ -263,7 +264,7 @@ Requires: kexec-tools
 %if %{with python3}
 Requires: python3-abrt
 Requires: python3-augeas
-%endif # with python3
+%endif
 Requires: util-linux
 
 %description addon-vmcore
@@ -311,7 +312,7 @@ Requires: container-exception-logger
 %description -n python3-abrt-container-addon
 This package contains python 3 hook and handling uncaught exception in python 3
 programs in container.
-%endif # with python3
+%endif
 
 %package plugin-sosreport
 Summary: %{name}'s plugin for building automatic sosreports
@@ -343,7 +344,7 @@ Requires: python3-argcomplete
 
 Provides: %{name}-cli-ng = %{version}-%{release}
 Obsoletes: %{name}-cli-ng < 2.12.2
-%endif # with python3
+%endif
 
 %description tui
 This package contains a simple command line client for processing abrt reports
@@ -359,7 +360,7 @@ Requires: abrt-addon-vmcore
 Requires: abrt-addon-ccpp
 %if %{with python3}
 Requires: python3-abrt-addon
-%endif # with python3
+%endif
 Requires: abrt-addon-xorg
 %if 0%{?rhel}
 Requires: libreport-rhel >= %{libreport_ver}
@@ -399,7 +400,7 @@ Requires: abrt-addon-vmcore
 Requires: abrt-addon-ccpp
 %if %{with python3}
 Requires: python3-abrt-addon
-%endif # with python3
+%endif
 Requires: abrt-addon-xorg
 Requires: gdb-headless
 Requires: abrt-gui
@@ -473,7 +474,7 @@ Requires: python3-%{name} = %{version}-%{release}
 
 %description -n python3-abrt-doc
 Examples and documentation for ABRT Python 3 API.
-%endif # with python3
+%endif
 
 %package console-notification
 Summary: ABRT console notification script
@@ -497,7 +498,7 @@ autoconf
 CFLAGS="%{optflags} -Werror" %configure \
 %if %{without python3}
         --without-python3 \
-%endif # with python3
+%endif
 %if %{without bodhi}
         --without-bodhi \
 %endif
@@ -524,7 +525,7 @@ CFLAGS="%{optflags} -Werror" %configure \
 %make_install \
 %if %{with python3}
              PYTHON=%{__python3} \
-%endif # with python3
+%endif
              dbusabrtdocdir=%{_defaultdocdir}/%{name}-dbus%{docdirversion}/html/
 
 %find_lang %{name}
@@ -595,7 +596,7 @@ chown -R abrt:abrt %{_localstatedir}/cache/abrt-di
 %if %{with python3}
 %post -n python3-abrt-addon
 %journal_catalog_update
-%endif # with python3
+%endif
 
 %post addon-vmcore
 %systemd_post abrt-vmcore.service
@@ -666,7 +667,7 @@ fi
 if [ -f /etc/abrt/plugins/CCpp.conf.rpmsave.atomic ]; then
     mv /etc/abrt/plugins/CCpp.conf.rpmsave.atomic /etc/abrt/plugins/CCpp.conf || exit 1
 fi
-%endif # with atomic
+%endif
 
 %if 0%{?rhel} && 0%{?rhel} <= 7
 %post libs -p /sbin/ldconfig
@@ -949,7 +950,7 @@ killall abrt-dbus >/dev/null 2>&1 || :
 %{python3_sitelib}/abrt3_container.pth
 %{python3_sitelib}/abrt_exception_handler3_container.py
 %{python3_sitelib}/__pycache__/abrt_exception_handler3_container.*
-%endif # with python3
+%endif
 
 %files plugin-sosreport
 %config(noreplace) %{_sysconfdir}/libreport/events.d/sosreport_event.conf
@@ -968,7 +969,7 @@ killall abrt-dbus >/dev/null 2>&1 || :
 %{python3_sitelib}/abrtcli/
 %{_mandir}/man1/abrt.1*
 %{_mandir}/man1/abrt-cli.1*
-%endif # with python3
+%endif
 
 %files desktop
 
@@ -1013,15 +1014,16 @@ killall abrt-dbus >/dev/null 2>&1 || :
 
 %files -n python3-abrt-doc
 %{python3_sitelib}/problem_examples
-%endif # with python3
+%endif
 
 %files console-notification
 %config(noreplace) %{_sysconfdir}/profile.d/abrt-console-notification.sh
 
 %changelog
-* Thu Jan 30 2020 Martin Kutlak <mkutlak@redhat.com> - 2.13.0-4
+* Fri Jan 31 2020 Martin Kutlak <mkutlak@redhat.com> - 2.13.0-4
 - Add patch to fix build failure with gcc -fno-common
 - Initialize bodhi karma values with defaults
+- Fix possibly uninitialized variable
 - Resolves: #1795820
 
 * Tue Jan 28 2020 Fedora Release Engineering <releng@fedoraproject.org> - 2.13.0-3

                 reply	other threads:[~2026-08-03 10:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178575263915.1.1652330478663307758.rpms-abrt-8f4c491a4bd5@fedoraproject.org \
    --to=mkutlak@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox