public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Jonathan Steffan <jsteffan@fedoraproject.org>
To: git-commits@fedoraproject.org
Subject: [rpms/envision] rawhide: Fix FTBFS (fedora#2503869).
Date: Sat, 01 Aug 2026 17:07:03 GMT	[thread overview]
Message-ID: <178560402396.1.8407031392289417693.rpms-envision-101cb5b0b37e@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/envision
Branch : rawhide
Commit : 101cb5b0b37ef7c3cf1705dbf78fd092bd368ce1
Author : Jonathan Steffan <jsteffan@fedoraproject.org>
Date   : 2026-08-01T11:06:17-06:00
Stats  : +29/-0 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/envision/c/101cb5b0b37ef7c3cf1705dbf78fd092bd368ce1?branch=rawhide

Log:
Fix FTBFS (fedora#2503869).

---
diff --git a/0001-fix-import-DeviceLogic-trait-for-libmonado-1.6.patch b/0001-fix-import-DeviceLogic-trait-for-libmonado-1.6.patch
new file mode 100644
index 0000000..ffa597a
--- /dev/null
+++ b/0001-fix-import-DeviceLogic-trait-for-libmonado-1.6.patch
@@ -0,0 +1,27 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Jonathan Steffan <jsteffan@fedoraproject.org>
+Date: Sat, 1 Aug 2026 10:53:00 -0600
+Subject: [PATCH] fix: import DeviceLogic trait for libmonado 1.6
+
+libmonado 1.6.0 moved Device::serial() and Device::battery_status()
+behind the DeviceLogic trait, which must be explicitly imported to be
+usable. Without the import, the build fails with:
+
+  error[E0599]: no method named `serial` found for struct
+  `libmonado::Device<'m>` in the current scope
+---
+ src/xr_devices.rs | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/xr_devices.rs b/src/xr_devices.rs
+--- a/src/xr_devices.rs
++++ b/src/xr_devices.rs
+@@ -1,4 +1,4 @@
+-use libmonado::{self, BatteryStatus, DeviceRole};
++use libmonado::{self, BatteryStatus, DeviceLogic, DeviceRole};
+ use std::{collections::HashMap, fmt::Display, slice::Iter};
+ use tracing::error;
+
+--
+2.52.0
+

diff --git a/envision.spec b/envision.spec
index 8ad3428..7119706 100644
--- a/envision.spec
+++ b/envision.spec
@@ -56,6 +56,8 @@ Patch0:         0001-fix-drop-RUSTFLAGS-override-from-cargo-clippy-test.patch
 Patch1:         0001-Bump-git2-dependency-from-0.19-to-0.20.patch
 # https://gitlab.com/gabmus/envision/-/merge_requests/145
 Patch2:         envision-fix-wivrn-apk-download-location.patch
+# Fix FTBFS with libmonado 1.6: DeviceLogic trait must be imported
+Patch3:         0001-fix-import-DeviceLogic-trait-for-libmonado-1.6.patch
 
 BuildRequires:  cargo
 BuildRequires:  cargo-rpm-macros >= 26

                 reply	other threads:[~2026-08-01 17:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178560402396.1.8407031392289417693.rpms-envision-101cb5b0b37e@fedoraproject.org \
    --to=jsteffan@fedoraproject.org \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox