From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 From: Michal Schmidt To: git-commits@fedoraproject.org Subject: [rpms/icecream] epel8: - Fix a fd leak from iceccd + avoid using system(). Date: Fri, 31 Jul 2026 06:33:38 GMT Message-ID: <178547961811.1.9830409132995392755.rpms-icecream-60f91a52139f@fedoraproject.org> List-ID: X-Git-Repo: rpms/icecream X-Git-Branch: epel8 X-Git-Rev: 60f91a52139f1b3e47bd27c1ffca30befb2cf630 ICAgICAgICAgICAgQSBuZXcgY29tbWl0IGhhcyBiZWVuIHB1c2hlZC4KCiAgICAgICAgICAgIFJl cG8gICA6IHJwbXMvaWNlY3JlYW0KICAgICAgICAgICAgQnJhbmNoIDogZXBlbDgKICAgICAgICAg ICAgQ29tbWl0IDogNjBmOTFhNTIxMzlmMWIzZTQ3YmQyN2MxZmZjYTMwYmVmYjJjZjYzMAogICAg ICAgICAgICBBdXRob3IgOiBNaWNoYWwgU2NobWlkdCA8bWljaGljaEBmZWRvcmFwcm9qZWN0Lm9y Zz4KICAgICAgICAgICAgRGF0ZSAgIDogMjAwOS0wMy0wMlQxMDoyMTowMCswMDowMAogICAgICAg ICAgICBTdGF0cyAgOiArMTI4Ly0xMSBpbiAzIGZpbGUocykKICAgICAgICAgICAgVVJMICAgIDog aHR0cHM6Ly9zcmMuZmVkb3JhcHJvamVjdC5vcmcvcnBtcy9pY2VjcmVhbS9jLzYwZjkxYTUyMTM5 ZjFiM2U0N2JkMjdjMWZmY2EzMGJlZmIyY2Y2MzA/YnJhbmNoPWVwZWw4CgogICAgICAgICAgICBM b2c6CiAgICAgICAgICAgIC0gRml4IGEgZmQgbGVhayBmcm9tIGljZWNjZCArIGF2b2lkIHVzaW5n IHN5c3RlbSgpLgotIEFsbG93cyB0aWdodGVyIFNFTGludXggcG9saWN5LgoKLS0tCmRpZmYgLS1n aXQgYS9pY2VjcmVhbS0wLjkuMy10aWdodGVuLXNlY3VyaXR5LnBhdGNoIGIvaWNlY3JlYW0tMC45 LjMtdGlnaHRlbi1zZWN1cml0eS5wYXRjaApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwLi4yMzNkNTFkCi0tLSAvZGV2L251bGwKKysrIGIvaWNlY3JlYW0tMC45LjMtdGlnaHRlbi1z ZWN1cml0eS5wYXRjaApAQCAtMCwwICsxLDExOCBAQAorY29tbWl0IDNjZjJlNGI0ZjE5MTJkMTg3 NzJhMGZhNDc2ZDQ2NzFjMjVjYTJlYTQKK0F1dGhvcjogY29vbG8gPGNvb2xvQDI4M2QwMmE3LTI1 ZjYtMDMxMC1iYzdjLWVjYjVjYmZlMTlkYT4KK0RhdGU6ICAgTW9uIE1hciAyIDA5OjQ3OjI2IDIw MDkgKzAwMDAKKworICAgIG1vcmUgZml4ZXMgZnJvbSBNaWNoYWwgU2NobWlkdDoKKyAgICAtIGRv bid0IGxlYWsgZmlsZSBkZXNjcmlwdG9yIHRvIGNyZWF0ZS1lbnYKKyAgICAtIGRvbid0IHVzZSB0 aGUgc2hlbGwgdG8gY2FsbCBzaW1wbGUgY29tbWFuZHMKKyAgICAKKyAgICAKKyAgICBnaXQtc3Zu LWlkOiBzdm46Ly9hbm9uc3ZuLmtkZS5vcmcvaG9tZS9rZGUvdHJ1bmsvaWNlY3JlYW1AOTM0MDQ0 IDI4M2QwMmE3LTI1ZjYtMDMxMC1iYzdjLWVjYjVjYmZlMTlkYQorCitkaWZmIC0tZ2l0IGEvZGFl bW9uL2Vudmlyb25tZW50LmNwcCBiL2RhZW1vbi9lbnZpcm9ubWVudC5jcHAKK2luZGV4IGZkMzhm OGUuLjlkYzI4MzEgMTAwNjQ0CistLS0gYS9kYWVtb24vZW52aXJvbm1lbnQuY3BwCisrKysgYi9k YWVtb24vZW52aXJvbm1lbnQuY3BwCitAQCAtMTQyLDQwICsxNDIsNDggQEAgc3RhdGljIHZvaWQg bGlzdF90YXJnZXRfZGlycyggY29uc3Qgc3RyaW5nICZjdXJyZW50X3RhcmdldCwgY29uc3Qgc3Ry aW5nICZ0YXJnZXQKKyAgICAgY2xvc2VkaXIoIGVudmRpciApOworIH0KKyAKKy1ib29sIGNsZWFu dXBfY2FjaGUoIGNvbnN0IHN0cmluZyAmYmFzZWRpciApCisrLyogUmV0dXJucyB0cnVlIGlmIHRo ZSBjaGlsZCBleGl0ZWQgd2l0aCBzdWNjZXNzICovCisrc3RhdGljIGJvb2wgZXhlY19hbmRfd2Fp dCggY29uc3QgY2hhciAqY29uc3QgYXJndltdICkKKyB7CistICAgIGZsdXNoX2RlYnVnKCk7Cisg ICAgIHBpZF90IHBpZCA9IGZvcmsoKTsKKy0gICAgaWYgKCBwaWQgKQorLSAgICB7CistICAgICAg ICBpbnQgc3RhdHVzID0gMDsKKysgICAgaWYgKCBwaWQgPT0gLTEgKSB7CisrICAgICAgICBsb2df cGVycm9yKCJmb3JrIik7CisrICAgICAgICByZXR1cm4gZmFsc2U7CisrICAgIH0KKysgICAgaWYg KCBwaWQgKSB7CisrICAgICAgICAvLyBwYXJlbnQKKysgICAgICAgIGludCBzdGF0dXM7CisgICAg ICAgICB3aGlsZSAoIHdhaXRwaWQoIHBpZCwgJnN0YXR1cywgMCApIDwgMCAmJiBlcnJubyA9PSBF SU5UUiApCisgICAgICAgICAgICAgOworKyAgICAgICAgcmV0dXJuIFdJRkVYSVRFRChzdGF0dXMp ICYmIFdFWElUU1RBVFVTKHN0YXR1cykgPT0gMDsKKysgICAgfQorKyAgICAvLyBjaGlsZAorKyAg ICBfZXhpdChleGVjdihhcmd2WzBdLCBjb25zdF9jYXN0PGNoYXIgKmNvbnN0ICo+KGFyZ3YpKSk7 CisrfQorIAorLSAgICAgICAgaWYgKCBta2RpciggYmFzZWRpci5jX3N0cigpLCAwNzU1ICkgJiYg ZXJybm8gIT0gRUVYSVNUICkgeworLSAgICAgICAgICAgIGlmICggZXJybm8gPT0gRVBFUk0gKQor LSAgICAgICAgICAgICAgICBsb2dfZXJyb3IoKSA8PCAicGVybWlzc2lvbiBkZW5pZWQgb24gbWtk aXIgIiA8PCBiYXNlZGlyIDw8IGVuZGw7CistICAgICAgICAgICAgZWxzZQorLSAgICAgICAgICAg ICAgICBsb2dfcGVycm9yKCAibWtkaXIgaW4gY2xlYW51cF9jYWNoZSgpIGZhaWxlZCIgKTsKKy0g ICAgICAgICAgICByZXR1cm4gZmFsc2U7CistICAgICAgICB9CistICAgICAgICBjaG93biggYmFz ZWRpci5jX3N0cigpLCAwLCAwICk7CistICAgICAgICBjaG1vZCggYmFzZWRpci5jX3N0cigpLCAw NzU1ICk7CisrYm9vbCBjbGVhbnVwX2NhY2hlKCBjb25zdCBzdHJpbmcgJmJhc2VkaXIgKQorK3sK KysgICAgZmx1c2hfZGVidWcoKTsKKyAKKy0gICAgICAgIHJldHVybiBXSUZFWElURUQoc3RhdHVz KTsKKy0gICAgfQorLSAgICAvLyBlbHNlCistICAgIGNoYXIgKiphcmd2OworLSAgICBhcmd2ID0g bmV3IGNoYXIqWzVdOworLSAgICBhcmd2WzBdID0gc3RyZHVwKCAiL2Jpbi9ybSIgKTsKKy0gICAg YXJndlsxXSA9IHN0cmR1cCggIi1yZiIgKTsKKy0gICAgYXJndlsyXSA9IHN0cmR1cCggIi0tIiAp OworICAgICAvLyBtYWtlIHN1cmUgaXQgZW5kcyB3aXRoICcvJyB0byBub3QgZmFsbCBpbnRvIHN5 bWxpbmsgdHJhcHMKKyAgICAgc3RyaW5nIGJkaXIgPSBiYXNlZGlyICsgJy8nOworLSAgICBhcmd2 WzNdID0gc3RyZHVwKCBiZGlyLmNfc3RyKCkgICk7CistICAgIGFyZ3ZbNF0gPSBOVUxMOworKyAg ICBjb25zdCBjaGFyICpjb25zdCBhcmd2W10gPSB7CisrICAgICAgICAiL2Jpbi9ybSIsICItcmYi LCAiLS0iLCBiZGlyLmNfc3RyKCksIE5VTEwKKysgICAgfTsKKyAKKy0gICAgX2V4aXQoZXhlY3Yo YXJndlswXSwgYXJndikpOworKyAgICBib29sIHJldCA9IGV4ZWNfYW5kX3dhaXQoIGFyZ3YgKTsK KysKKysgICAgaWYgKCBta2RpciggYmFzZWRpci5jX3N0cigpLCAwNzU1ICkgJiYgZXJybm8gIT0g RUVYSVNUICkgeworKyAgICAgICAgaWYgKCBlcnJubyA9PSBFUEVSTSApCisrICAgICAgICAgICAg bG9nX2Vycm9yKCkgPDwgInBlcm1pc3Npb24gZGVuaWVkIG9uIG1rZGlyICIgPDwgYmFzZWRpciA8 PCBlbmRsOworKyAgICAgICAgZWxzZQorKyAgICAgICAgICAgIGxvZ19wZXJyb3IoICJta2RpciBp biBjbGVhbnVwX2NhY2hlKCkgZmFpbGVkIiApOworKyAgICAgICAgcmV0dXJuIGZhbHNlOworKyAg ICB9CisrICAgIGNob3duKCBiYXNlZGlyLmNfc3RyKCksIDAsIDAgKTsKKysgICAgY2htb2QoIGJh c2VkaXIuY19zdHIoKSwgMDc1NSApOworKworKyAgICByZXR1cm4gcmV0OworIH0KKyAKKyBFbnZp cm9ubWVudHMgYXZhaWxhYmxlX2Vudmlyb25tbmVudHMoY29uc3Qgc3RyaW5nICZiYXNlZGlyKQor QEAgLTI1OSw3ICsyNjcsMTAgQEAgc2l6ZV90IHNldHVwX2Vudl9jYWNoZShjb25zdCBzdHJpbmcg JmJhc2VkaXIsIHN0cmluZyAmbmF0aXZlX2Vudmlyb25tZW50LCB1aWRfdAorICAgICAgICAgIF9l eGl0KDEpOworICAgICB9CisgCistICAgIGlmICggc3lzdGVtKCBCSU5ESVIgIi9pY2VjYyAtLWJ1 aWxkLW5hdGl2ZSIgKSApIHsKKysgICAgY29uc3QgY2hhciAqY29uc3QgYXJndltdID0geworKyAg ICAgICAgQklORElSICIvaWNlY2MiLCAiLS1idWlsZC1uYXRpdmUiLCBOVUxMCisrICAgIH07Cisr ICAgIGlmICggIWV4ZWNfYW5kX3dhaXQoIGFyZ3YgKSApIHsKKyAgICAgICAgIGxvZ19lcnJvcigp IDw8IEJJTkRJUiAiL2ljZWNjIC0tYnVpbGQtbmF0aXZlIGZhaWxlZFxuIjsKKyAgICAgICAgIF9l eGl0KDEpOworICAgICB9CitkaWZmIC0tZ2l0IGEvc2VydmljZXMvY29tbS5jcHAgYi9zZXJ2aWNl cy9jb21tLmNwcAoraW5kZXggNDdlNzMwNC4uNWZmYjc5MCAxMDA2NDQKKy0tLSBhL3NlcnZpY2Vz L2NvbW0uY3BwCisrKysgYi9zZXJ2aWNlcy9jb21tLmNwcAorQEAgLTk4Nyw2ICs5ODcsMTIgQEAg b3Blbl9zZW5kX2Jyb2FkY2FzdCAodm9pZCkKKyAgICAgICByZXR1cm4gLTE7CisgICAgIH0KKyAK KysgIGlmIChmY250bCAoYXNrX2ZkLCBGX1NFVEZELCBGRF9DTE9FWEVDKSA8IDApCisrICAgIHsK KysgICAgICBsb2dfcGVycm9yKCJvcGVuX3NlbmRfYnJvYWRjYXN0IGZjbnRsIik7CisrICAgICAg Y2xvc2UgKGFza19mZCk7CisrICAgICAgcmV0dXJuIC0xOworKyAgICB9CisgICBpbnQgb3B0dmFs ID0gMTsKKyAgIGlmIChzZXRzb2Nrb3B0IChhc2tfZmQsIFNPTF9TT0NLRVQsIFNPX0JST0FEQ0FT VCwgJm9wdHZhbCwgc2l6ZW9mKG9wdHZhbCkpIDwgMCkKKyAgICAgewoKZGlmZiAtLWdpdCBhL2lj ZWNyZWFtLnNwZWMgYi9pY2VjcmVhbS5zcGVjCmluZGV4IDVhNmE5OWEuLjNlZTk4MjcgMTAwNjQ0 Ci0tLSBhL2ljZWNyZWFtLnNwZWMKKysrIGIvaWNlY3JlYW0uc3BlYwpAQCAtMTEsNyArMTEsNyBA QAogCiBOYW1lOgkJaWNlY3JlYW0KIFZlcnNpb246CTAuOS4zCi1SZWxlYXNlOgk0JXs/ZGlzdH0K K1JlbGVhc2U6CTUlez9kaXN0fQogU3VtbWFyeToJRGlzdHJpYnV0ZWQgY29tcGlsZXIKIAogR3Jv dXA6CQlEZXZlbG9wbWVudC9Ub29scwpAQCAtMzAsNiArMzAsNyBAQCBTb3VyY2U4Ogkle25hbWV9 LW1hbnBhZ2VzLnRhci5iejIKIFBhdGNoMDoJCSV7bmFtZX0tcmVuYW1lLXNjaGVkdWxlci5wYXRj aAogUGF0Y2gxOgkJJXtuYW1lfS1jbGVhbnVwLWNvbmZmaWxlLnBhdGNoCiBQYXRjaDI6CQkle25h bWV9LTAuOS4zLWZpeC1nY2M0NC1mdGJmcy5wYXRjaAorUGF0Y2gzOgkJJXtuYW1lfS0wLjkuMy10 aWdodGVuLXNlY3VyaXR5LnBhdGNoCiAKIEJ1aWxkUm9vdDoJJXtfdG1wcGF0aH0vJXtuYW1lfS0l e3ZlcnNpb259LSV7cmVsZWFzZX0tcm9vdC0lKCV7X19pZF91fSAtbikKIApAQCAtNzgsNiArNzks NyBAQCBUaGlzIHBhY2thZ2UgY29udGFpbnMgZGV2ZWxvcG1lbnQgZmlsZXMgZm9yICV7bmFtZX0u CiAlcGF0Y2gwIC1wMQogJXBhdGNoMSAtcDAKICVwYXRjaDIgLXAxCislcGF0Y2gzIC1wMQogc2Vk IC1lICdzfEBMSUJESVJAfCV7X2xpYmRpcn18ZycgJXtTT1VSQ0UxfSA+IGljZWNyZWFtLnNoCiBz ZWQgLWUgJ3N8QExJQkRJUkB8JXtfbGliZGlyfXxnJyAle1NPVVJDRTJ9ID4gaWNlY3JlYW0uY3No CiBta2RpciBTRUxpbnV4CkBAIC0yMzUsNiArMjM3LDEwIEBAIHJtIC1yZiAle2J1aWxkcm9vdH0K ICV7X2xpYmRpcn0vcGtnY29uZmlnL2ljZWNjLnBjCiAKICVjaGFuZ2Vsb2cKKyogTW9uIE1hciAw MiAyMDA5IE1pY2hhbCBTY2htaWR0IDxtc2NobWlkdEByZWRoYXQuY29tPiAtIDAuOS4zLTUKKy0g Rml4IGEgZmQgbGVhayBmcm9tIGljZWNjZCArIGF2b2lkIHVzaW5nIHN5c3RlbSgpLgorLSBBbGxv d3MgdGlnaHRlciBTRUxpbnV4IHBvbGljeS4KKwogKiBUdWUgRmViIDI0IDIwMDkgRmVkb3JhIFJl bGVhc2UgRW5naW5lZXJpbmcgPHJlbC1lbmdAbGlzdHMuZmVkb3JhcHJvamVjdC5vcmc+IC0gMC45 LjMtNAogLSBSZWJ1aWx0IGZvciBodHRwczovL2ZlZG9yYXByb2plY3Qub3JnL3dpa2kvRmVkb3Jh XzExX01hc3NfUmVidWlsZAogCgpkaWZmIC0tZ2l0IGEvaWNlY3JlYW0udGUgYi9pY2VjcmVhbS50 ZQppbmRleCAzMTBmMzM3Li4wNjIyN2E2IDEwMDY0NAotLS0gYS9pY2VjcmVhbS50ZQorKysgYi9p Y2VjcmVhbS50ZQpAQCAtMSw1ICsxLDUgQEAKIAotcG9saWN5X21vZHVsZShpY2VjcmVhbSwwLjAu NDIpCitwb2xpY3lfbW9kdWxlKGljZWNyZWFtLDAuMC40MykKIAogIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIwogIwpAQCAtMTQ2LDE1ICsxNDYsOCBAQCBvcHRpb25hbF9w b2xpY3koYAogCW5zY2Rfc29ja2V0X3VzZShpY2VjY2RfY3JlYXRlZW52X3QpCiAnKQogCi0jIFNv bWUgcnVsZXMgdGhhdCBjYW4gcHJvYmFibHkgZ28gYXdheSB3aGVuIGljZWNjZCBpcyBmaXhlZCBw cm9wZXJseToKLSMKLSMgWFhYOiBpY2VjYy1jcmVhdGUtZW52IGRvZXMgbm90IHJlYWxseSBuZWVk IHRvIHRhbGsgdG8gdGhlIG9wZW4gVURQIHNvY2tldAotIyBsZWFrZWQgZnJvbSBpdHMgcGFyZW50 LgotZG9udGF1ZGl0IGljZWNjZF9jcmVhdGVlbnZfdCBpY2VjY2RfdDp1ZHBfc29ja2V0IHsgcmVh ZCB3cml0ZSB9OwotIyBYWFg6IGljZWNjZCBjb3VsZCBiZSBtb2RpZmllZCB0byBhdm9pZCB0aGUg c2hlbGwgY29tcGxldGVseQotY29yZWNtZF9leGVjX3NoZWxsKGljZWNjZF90KQotIyBYWFg6IGZp eCBpY2VjY2QgdG8gb25seSBudWtlIHRoZSBjb250ZW50cyBvZiAvdmFyL2NhY2hlL2ljZWNyZWFt LAotIyBub3QgdGhlIGRpcmVjdG9yeSBpdHNlbGYuCisjIFhYWDogVGhpcyBjb3VsZCBiZSBhdm9p ZGVkIGlmIGljZWNjZCBvbmx5IG51a2VkIHRoZSBjb250ZW50cyBvZgorIyAvdmFyL2NhY2hlL2lj ZWNyZWFtLCBub3QgdGhlIGRpcmVjdG9yeSBpdHNlbGYuCiBmaWxlc192YXJfZmlsZXRyYW5zKGlj ZWNjZF90LCBpY2VjY2RfY2FjaGVfdCwgZGlyKQogCiAK