From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 From: Michal Schmidt To: git-commits@fedoraproject.org Subject: [rpms/icecream] epel10: - Fix a fd leak from iceccd + avoid using system(). Date: Thu, 30 Jul 2026 15:15:29 GMT Message-ID: <178542452928.1.4729773031064729426.rpms-icecream-60f91a52139f@fedoraproject.org> List-ID: X-Git-Repo: rpms/icecream X-Git-Branch: epel10 X-Git-Rev: 60f91a52139f1b3e47bd27c1ffca30befb2cf630 ICAgICAgICAgICAgQSBuZXcgY29tbWl0IGhhcyBiZWVuIHB1c2hlZC4KCiAgICAgICAgICAgIFJl cG8gICA6IHJwbXMvaWNlY3JlYW0KICAgICAgICAgICAgQnJhbmNoIDogZXBlbDEwCiAgICAgICAg ICAgIENvbW1pdCA6IDYwZjkxYTUyMTM5ZjFiM2U0N2JkMjdjMWZmY2EzMGJlZmIyY2Y2MzAKICAg ICAgICAgICAgQXV0aG9yIDogTWljaGFsIFNjaG1pZHQgPG1pY2hpY2hAZmVkb3JhcHJvamVjdC5v cmc+CiAgICAgICAgICAgIERhdGUgICA6IDIwMDktMDMtMDJUMTA6MjE6MDArMDA6MDAKICAgICAg ICAgICAgU3RhdHMgIDogKzEyOC8tMTEgaW4gMyBmaWxlKHMpCiAgICAgICAgICAgIFVSTCAgICA6 IGh0dHBzOi8vc3JjLmZlZG9yYXByb2plY3Qub3JnL3JwbXMvaWNlY3JlYW0vYy82MGY5MWE1MjEz OWYxYjNlNDdiZDI3YzFmZmNhMzBiZWZiMmNmNjMwP2JyYW5jaD1lcGVsMTAKCiAgICAgICAgICAg IExvZzoKICAgICAgICAgICAgLSBGaXggYSBmZCBsZWFrIGZyb20gaWNlY2NkICsgYXZvaWQgdXNp bmcgc3lzdGVtKCkuCi0gQWxsb3dzIHRpZ2h0ZXIgU0VMaW51eCBwb2xpY3kuCgotLS0KZGlmZiAt LWdpdCBhL2ljZWNyZWFtLTAuOS4zLXRpZ2h0ZW4tc2VjdXJpdHkucGF0Y2ggYi9pY2VjcmVhbS0w LjkuMy10aWdodGVuLXNlY3VyaXR5LnBhdGNoCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAuLjIzM2Q1MWQKLS0tIC9kZXYvbnVsbAorKysgYi9pY2VjcmVhbS0wLjkuMy10aWdodGVu LXNlY3VyaXR5LnBhdGNoCkBAIC0wLDAgKzEsMTE4IEBACitjb21taXQgM2NmMmU0YjRmMTkxMmQx ODc3MmEwZmE0NzZkNDY3MWMyNWNhMmVhNAorQXV0aG9yOiBjb29sbyA8Y29vbG9AMjgzZDAyYTct MjVmNi0wMzEwLWJjN2MtZWNiNWNiZmUxOWRhPgorRGF0ZTogICBNb24gTWFyIDIgMDk6NDc6MjYg MjAwOSArMDAwMAorCisgICAgbW9yZSBmaXhlcyBmcm9tIE1pY2hhbCBTY2htaWR0OgorICAgIC0g ZG9uJ3QgbGVhayBmaWxlIGRlc2NyaXB0b3IgdG8gY3JlYXRlLWVudgorICAgIC0gZG9uJ3QgdXNl IHRoZSBzaGVsbCB0byBjYWxsIHNpbXBsZSBjb21tYW5kcworICAgIAorICAgIAorICAgIGdpdC1z dm4taWQ6IHN2bjovL2Fub25zdm4ua2RlLm9yZy9ob21lL2tkZS90cnVuay9pY2VjcmVhbUA5MzQw NDQgMjgzZDAyYTctMjVmNi0wMzEwLWJjN2MtZWNiNWNiZmUxOWRhCisKK2RpZmYgLS1naXQgYS9k YWVtb24vZW52aXJvbm1lbnQuY3BwIGIvZGFlbW9uL2Vudmlyb25tZW50LmNwcAoraW5kZXggZmQz OGY4ZS4uOWRjMjgzMSAxMDA2NDQKKy0tLSBhL2RhZW1vbi9lbnZpcm9ubWVudC5jcHAKKysrKyBi L2RhZW1vbi9lbnZpcm9ubWVudC5jcHAKK0BAIC0xNDIsNDAgKzE0Miw0OCBAQCBzdGF0aWMgdm9p ZCBsaXN0X3RhcmdldF9kaXJzKCBjb25zdCBzdHJpbmcgJmN1cnJlbnRfdGFyZ2V0LCBjb25zdCBz dHJpbmcgJnRhcmdldAorICAgICBjbG9zZWRpciggZW52ZGlyICk7CisgfQorIAorLWJvb2wgY2xl YW51cF9jYWNoZSggY29uc3Qgc3RyaW5nICZiYXNlZGlyICkKKysvKiBSZXR1cm5zIHRydWUgaWYg dGhlIGNoaWxkIGV4aXRlZCB3aXRoIHN1Y2Nlc3MgKi8KKytzdGF0aWMgYm9vbCBleGVjX2FuZF93 YWl0KCBjb25zdCBjaGFyICpjb25zdCBhcmd2W10gKQorIHsKKy0gICAgZmx1c2hfZGVidWcoKTsK KyAgICAgcGlkX3QgcGlkID0gZm9yaygpOworLSAgICBpZiAoIHBpZCApCistICAgIHsKKy0gICAg ICAgIGludCBzdGF0dXMgPSAwOworKyAgICBpZiAoIHBpZCA9PSAtMSApIHsKKysgICAgICAgIGxv Z19wZXJyb3IoImZvcmsiKTsKKysgICAgICAgIHJldHVybiBmYWxzZTsKKysgICAgfQorKyAgICBp ZiAoIHBpZCApIHsKKysgICAgICAgIC8vIHBhcmVudAorKyAgICAgICAgaW50IHN0YXR1czsKKyAg ICAgICAgIHdoaWxlICggd2FpdHBpZCggcGlkLCAmc3RhdHVzLCAwICkgPCAwICYmIGVycm5vID09 IEVJTlRSICkKKyAgICAgICAgICAgICA7CisrICAgICAgICByZXR1cm4gV0lGRVhJVEVEKHN0YXR1 cykgJiYgV0VYSVRTVEFUVVMoc3RhdHVzKSA9PSAwOworKyAgICB9CisrICAgIC8vIGNoaWxkCisr ICAgIF9leGl0KGV4ZWN2KGFyZ3ZbMF0sIGNvbnN0X2Nhc3Q8Y2hhciAqY29uc3QgKj4oYXJndikp KTsKKyt9CisgCistICAgICAgICBpZiAoIG1rZGlyKCBiYXNlZGlyLmNfc3RyKCksIDA3NTUgKSAm JiBlcnJubyAhPSBFRVhJU1QgKSB7CistICAgICAgICAgICAgaWYgKCBlcnJubyA9PSBFUEVSTSAp CistICAgICAgICAgICAgICAgIGxvZ19lcnJvcigpIDw8ICJwZXJtaXNzaW9uIGRlbmllZCBvbiBt a2RpciAiIDw8IGJhc2VkaXIgPDwgZW5kbDsKKy0gICAgICAgICAgICBlbHNlCistICAgICAgICAg ICAgICAgIGxvZ19wZXJyb3IoICJta2RpciBpbiBjbGVhbnVwX2NhY2hlKCkgZmFpbGVkIiApOwor LSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKy0gICAgICAgIH0KKy0gICAgICAgIGNob3duKCBi YXNlZGlyLmNfc3RyKCksIDAsIDAgKTsKKy0gICAgICAgIGNobW9kKCBiYXNlZGlyLmNfc3RyKCks IDA3NTUgKTsKKytib29sIGNsZWFudXBfY2FjaGUoIGNvbnN0IHN0cmluZyAmYmFzZWRpciApCisr eworKyAgICBmbHVzaF9kZWJ1ZygpOworIAorLSAgICAgICAgcmV0dXJuIFdJRkVYSVRFRChzdGF0 dXMpOworLSAgICB9CistICAgIC8vIGVsc2UKKy0gICAgY2hhciAqKmFyZ3Y7CistICAgIGFyZ3Yg PSBuZXcgY2hhcipbNV07CistICAgIGFyZ3ZbMF0gPSBzdHJkdXAoICIvYmluL3JtIiApOworLSAg ICBhcmd2WzFdID0gc3RyZHVwKCAiLXJmIiApOworLSAgICBhcmd2WzJdID0gc3RyZHVwKCAiLS0i ICk7CisgICAgIC8vIG1ha2Ugc3VyZSBpdCBlbmRzIHdpdGggJy8nIHRvIG5vdCBmYWxsIGludG8g c3ltbGluayB0cmFwcworICAgICBzdHJpbmcgYmRpciA9IGJhc2VkaXIgKyAnLyc7CistICAgIGFy Z3ZbM10gPSBzdHJkdXAoIGJkaXIuY19zdHIoKSAgKTsKKy0gICAgYXJndls0XSA9IE5VTEw7Cisr ICAgIGNvbnN0IGNoYXIgKmNvbnN0IGFyZ3ZbXSA9IHsKKysgICAgICAgICIvYmluL3JtIiwgIi1y ZiIsICItLSIsIGJkaXIuY19zdHIoKSwgTlVMTAorKyAgICB9OworIAorLSAgICBfZXhpdChleGVj dihhcmd2WzBdLCBhcmd2KSk7CisrICAgIGJvb2wgcmV0ID0gZXhlY19hbmRfd2FpdCggYXJndiAp OworKworKyAgICBpZiAoIG1rZGlyKCBiYXNlZGlyLmNfc3RyKCksIDA3NTUgKSAmJiBlcnJubyAh PSBFRVhJU1QgKSB7CisrICAgICAgICBpZiAoIGVycm5vID09IEVQRVJNICkKKysgICAgICAgICAg ICBsb2dfZXJyb3IoKSA8PCAicGVybWlzc2lvbiBkZW5pZWQgb24gbWtkaXIgIiA8PCBiYXNlZGly IDw8IGVuZGw7CisrICAgICAgICBlbHNlCisrICAgICAgICAgICAgbG9nX3BlcnJvciggIm1rZGly IGluIGNsZWFudXBfY2FjaGUoKSBmYWlsZWQiICk7CisrICAgICAgICByZXR1cm4gZmFsc2U7Cisr ICAgIH0KKysgICAgY2hvd24oIGJhc2VkaXIuY19zdHIoKSwgMCwgMCApOworKyAgICBjaG1vZCgg YmFzZWRpci5jX3N0cigpLCAwNzU1ICk7CisrCisrICAgIHJldHVybiByZXQ7CisgfQorIAorIEVu dmlyb25tZW50cyBhdmFpbGFibGVfZW52aXJvbm1uZW50cyhjb25zdCBzdHJpbmcgJmJhc2VkaXIp CitAQCAtMjU5LDcgKzI2NywxMCBAQCBzaXplX3Qgc2V0dXBfZW52X2NhY2hlKGNvbnN0IHN0cmlu ZyAmYmFzZWRpciwgc3RyaW5nICZuYXRpdmVfZW52aXJvbm1lbnQsIHVpZF90CisgICAgICAgICAg X2V4aXQoMSk7CisgICAgIH0KKyAKKy0gICAgaWYgKCBzeXN0ZW0oIEJJTkRJUiAiL2ljZWNjIC0t YnVpbGQtbmF0aXZlIiApICkgeworKyAgICBjb25zdCBjaGFyICpjb25zdCBhcmd2W10gPSB7Cisr ICAgICAgICBCSU5ESVIgIi9pY2VjYyIsICItLWJ1aWxkLW5hdGl2ZSIsIE5VTEwKKysgICAgfTsK KysgICAgaWYgKCAhZXhlY19hbmRfd2FpdCggYXJndiApICkgeworICAgICAgICAgbG9nX2Vycm9y KCkgPDwgQklORElSICIvaWNlY2MgLS1idWlsZC1uYXRpdmUgZmFpbGVkXG4iOworICAgICAgICAg X2V4aXQoMSk7CisgICAgIH0KK2RpZmYgLS1naXQgYS9zZXJ2aWNlcy9jb21tLmNwcCBiL3NlcnZp Y2VzL2NvbW0uY3BwCitpbmRleCA0N2U3MzA0Li41ZmZiNzkwIDEwMDY0NAorLS0tIGEvc2Vydmlj ZXMvY29tbS5jcHAKKysrKyBiL3NlcnZpY2VzL2NvbW0uY3BwCitAQCAtOTg3LDYgKzk4NywxMiBA QCBvcGVuX3NlbmRfYnJvYWRjYXN0ICh2b2lkKQorICAgICAgIHJldHVybiAtMTsKKyAgICAgfQor IAorKyAgaWYgKGZjbnRsIChhc2tfZmQsIEZfU0VURkQsIEZEX0NMT0VYRUMpIDwgMCkKKysgICAg eworKyAgICAgIGxvZ19wZXJyb3IoIm9wZW5fc2VuZF9icm9hZGNhc3QgZmNudGwiKTsKKysgICAg ICBjbG9zZSAoYXNrX2ZkKTsKKysgICAgICByZXR1cm4gLTE7CisrICAgIH0KKyAgIGludCBvcHR2 YWwgPSAxOworICAgaWYgKHNldHNvY2tvcHQgKGFza19mZCwgU09MX1NPQ0tFVCwgU09fQlJPQURD QVNULCAmb3B0dmFsLCBzaXplb2Yob3B0dmFsKSkgPCAwKQorICAgICB7CgpkaWZmIC0tZ2l0IGEv aWNlY3JlYW0uc3BlYyBiL2ljZWNyZWFtLnNwZWMKaW5kZXggNWE2YTk5YS4uM2VlOTgyNyAxMDA2 NDQKLS0tIGEvaWNlY3JlYW0uc3BlYworKysgYi9pY2VjcmVhbS5zcGVjCkBAIC0xMSw3ICsxMSw3 IEBACiAKIE5hbWU6CQlpY2VjcmVhbQogVmVyc2lvbjoJMC45LjMKLVJlbGVhc2U6CTQlez9kaXN0 fQorUmVsZWFzZToJNSV7P2Rpc3R9CiBTdW1tYXJ5OglEaXN0cmlidXRlZCBjb21waWxlcgogCiBH cm91cDoJCURldmVsb3BtZW50L1Rvb2xzCkBAIC0zMCw2ICszMCw3IEBAIFNvdXJjZTg6CSV7bmFt ZX0tbWFucGFnZXMudGFyLmJ6MgogUGF0Y2gwOgkJJXtuYW1lfS1yZW5hbWUtc2NoZWR1bGVyLnBh dGNoCiBQYXRjaDE6CQkle25hbWV9LWNsZWFudXAtY29uZmZpbGUucGF0Y2gKIFBhdGNoMjoJCSV7 bmFtZX0tMC45LjMtZml4LWdjYzQ0LWZ0YmZzLnBhdGNoCitQYXRjaDM6CQkle25hbWV9LTAuOS4z LXRpZ2h0ZW4tc2VjdXJpdHkucGF0Y2gKIAogQnVpbGRSb290Ogkle190bXBwYXRofS8le25hbWV9 LSV7dmVyc2lvbn0tJXtyZWxlYXNlfS1yb290LSUoJXtfX2lkX3V9IC1uKQogCkBAIC03OCw2ICs3 OSw3IEBAIFRoaXMgcGFja2FnZSBjb250YWlucyBkZXZlbG9wbWVudCBmaWxlcyBmb3IgJXtuYW1l fS4KICVwYXRjaDAgLXAxCiAlcGF0Y2gxIC1wMAogJXBhdGNoMiAtcDEKKyVwYXRjaDMgLXAxCiBz ZWQgLWUgJ3N8QExJQkRJUkB8JXtfbGliZGlyfXxnJyAle1NPVVJDRTF9ID4gaWNlY3JlYW0uc2gK IHNlZCAtZSAnc3xATElCRElSQHwle19saWJkaXJ9fGcnICV7U09VUkNFMn0gPiBpY2VjcmVhbS5j c2gKIG1rZGlyIFNFTGludXgKQEAgLTIzNSw2ICsyMzcsMTAgQEAgcm0gLXJmICV7YnVpbGRyb290 fQogJXtfbGliZGlyfS9wa2djb25maWcvaWNlY2MucGMKIAogJWNoYW5nZWxvZworKiBNb24gTWFy IDAyIDIwMDkgTWljaGFsIFNjaG1pZHQgPG1zY2htaWR0QHJlZGhhdC5jb20+IC0gMC45LjMtNQor LSBGaXggYSBmZCBsZWFrIGZyb20gaWNlY2NkICsgYXZvaWQgdXNpbmcgc3lzdGVtKCkuCistIEFs bG93cyB0aWdodGVyIFNFTGludXggcG9saWN5LgorCiAqIFR1ZSBGZWIgMjQgMjAwOSBGZWRvcmEg UmVsZWFzZSBFbmdpbmVlcmluZyA8cmVsLWVuZ0BsaXN0cy5mZWRvcmFwcm9qZWN0Lm9yZz4gLSAw LjkuMy00CiAtIFJlYnVpbHQgZm9yIGh0dHBzOi8vZmVkb3JhcHJvamVjdC5vcmcvd2lraS9GZWRv cmFfMTFfTWFzc19SZWJ1aWxkCiAKCmRpZmYgLS1naXQgYS9pY2VjcmVhbS50ZSBiL2ljZWNyZWFt LnRlCmluZGV4IDMxMGYzMzcuLjA2MjI3YTYgMTAwNjQ0Ci0tLSBhL2ljZWNyZWFtLnRlCisrKyBi L2ljZWNyZWFtLnRlCkBAIC0xLDUgKzEsNSBAQAogCi1wb2xpY3lfbW9kdWxlKGljZWNyZWFtLDAu MC40MikKK3BvbGljeV9tb2R1bGUoaWNlY3JlYW0sMC4wLjQzKQogCiAjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjCiAjCkBAIC0xNDYsMTUgKzE0Niw4IEBAIG9wdGlvbmFs X3BvbGljeShgCiAJbnNjZF9zb2NrZXRfdXNlKGljZWNjZF9jcmVhdGVlbnZfdCkKICcpCiAKLSMg U29tZSBydWxlcyB0aGF0IGNhbiBwcm9iYWJseSBnbyBhd2F5IHdoZW4gaWNlY2NkIGlzIGZpeGVk IHByb3Blcmx5OgotIwotIyBYWFg6IGljZWNjLWNyZWF0ZS1lbnYgZG9lcyBub3QgcmVhbGx5IG5l ZWQgdG8gdGFsayB0byB0aGUgb3BlbiBVRFAgc29ja2V0Ci0jIGxlYWtlZCBmcm9tIGl0cyBwYXJl bnQuCi1kb250YXVkaXQgaWNlY2NkX2NyZWF0ZWVudl90IGljZWNjZF90OnVkcF9zb2NrZXQgeyBy ZWFkIHdyaXRlIH07Ci0jIFhYWDogaWNlY2NkIGNvdWxkIGJlIG1vZGlmaWVkIHRvIGF2b2lkIHRo ZSBzaGVsbCBjb21wbGV0ZWx5Ci1jb3JlY21kX2V4ZWNfc2hlbGwoaWNlY2NkX3QpCi0jIFhYWDog Zml4IGljZWNjZCB0byBvbmx5IG51a2UgdGhlIGNvbnRlbnRzIG9mIC92YXIvY2FjaGUvaWNlY3Jl YW0sCi0jIG5vdCB0aGUgZGlyZWN0b3J5IGl0c2VsZi4KKyMgWFhYOiBUaGlzIGNvdWxkIGJlIGF2 b2lkZWQgaWYgaWNlY2NkIG9ubHkgbnVrZWQgdGhlIGNvbnRlbnRzIG9mCisjIC92YXIvY2FjaGUv aWNlY3JlYW0sIG5vdCB0aGUgZGlyZWN0b3J5IGl0c2VsZi4KIGZpbGVzX3Zhcl9maWxldHJhbnMo aWNlY2NkX3QsIGljZWNjZF9jYWNoZV90LCBkaXIpCiAKIAo=