public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Rostislav Krasny <rostiprodev@gmail.com>
To: git-commits@fedoraproject.org
Subject: [rpms/nss] f44: Address review feedback for DRBG fork handling
Date: Wed, 29 Jul 2026 17:38:26 GMT	[thread overview]
Message-ID: <178534670640.1.13490866358257181451.rpms-nss-f5cbee7a8834@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/nss
Branch : f44
Commit : f5cbee7a8834f96eb858b44920f4455f73580f27
Author : Rostislav Krasny <rostiprodev@gmail.com>
Date   : 2026-07-29T16:43:25+03:00
Stats  : +12/-1 in 1 file(s)
URL    : https://src.fedoraproject.org/rpms/nss/c/f5cbee7a8834f96eb858b44920f4455f73580f27?branch=f44

Log:
Address review feedback for DRBG fork handling

---
diff --git a/nss-3.125-drbg-reseed-after-fork.patch b/nss-3.125-drbg-reseed-after-fork.patch
index ef3d034..9f73f89 100644
--- a/nss-3.125-drbg-reseed-after-fork.patch
+++ b/nss-3.125-drbg-reseed-after-fork.patch
@@ -78,10 +78,21 @@
 +     * inherited state is rebuilt.  prng_GenerateGlobalRandomBytes() makes the
 +     * same check; without it the PR_Lock() below dereferences NULL. */
 +    if (globalrng == NULL) {
-+        PORT_SetError(SEC_ERROR_INVALID_ARGS);
++        PORT_SetError(SEC_ERROR_LIBRARY_FAILURE);
 +        return SECFailure;
 +    }
 +
      PR_Lock(globalrng->lock);
      /* if we're passed more than our additionalDataCache, simply
       * call reseed with that data */
+@@ -736,10 +793,9 @@
+ void
+ RNG_RNGShutdown(void)
+ {
+     /* check for a valid global RNG context */
+-    PORT_Assert(globalrng != NULL);
+     if (globalrng == NULL) {
+         /* Should set a "not initialized" error code. */
+         PORT_SetError(SEC_ERROR_NO_MEMORY);
+         return;
+     }

                 reply	other threads:[~2026-07-29 17:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178534670640.1.13490866358257181451.rpms-nss-f5cbee7a8834@fedoraproject.org \
    --to=rostiprodev@gmail.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox