public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Susi Lehtola <jussilehtola@fedoraproject.org>
To: git-commits@fedoraproject.org
Subject: [rpms/dftd4] rawhide: Add the numerical hessian to dftd4_api
Date: Wed, 29 Jul 2026 11:56:55 GMT [thread overview]
Message-ID: <178532621511.1.12223378467579559383.rpms-dftd4-6bf1f6e380fc@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/dftd4
Branch : rawhide
Commit : 6bf1f6e380fcb4daac5d37b23b2b60f10cb082e0
Author : Susi Lehtola <jussilehtola@fedoraproject.org>
Date : 2026-07-29T11:56:45+00:00
Stats : +25/-0 in 2 file(s)
URL : https://src.fedoraproject.org/rpms/dftd4/c/6bf1f6e380fcb4daac5d37b23b2b60f10cb082e0?branch=rawhide
Log:
Add the numerical hessian to dftd4_api
---
diff --git a/dftd4-4.2.0-export-numerical-hessian.patch b/dftd4-4.2.0-export-numerical-hessian.patch
new file mode 100644
index 0000000..f853bf1
--- /dev/null
+++ b/dftd4-4.2.0-export-numerical-hessian.patch
@@ -0,0 +1,21 @@
+Export get_numerical_hessian_api from the dftd4_api module.
+
+The module defaults to PRIVATE, and get_numerical_hessian_api is the only
+bind(C) API routine that was never added to a public list. GCC used to emit
+the binding label as a global symbol anyway, but as of gcc 16.1.1-4 the
+unreferenced private module procedure gets dropped/localized during LTO, so
+libdftd4.so no longer exports dftd4_get_numerical_hessian and the C API
+tester fails to link:
+
+ undefined reference to `dftd4_get_numerical_hessian'
+
+--- a/src/dftd4/api.f90
++++ b/src/dftd4/api.f90
+@@ -55,6 +55,7 @@
+ public :: delete_param_api
+
+ public :: get_dispersion_api, get_pairwise_dispersion_api, get_properties_api
++ public :: get_numerical_hessian_api
+
+ !> Namespace for C routines
+ character(len=*), parameter :: namespace = "dftd4_"
diff --git a/dftd4.spec b/dftd4.spec
index 0e9a54b..ad2bdbf 100644
--- a/dftd4.spec
+++ b/dftd4.spec
@@ -5,6 +5,9 @@ Summary: Generally Applicable Atomic-Charge Dependent London Dispersion C
License: LGPL-3.0-or-later
URL: https://dftd4.readthedocs.io/
Source0: https://github.com/dftd4/dftd4/archive/v%{version}/%{name}-%{version}.tar.gz
+# get_numerical_hessian_api is missing from the public list of the dftd4_api
+# module, so gcc >= 16.1.1-4 drops the dftd4_get_numerical_hessian symbol
+Patch0: dftd4-4.2.0-export-numerical-hessian.patch
BuildRequires: meson
BuildRequires: gcc-gfortran
@@ -36,6 +39,7 @@ This package contains the Python 3 interface for dftd4.
%prep
%setup -q
+%patch -P 0 -p 1 -b .numhess
%build
%ifarch %{ix86}
reply other threads:[~2026-07-29 11:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178532621511.1.12223378467579559383.rpms-dftd4-6bf1f6e380fc@fedoraproject.org \
--to=jussilehtola@fedoraproject.org \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox