public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Filipe Rosset <filiperosset@fedoraproject.org>
To: git-commits@fedoraproject.org
Subject: [rpms/bygfoot] rawhide: fix symbol export for rawhide / Xfce, fixes rhbz#2380484
Date: Mon, 27 Jul 2026 15:05:46 GMT	[thread overview]
Message-ID: <178516474621.1.1998018635027005762.rpms-bygfoot-f1642a892a29@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/bygfoot
            Branch : rawhide
            Commit : f1642a892a2905d14341eda9220011b8266a74e3
            Author : Filipe Rosset <filiperosset@fedoraproject.org>
            Date   : 2026-07-26T00:18:37-03:00
            Stats  : +66/-11 in 4 file(s)
            URL    : https://src.fedoraproject.org/rpms/bygfoot/c/f1642a892a2905d14341eda9220011b8266a74e3?branch=rawhide

            Log:
            fix symbol export for rawhide / Xfce, fixes rhbz#2380484

Signed-off-by: Filipe Rosset <filiperosset@fedoraproject.org>

---
diff --git a/bygfoot-export-dynamic.patch b/bygfoot-export-dynamic.patch
new file mode 100644
index 0000000..b5d0ac8
--- /dev/null
+++ b/bygfoot-export-dynamic.patch
@@ -0,0 +1,11 @@
+diff -urN bygfoot-3.0.0.orig/CMakeLists.txt bygfoot-3.0.0/CMakeLists.txt
+--- bygfoot-3.0.0.orig/CMakeLists.txt	2026-02-17 00:00:00.000000000 +00:00
++++ bygfoot-3.0.0/CMakeLists.txt	2026-06-26 00:00:00.000000000 +00:00
+@@ -154,6 +154,7 @@
+ target_compile_options(bygfoot PRIVATE
+ 	               -Wno-deprecated-declarations
+ 		       -fcommon)
++set_target_properties(bygfoot PROPERTIES ENABLE_EXPORTS TRUE)
+ # Link the target to the GTK+ libraries
+ target_link_libraries (bygfoot ${GTK2_LIBRARIES} ${GLIB_LIBRARIES} m
+                                ${ZLIB_LIBRARIES} ${JSON-C_LIBRARIES}

diff --git a/bygfoot.desktop b/bygfoot.desktop
index e246fd0..ad6943d 100644
--- a/bygfoot.desktop
+++ b/bygfoot.desktop
@@ -11,8 +11,8 @@ Comment[nl]=Een simpele en verslavende GTK2 voetbal manager
 Comment[pl]=Prosty, ale wciągający menedżer piłkarski
 Comment[ro]=Un simplu si captivant manager de fotbal bazat pe GTK2
 Comment[sv]=En enkel och vanebildande fotbollsmanager för GTK2
-Exec=/usr/bin/bygfoot
-Icon=/usr/share/bygfoot/support_files/pixmaps/bygfoot_icon.png
+Exec=bygfoot
+Icon=bygfoot
 Terminal=false
 Type=Application
 

diff --git a/bygfoot.metainfo.xml b/bygfoot.metainfo.xml
new file mode 100644
index 0000000..6e83d6a
--- /dev/null
+++ b/bygfoot.metainfo.xml
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<component type="desktop">
+  <id>bygfoot.desktop</id>
+  <metadata_license>CC0-1.0</metadata_license>
+  <project_license>GPL-2.0-only</project_license>
+  <name>Bygfoot</name>
+  <summary>Football management game</summary>
+  <description>
+    <p>
+      Bygfoot is a small and simple graphical football (soccer) manager game
+      featuring many international leagues and cups. You manage a team from
+      one such league: you form the team, buy and sell players, get promoted or
+      relegated and try to be successful.
+    </p>
+  </description>
+  <launchable type="desktop-id">bygfoot.desktop</launchable>
+  <url type="homepage">http://www.bygfoot.com/</url>
+  <provides>
+    <binary>bygfoot</binary>
+  </provides>
+  <releases>
+    <release version="3.0.0" date="2026-02-17"/>
+  </releases>
+</component>

diff --git a/bygfoot.spec b/bygfoot.spec
index d9a2cd4..cb5cb8f 100644
--- a/bygfoot.spec
+++ b/bygfoot.spec
@@ -1,20 +1,24 @@
 Name:           bygfoot
 Version:        3.0.0
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        Football management game
-# Automatically converted from old format: GPLv2 - review is highly recommended.
 License:        GPL-2.0-only
 URL:            http://www.bygfoot.com
 Source0:        https://gitlab.com/bygfoot/bygfoot/-/archive/%{version}/bygfoot-%{version}.tar.bz2
 Source1:        bygfoot.desktop
+Source2:        bygfoot.metainfo.xml
+Patch0:         bygfoot-export-dynamic.patch
 
-BuildRequires:  gcc
+BuildRequires:  cmake
 BuildRequires:  desktop-file-utils
-BuildRequires:  gtk2-devel gettext
-BuildRequires:  ninja-build cmake
+BuildRequires:  gcc
+BuildRequires:  gettext
+BuildRequires:  gtk2-devel
 BuildRequires:  json-c-devel
+BuildRequires:  libappstream-glib
+BuildRequires:  ninja-build
 BuildRequires:  sqlite-devel
-Requires: bygfoot-data
+Requires: %{name}-data = %{version}-%{release}
 
 %description
 Bygfoot is a small and simple graphical football (a.k.a. soccer) manager game 
@@ -23,12 +27,12 @@ league: you form the team, buy and sell players, get promoted or relegated and
 of course try to be successful.
 
 %package data
-Summary: bygfoot country definitions and other game files.
-BuildArch:	noarch
+Summary: Bygfoot country definitions and other game files.
+BuildArch: noarch
 
 
 %description data
-bygfoot country definitions and other game files.
+Bygfoot country definitions and other game files.
 
 %prep
 %autosetup -n %{name}-%{version} -p1
@@ -51,16 +55,32 @@ bygfoot country definitions and other game files.
 %find_lang %{name}
 desktop-file-install --dir %{buildroot}%{_datadir}/applications %{SOURCE1}
 
+# Install icon to standard directory
+mkdir -p %{buildroot}%{_datadir}/pixmaps
+install -p -m 0644 %{buildroot}%{_datadir}/bygfoot/support_files/pixmaps/bygfoot_icon.png %{buildroot}%{_datadir}/pixmaps/bygfoot.png
+
+# Install metainfo file
+install -D -p -m 0644 %{SOURCE2} %{buildroot}%{_metainfodir}/bygfoot.metainfo.xml
+
+%check
+desktop-file-validate %{buildroot}%{_datadir}/applications/bygfoot.desktop
+appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/bygfoot.metainfo.xml
+
 %files -f %{name}.lang
 %doc AUTHORS ChangeLog README TODO UPDATE
 %license COPYING
 %{_bindir}/bygfoot*
 %{_datadir}/applications/bygfoot.desktop
+%{_datadir}/pixmaps/bygfoot.png
+%{_metainfodir}/bygfoot.metainfo.xml
 
 %files data
 %{_datadir}/bygfoot
 
 %changelog
+* Fri Jun 26 2026 Filipe Rosset <filiperosset@fedoraproject.org> - 3.0.0-3
+- fix symbol export for rawhide / Xfce, fixes rhbz#2380484
+
 * Wed Jul 15 2026 Fedora Release Engineering <releng@fedoraproject.org> - 3.0.0-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_45_Mass_Rebuild
 

                 reply	other threads:[~2026-07-27 15:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178516474621.1.1998018635027005762.rpms-bygfoot-f1642a892a29@fedoraproject.org \
    --to=filiperosset@fedoraproject.org \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox