public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Mohamed El Morabity <melmorabity@fedoraproject.org>
To: git-commits@fedoraproject.org
Subject: [rpms/python-streamlink] rawhide: Fix build with requests >= 2.34
Date: Sun, 26 Jul 2026 14:33:16 GMT	[thread overview]
Message-ID: <178507639672.1.8037701885006024761.rpms-python-streamlink-fdd7bb704c37@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/python-streamlink
Branch : rawhide
Commit : fdd7bb704c37e683881520d993a0a143901e966f
Author : Mohamed El Morabity <melmorabity@fedoraproject.org>
Date   : 2026-07-26T16:33:00+02:00
Stats  : +47/-1 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/python-streamlink/c/fdd7bb704c37e683881520d993a0a143901e966f?branch=rawhide

Log:
Fix build with requests >= 2.34

---
diff --git a/python-streamlink-8.4.0-requests_2.34.patch b/python-streamlink-8.4.0-requests_2.34.patch
new file mode 100644
index 0000000..b1259cc
--- /dev/null
+++ b/python-streamlink-8.4.0-requests_2.34.patch
@@ -0,0 +1,40 @@
+--- src/streamlink/session/http.py.orig	2026-07-26 14:17:22.850972682 +0200
++++ src/streamlink/session/http.py	2026-07-26 14:17:22.855763923 +0200
+@@ -255,7 +255,7 @@ class HTTPSession(Session):
+         encoding = kwargs.pop("encoding", None)
+         exception = kwargs.pop("exception", PluginError)
+         headers = kwargs.pop("headers", {})
+-        params = kwargs.pop("params", {})
++        params = kwargs.pop("params", None)
+         proxies = kwargs.pop("proxies", self.proxies)
+         raise_for_status = kwargs.pop("raise_for_status", True)
+         schema = kwargs.pop("schema", None)
+@@ -268,7 +268,10 @@ class HTTPSession(Session):
+ 
+         if session:
+             headers.update(session.headers)
+-            params.update(session.params)
++            if params is None:
++                params = dict(session.params)
++            else:
++                params.update(session.params)
+ 
+         while True:
+             try:
+--- tests/session/test_http.py.orig	2026-07-26 14:17:22.852487827 +0200
++++ tests/session/test_http.py	2026-07-26 14:17:22.857070613 +0200
+@@ -165,10 +165,10 @@ class TestHTTPSession:
+             session.get("http://localhost/", timeout=123, retries=3, retry_backoff=2, retry_max_backoff=5)
+ 
+         assert mock_request.call_args_list == [
+-            call("GET", "http://localhost/", headers={}, params={}, timeout=123, proxies={}, allow_redirects=True),
+-            call("GET", "http://localhost/", headers={}, params={}, timeout=123, proxies={}, allow_redirects=True),
+-            call("GET", "http://localhost/", headers={}, params={}, timeout=123, proxies={}, allow_redirects=True),
+-            call("GET", "http://localhost/", headers={}, params={}, timeout=123, proxies={}, allow_redirects=True),
++            call("GET", "http://localhost/", headers={}, params=None, timeout=123, proxies={}, allow_redirects=True),
++            call("GET", "http://localhost/", headers={}, params=None, timeout=123, proxies={}, allow_redirects=True),
++            call("GET", "http://localhost/", headers={}, params=None, timeout=123, proxies={}, allow_redirects=True),
++            call("GET", "http://localhost/", headers={}, params=None, timeout=123, proxies={}, allow_redirects=True),
+         ]
+         assert mock_sleep.call_args_list == [
+             call(2),

diff --git a/python-streamlink.spec b/python-streamlink.spec
index e0e6122..99c301c 100644
--- a/python-streamlink.spec
+++ b/python-streamlink.spec
@@ -8,7 +8,7 @@ Livestreamer, which is no longer maintained.}
 
 Name:           python-%{srcname}
 Version:        8.4.0
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        Python library for extracting streams from various websites
 
 # src/streamlink/packages/requests_file.py is Apache-2.0
@@ -21,6 +21,9 @@ Patch0:         %{name}-8.1.0-documentation.patch
 Patch1:         %{name}-8.1.0-pytest_8.3.patch
 # Fix tests with Python 3.15 argparse colorization API
 Patch2:         %{name}-8.4.0-python3.15_tests.patch
+# Fix HTTPSession.request() params handling with requests >= 2.34 (partially
+# backported from https://github.com/streamlink/streamlink/commit/1ec2b2f)
+Patch3:         %{name}-8.4.0-requests_2.34.patch
 BuildRequires:  make
 BuildRequires:  python3-devel
 # For easy patching of pyproject.toml
@@ -124,6 +127,9 @@ install -Dpm 0644 -t $RPM_BUILD_ROOT%{zsh_completions_dir} completions/zsh/_%{sr
 
 
 %changelog
+* Sun Jul 26 2026 Mohamed El Morabity <melmorabity@fedoraproject.org> - 8.4.0-3
+- Fix build with requests >= 2.34
+
 * Thu Jul 16 2026 Fedora Release Engineering <releng@fedoraproject.org> - 8.4.0-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_45_Mass_Rebuild
 

                 reply	other threads:[~2026-07-26 14:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178507639672.1.8037701885006024761.rpms-python-streamlink-fdd7bb704c37@fedoraproject.org \
    --to=melmorabity@fedoraproject.org \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox