public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Michal Schorm <mschorm@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/cinnamon] rawhide: Remove dead cinnamon2d rm commands from %install
Date: Sun, 26 Jul 2026 14:03:46 GMT	[thread overview]
Message-ID: <178507462644.1.402230009239011642.rpms-cinnamon-6044b268a968@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/cinnamon
            Branch : rawhide
            Commit : 6044b268a968612b68f548a1f6fe1aaffa353061
            Author : Michal Schorm <mschorm@redhat.com>
            Date   : 2026-07-26T15:44:08+02:00
            Stats  : +1/-4 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/cinnamon/c/6044b268a968612b68f548a1f6fe1aaffa353061?branch=rawhide

            Log:
            Remove dead cinnamon2d rm commands from %install

Only 2 of the 5 cinnamon2d rm targets actually exist in the
upstream source tarball:
- 'files/usr/bin/cinnamon2d'
  https://github.com/linuxmint/cinnamon/blob/6.7.4-unstable/files/usr/bin/cinnamon2d
- 'man/cinnamon2d.1'
  https://github.com/linuxmint/cinnamon/blob/6.7.4-unstable/man/cinnamon2d.1

The other 3 targets do not exist and the rm commands were no-ops:
- 'cinnamon-session-cinnamon2d' (no such binary)
- 'applications/cinnamon2d.desktop' (no such file)
- 'xsessions/cinnamon2d.desktop' (no such file)

Co-Authored-By: Claude AI <noreply@anthropic.com>

---
diff --git a/cinnamon.spec b/cinnamon.spec
index 47e5e7f..ed3692c 100644
--- a/cinnamon.spec
+++ b/cinnamon.spec
@@ -248,11 +248,8 @@ EOF
 # Delete useless gir files
 %{__rm} -rf %{buildroot}%{_datadir}/%{name}/*.gir
 
-# Delete cinnamon2d session files
+# Delete cinnamon2d files
 %{__rm} -rf %{buildroot}%{_bindir}/cinnamon2d
-%{__rm} -rf %{buildroot}%{_bindir}/cinnamon-session-cinnamon2d
-%{__rm} -rf %{buildroot}%{_datadir}/applications/cinnamon2d.desktop
-%{__rm} -rf %{buildroot}%{_datadir}/xsessions/cinnamon2d.desktop
 %{__rm} -rf %{buildroot}%{_mandir}/man1/cinnamon2d*
 
 %check

                 reply	other threads:[~2026-07-26 14:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178507462644.1.402230009239011642.rpms-cinnamon-6044b268a968@fedoraproject.org \
    --to=mschorm@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox