public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Michal Schorm <mschorm@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/cinnamon] rawhide: Move 'gnome-calendar' from Requires to Recommends on main package
Date: Sun, 26 Jul 2026 14:03:44 GMT	[thread overview]
Message-ID: <178507462499.1.9199982871195356761.rpms-cinnamon-12d013ff4d3b@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/cinnamon
            Branch : rawhide
            Commit : 12d013ff4d3bb9314fee344a8f676360102669d0
            Author : Michal Schorm <mschorm@redhat.com>
            Date   : 2026-07-26T14:08:58+02:00
            Stats  : +1/-1 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/cinnamon/c/12d013ff4d3bb9314fee344a8f676360102669d0?branch=rawhide

            Log:
            Move 'gnome-calendar' from Requires to Recommends on main package

'gnome-calendar' was a hard Requires on the 'calendar-server'
subpackage, but it is not used by the calendar server at all —
'cinnamon-calendar-server.py' only imports ECal, EDataServer,
and ICal from GI:
https://github.com/linuxmint/cinnamon/blob/6.7.4-unstable/calendar-server/cinnamon-calendar-server.py#L14-L22

'gnome-calendar' IS used by the main cinnamon package in the
calendar applet's 'eventView.js', but with graceful degradation:

- Line 668: button only made reactive if gnome-calendar is found
  via GLib.find_program_in_path()
- Line 738: launches 'gnome-calendar --date' to open a date view
- Line 812: launches 'gnome-calendar --uuid' to open a specific event
- Line 868: event click handler only enabled if gnome-calendar found

https://github.com/linuxmint/cinnamon/blob/6.7.4-unstable/files/usr/share/cinnamon/applets/calendar%40cinnamon.org/eventView.js#L668
https://github.com/linuxmint/cinnamon/blob/6.7.4-unstable/files/usr/share/cinnamon/applets/calendar%40cinnamon.org/eventView.js#L738
https://github.com/linuxmint/cinnamon/blob/6.7.4-unstable/files/usr/share/cinnamon/applets/calendar%40cinnamon.org/eventView.js#L868

Since all usage is guarded by 'find_program_in_path()' checks,
the dependency is optional — Recommends is the right strength.

Move it from Requires on 'calendar-server' to Recommends on the
main package, next to the existing calendar-server Recommends.

Linux Mint's 'debian/control' has no gnome-calendar dependency:
https://github.com/linuxmint/cinnamon/blob/6.7.4-unstable/debian/control

Co-Authored-By: Claude AI <noreply@anthropic.com>

---
diff --git a/cinnamon.spec b/cinnamon.spec
index e4ba55c..73f3450 100644
--- a/cinnamon.spec
+++ b/cinnamon.spec
@@ -142,6 +142,7 @@ Requires:       python3-xapps-overrides%{?_isa}
 
 # required for calendar applet events
 Recommends:     %{name}-calendar-server%{?_isa} = %{version}-%{release}
+Recommends:     gnome-calendar
 
 # required for network applet
 Requires:       nm-connection-editor%{?_isa}
@@ -193,7 +194,6 @@ them with an easy to use and comfortable desktop experience.
 Summary:        Calendar server for Cinnamon
 Requires:       %{name}%{?_isa} = %{version}-%{release}
 Requires:       evolution-data-server%{?_isa}
-Requires:       gnome-calendar%{?_isa}
 
 %description calendar-server
 Calendar server for Cinnamon.

                 reply	other threads:[~2026-07-26 14:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178507462499.1.9199982871195356761.rpms-cinnamon-12d013ff4d3b@fedoraproject.org \
    --to=mschorm@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox