public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Michal Schorm <mschorm@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/cinnamon] rawhide: Add missing direct BuildRequires from 'meson.build'
Date: Sun, 26 Jul 2026 14:03:43 GMT [thread overview]
Message-ID: <178507462355.1.12531288749303045460.rpms-cinnamon-57b00e6bc698@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/cinnamon
Branch : rawhide
Commit : 57b00e6bc698b702e486ce04659e87720e1933f9
Author : Michal Schorm <mschorm@redhat.com>
Date : 2026-07-26T14:08:30+02:00
Stats : +5/-0 in 1 file(s)
URL : https://src.fedoraproject.org/rpms/cinnamon/c/57b00e6bc698b702e486ce04659e87720e1933f9?branch=rawhide
Log:
Add missing direct BuildRequires from 'meson.build'
Add BuildRequires for dependencies that are direct 'dependency()'
calls in the upstream 'meson.build' but were missing from the spec:
https://github.com/linuxmint/cinnamon/blob/6.7.4-unstable/meson.build
- 'pkgconfig(gstreamer-base-1.0)' — meson.build line 80
https://github.com/linuxmint/cinnamon/blob/6.7.4-unstable/meson.build#L80
- 'pkgconfig(dbus-1)' — meson.build line 24
https://github.com/linuxmint/cinnamon/blob/6.7.4-unstable/meson.build#L24
- 'pkgconfig(gtk+-3.0)' — meson.build line 50
https://github.com/linuxmint/cinnamon/blob/6.7.4-unstable/meson.build#L50
- 'pkgconfig(libxml-2.0)' — meson.build line 58
https://github.com/linuxmint/cinnamon/blob/6.7.4-unstable/meson.build#L58
- 'pkgconfig(x11)' — meson.build line 55
https://github.com/linuxmint/cinnamon/blob/6.7.4-unstable/meson.build#L55
Not adding 'xcomposite'/'xext' — while these have unconditional
'dependency()' calls at meson.build lines 56-57, they are pulled
in transitively via 'gtk3-devel':
https://github.com/linuxmint/cinnamon/blob/6.7.4-unstable/meson.build#L56-L57
Linux Mint's 'debian/control' lists 'libdbus-1-dev' and
'libgtk-3-dev' but not 'libxml-2.0' or 'x11' (pulled
transitively on Debian). LM also does not list
'gstreamer-base-1.0' separately:
https://github.com/linuxmint/cinnamon/blob/6.7.4-unstable/debian/control#L15-L21
Co-Authored-By: Claude AI <noreply@anthropic.com>
---
diff --git a/cinnamon.spec b/cinnamon.spec
index 4db0b4c..cef2920 100644
--- a/cinnamon.spec
+++ b/cinnamon.spec
@@ -48,9 +48,14 @@ BuildRequires: pkgconfig(libnm)
BuildRequires: pkgconfig(pam)
BuildRequires: pkgconfig(polkit-agent-1)
BuildRequires: pkgconfig(xapp)
+BuildRequires: pkgconfig(dbus-1)
+BuildRequires: pkgconfig(gtk+-3.0)
+BuildRequires: pkgconfig(libxml-2.0)
+BuildRequires: pkgconfig(x11)
# for screencast recorder functionality
BuildRequires: pkgconfig(gstreamer-1.0)
+BuildRequires: pkgconfig(gstreamer-base-1.0)
BuildRequires: pkgconfig(libmuffin-0) >= %{muffin_version}
reply other threads:[~2026-07-26 14:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178507462355.1.12531288749303045460.rpms-cinnamon-57b00e6bc698@fedoraproject.org \
--to=mschorm@redhat.com \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox