public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Michal Schorm <mschorm@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/cinnamon] rawhide: Remove ghost BuildRequires not used by 'meson.build'
Date: Sun, 26 Jul 2026 14:03:42 GMT	[thread overview]
Message-ID: <178507462257.1.17251397752671821840.rpms-cinnamon-b1980fa63636@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/cinnamon
            Branch : rawhide
            Commit : b1980fa6363698b1578c48c6e13e842efa16d221
            Author : Michal Schorm <mschorm@redhat.com>
            Date   : 2026-07-25T15:56:23+02:00
            Stats  : +0/-16 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/cinnamon/c/b1980fa6363698b1578c48c6e13e842efa16d221?branch=rawhide

            Log:
            Remove ghost BuildRequires not used by 'meson.build'

Remove BuildRequires for packages that have no corresponding
'dependency()' call in the upstream 'meson.build':
https://github.com/linuxmint/cinnamon/blob/6.7.4-unstable/meson.build

- 'pkgconfig(libcanberra)'
- 'pkgconfig(libpulse)'
- 'pkgconfig(lcms2)'
- 'pkgconfig(colord)'
- 'pkgconfig(libwacom)' (was inside '%ifnarch s390 s390x')
- 'pkgconfig(xtst)'
- 'pkgconfig(gudev-1.0)'
- 'pkgconfig(json-glib-1.0)'

Also remove the '%global json_glib_version' macro and the
'Requires: json-glib' line that depended on it. json-glib is
pulled in transitively by other dependencies and was never
directly used by cinnamon's own build system.

Linux Mint's 'debian/control' Build-Depends lists some of these
(libgudev-1.0-dev, libjson-glib-dev, libpulse-dev) but they are
ghost dependencies there too -- none appear in any 'dependency()'
call in the upstream 'meson.build':
https://github.com/linuxmint/cinnamon/blob/6.7.4-unstable/debian/control#L22-L29

Co-Authored-By: Claude AI <noreply@anthropic.com>

---
diff --git a/cinnamon.spec b/cinnamon.spec
index 8eda3e0..fde9eda 100644
--- a/cinnamon.spec
+++ b/cinnamon.spec
@@ -5,7 +5,6 @@
 %global cinnamon_translations_version 6.7.0
 %global gobject_introspection_version 1.38.0
 %global muffin_version 6.7.1
-%global json_glib_version 0.13.2
 
 %global __python %{__python3}
 
@@ -45,28 +44,15 @@ BuildRequires:  pkgconfig(libsecret-1)
 BuildRequires:  pkgconfig(libxdo)
 BuildRequires:  pkgconfig(%{name}-desktop) >= %{cinnamon_desktop_version}
 BuildRequires:  pkgconfig(gobject-introspection-1.0) >= %{gobject_introspection_version}
-BuildRequires:  pkgconfig(json-glib-1.0) >= %{json_glib_version}
 BuildRequires:  pkgconfig(libnm)
 BuildRequires:  pkgconfig(pam)
 BuildRequires:  pkgconfig(polkit-agent-1)
-BuildRequires:  pkgconfig(gudev-1.0)
 BuildRequires:  pkgconfig(xapp)
 
 # for screencast recorder functionality
 BuildRequires:  pkgconfig(gstreamer-1.0)
-BuildRequires:  pkgconfig(libcanberra)
 
-# used in unused BigThemeImage
 BuildRequires:  pkgconfig(libmuffin-0) >= %{muffin_version}
-BuildRequires:  pkgconfig(libpulse)
-
-# media keys
-BuildRequires:  pkgconfig(lcms2)
-BuildRequires:  pkgconfig(colord)
-%ifnarch s390 s390x
-BuildRequires:  pkgconfig(libwacom)
-%endif
-BuildRequires:  pkgconfig(xtst)
 
 Obsoletes:      cinnamon-screensaver < %{version}-%{release}
 Provides:       cinnamon-screensaver = %{version}-%{release}
@@ -83,8 +69,6 @@ Requires:       gobject-introspection%{?_isa} >= %{gobject_introspection_version
 # needed for loading SVG's via gdk-pixbuf
 Requires:       librsvg2%{?_isa}
 
-# needed as it is now split from Clutter
-Requires:       json-glib%{?_isa} >= %{json_glib_version}
 Requires:       upower%{?_isa}
 Requires:       polkit%{?_isa} >= 0.100
 

                 reply	other threads:[~2026-07-26 14:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178507462257.1.17251397752671821840.rpms-cinnamon-b1980fa63636@fedoraproject.org \
    --to=mschorm@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox