[rpms/ncrack] rawhide: Fix build with openssl 4.0 rhbz#2504362

[Filipe Rosset <rosset.filipe@gmail.com>]

A new commit has been pushed.

Repo   : rpms/ncrack
Branch : rawhide
Commit : 0def15f27d6b8091bc6cc0db98be5bd1877c343f
Author : Filipe Rosset <rosset.filipe@gmail.com>
Date   : 2026-07-25T23:19:55-03:00
Stats  : +56/-3 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/ncrack/c/0def15f27d6b8091bc6cc0db98be5bd1877c343f?branch=rawhide

Log:
Fix build with openssl 4.0 rhbz#2504362

---
diff --git a/ncrack-0.7-fedora-openssl.patch b/ncrack-0.7-fedora-openssl.patch
new file mode 100644
index 0000000..8cc7967
--- /dev/null
+++ b/ncrack-0.7-fedora-openssl.patch
@@ -0,0 +1,48 @@
+Description: Fix FTBFS with OpenSSL 4.
+ The bundled opensshlib files cipher-3des1.c and cipher-bf1.c implement the
+ SSH protocol 1 "3des" and "blowfish" ciphers using the EVP_CIPHER_meth_*()
+ API, which was deprecated in OpenSSL 3.0 and removed entirely in OpenSSL 4.0.
+ Compiling them against OpenSSL 4 fails with implicit-declaration errors.
+ .
+ These ciphers are only referenced from cipher.c inside #ifdef WITH_SSH1
+ blocks, and Ncrack's build never enables SSH protocol 1 support (it does not
+ pass --with-ssh1 to the bundled opensshlib configure), so this code is never
+ actually used. Guard the affected code with WITH_SSH1 so it is compiled out,
+ matching how its only consumers in cipher.c are already guarded. This keeps
+ the package building with both OpenSSL 3 and OpenSSL 4.
+Author: Ujjwal Sarswat <ujjwal.sarswat@canonical.com>
+Last-Update: 2026-07-08
+--- a/opensshlib/cipher-3des1.c
++++ b/opensshlib/cipher-3des1.c
+@@ -26,6 +26,8 @@
+ 
+ #include "ssherr.h"
+ 
++#ifdef WITH_SSH1
++
+ /*
+  * This is used by SSH1:
+  *
+@@ -155,3 +157,5 @@
+ 	EVP_CIPHER_meth_set_flags(ssh1_3des, EVP_CIPH_CBC_MODE | EVP_CIPH_VARIABLE_LENGTH);
+ 	return ssh1_3des;
+ }
++
++#endif /* WITH_SSH1 */
+--- a/opensshlib/cipher-bf1.c
++++ b/opensshlib/cipher-bf1.c
+@@ -20,7 +20,7 @@
+ 
+ #include "includes.h"
+ 
+-#ifdef WITH_OPENSSL
++#if defined(WITH_OPENSSL) && defined(WITH_SSH1)
+ 
+ #include <sys/types.h>
+ 
+@@ -99,4 +99,4 @@
+ 	EVP_CIPHER_meth_set_do_cipher(ssh1_bf, bf_ssh1_do_cipher);
+ 	return (ssh1_bf);
+ }
+-#endif /* WITH_OPENSSL */
++#endif /* WITH_OPENSSL && WITH_SSH1 */

diff --git a/ncrack.spec b/ncrack.spec
index 0192de8..ddc3d1a 100644
--- a/ncrack.spec
+++ b/ncrack.spec
@@ -2,7 +2,7 @@
 
 Name:           ncrack
 Version:        0.7
-Release:        20%{?dist}
+Release:        21%{?dist}
 Summary:        A high-speed network auth cracking tool
 
 # Automatically converted from old format: GPLv2 with exceptions - review is highly recommended.
@@ -16,7 +16,9 @@ Patch1:         https://github.com/nmap/ncrack/commit/9232958b35a6f5118049f25281
 # SSH module is not iterating on the credential list properly
 Patch2:         https://github.com/nmap/ncrack/pull/99.patch
 # Fedora C99 Fixes
-Patch3:		ncrack-0.7-fedora-c99.patch
+Patch3:         ncrack-0.7-fedora-c99.patch
+# Fix build with openssl4 - https://github.com/nmap/ncrack/issues/146
+Patch4:         ncrack-0.7-fedora-openssl.patch
 
 BuildRequires:  autoconf
 BuildRequires:  automake
@@ -56,6 +58,9 @@ export CFLAGS="${RPM_OPT_FLAGS} -fcommon"
 %{_datadir}/%{name}/*
 
 %changelog
+* Sun Jul 26 2026 Filipe Rosset <rosset.filipe@gmail.com> - 0.7-21
+- Fix build with openssl 4.0
+
 * Thu Jul 16 2026 Fedora Release Engineering <releng@fedoraproject.org> - 0.7-20
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_45_Mass_Rebuild
 
@@ -161,7 +166,7 @@ export CFLAGS="${RPM_OPT_FLAGS} -fcommon"
 
 * Thu Feb 04 2016 Fedora Release Engineering <releng@fedoraproject.org> - 0.4-0.10.ALPHA
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild
-	
+
 * Wed Jun 17 2015 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.4-0.9.ALPHA
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild