public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Sam Day <me@samcday.com>
To: git-commits@fedoraproject.org
Subject: [rpms/phosh-mobile-settings] f44: Disable fatal-warnings in tests for now
Date: Sun, 26 Jul 2026 01:15:52 GMT	[thread overview]
Message-ID: <178502855271.1.11344618384970263.rpms-phosh-mobile-settings-2a9b6812b09f@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/phosh-mobile-settings
Branch : f44
Commit : 2a9b6812b09fd38d320fb37666edfadbaf6b0605
Author : Sam Day <me@samcday.com>
Date   : 2026-07-04T09:23:49+10:00
Stats  : +27/-0 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/phosh-mobile-settings/c/2a9b6812b09fd38d320fb37666edfadbaf6b0605?branch=f44

Log:
Disable fatal-warnings in tests for now

---
diff --git a/0002-tests-Do-not-make-warnings-fatal.patch b/0002-tests-Do-not-make-warnings-fatal.patch
new file mode 100644
index 0000000..6cfc3f4
--- /dev/null
+++ b/0002-tests-Do-not-make-warnings-fatal.patch
@@ -0,0 +1,24 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Sam Thursfield <sam@afuera.me.uk>
+Date: Sat, 4 Jul 2026 13:10:00 +1000
+Subject: [PATCH] tests: Do not make warnings fatal
+
+---
+ tests/meson.build | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/tests/meson.build b/tests/meson.build
+index d01eb9d..7a642ad 100644
+--- a/tests/meson.build
++++ b/tests/meson.build
+@@ -1,7 +1,7 @@
+ test_env_common = environment()
+ test_env_common.set('G_TEST_SRCDIR', meson.current_source_dir())
+ test_env_common.set('G_TEST_BUILDDIR', meson.current_build_dir())
+-test_env_common.set('G_DEBUG', 'gc-friendly,fatal-warnings')
++test_env_common.set('G_DEBUG', 'gc-friendly')
+ test_env_common.set('GSETTINGS_BACKEND', 'memory')
+ test_env_common.set('GSETTINGS_SCHEMA_DIR', '@0@/data'.format(meson.project_build_root()))
+ test_env_common.set('PYTHONDONTWRITEBYTECODE', 'yes')
+-- 
+2.50.1

diff --git a/phosh-mobile-settings.spec b/phosh-mobile-settings.spec
index 425fd81..de68c21 100644
--- a/phosh-mobile-settings.spec
+++ b/phosh-mobile-settings.spec
@@ -12,6 +12,9 @@ Source0:	https://gitlab.gnome.org/World/Phosh/phosh-mobile-settings/-/archive/v%
 Source1:	https://gitlab.gnome.org/guidog/libgnome-volume-control/-/archive/%{gvc_commit}/libgnome-volume-control-%{gvc_commit}.tar.gz
 # https://gitlab.gnome.org/World/Phosh/phosh-mobile-settings/-/merge_requests/355
 Patch0:	0001-polkit-Allow-to-specify-group.patch
+# Tests currently abort on this warning:
+# "Use GtkSettings:gtk-interface-color-scheme instead"
+Patch1:	0002-tests-Do-not-make-warnings-fatal.patch
 
 ExcludeArch:	%{ix86}
 # https://bugzilla.redhat.com/show_bug.cgi?id=2415478

                 reply	other threads:[~2026-07-26  1:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178502855271.1.11344618384970263.rpms-phosh-mobile-settings-2a9b6812b09f@fedoraproject.org \
    --to=me@samcday.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox