public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Michal Schorm <mschorm@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/cjs] rawhide: Add 'pkgconfig(girepository-2.0)' BuildRequires for GIRepository library
Date: Sat, 25 Jul 2026 23:18:52 GMT	[thread overview]
Message-ID: <178502153268.1.5104823854468236583.rpms-cjs-edc846da2190@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/cjs
            Branch : rawhide
            Commit : edc846da21903202a467b6015a8434d69e2e7312
            Author : Michal Schorm <mschorm@redhat.com>
            Date   : 2026-07-26T00:50:06+02:00
            Stats  : +3/-3 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/cjs/c/edc846da21903202a467b6015a8434d69e2e7312?branch=rawhide

            Log:
            Add 'pkgconfig(girepository-2.0)' BuildRequires for GIRepository library

Since GLib 2.80, the GObject Introspection ecosystem is split across
two packages:

- 'glib2-devel' provides 'pkgconfig(girepository-2.0)' — the
  GIRepository library API that cjs links against.
  'meson.build' line 145: dependency('girepository-2.0')
  https://github.com/linuxmint/cjs/blob/140.0/meson.build#L145

- 'gobject-introspection-devel' provides
  'pkgconfig(gobject-introspection-1.0)' — the build tools
  ('g-ir-scanner', 'g-ir-compiler') that cjs needs to generate
  the 'GjsPrivate-1.0' typelib via gnome.generate_gir().
  'meson.build' line 594: gnome.generate_gir(libgjs, ...)
  https://github.com/linuxmint/cjs/blob/140.0/meson.build#L594

'glib2-devel' does NOT pull in 'gobject-introspection-devel', so
both BuildRequires are needed independently:
- 'pkgconfig(girepository-2.0)' for the library (new, added here)
- 'pkgconfig(gobject-introspection-1.0)' for the tools (existing,
  kept — but drop the stale '>= 1.66.0' version constraint and the
  now-unused '%{gobject_introspection_version}' macro)

Drop the stale '>= 1.66.0' version constraint from the runtime
Requires on 'gobject-introspection' — the soname-based auto-requires
already ensures the right version at install time.

Linux Mint 'debian/control' line 15: 'libgirepository-2.0-dev (>= 2.86.0-7~)'
https://github.com/linuxmint/cjs/blob/140.0/debian/control#L15

Co-Authored-By: Claude AI <noreply@anthropic.com>

---
diff --git a/cjs.spec b/cjs.spec
index c8f32e1..1d47f33 100644
--- a/cjs.spec
+++ b/cjs.spec
@@ -1,5 +1,4 @@
 %global glib2_version 2.86.0
-%global gobject_introspection_version 1.66.0
 %global gtk3_version 3.20
 %global mozjs140_version 140.6.0
 
@@ -20,7 +19,8 @@ BuildRequires: gettext
 BuildRequires: meson
 BuildRequires: pkgconfig(cairo-gobject)
 BuildRequires: pkgconfig(gio-2.0) >= %{glib2_version}
-BuildRequires: pkgconfig(gobject-introspection-1.0) >= %{gobject_introspection_version}
+BuildRequires: pkgconfig(girepository-2.0) >= %{glib2_version}
+BuildRequires: pkgconfig(gobject-introspection-1.0)
 BuildRequires: pkgconfig(gtk+-3.0) >= %{gtk3_version}
 BuildRequires: pkgconfig(mozjs-140) >= %{mozjs140_version}
 BuildRequires: pkgconfig(readline)
@@ -36,7 +36,7 @@ BuildRequires: mutter
 BuildRequires: xwayland-run
 
 Requires: glib2%{?_isa} >= %{glib2_version}
-Requires: gobject-introspection%{?_isa} >= %{gobject_introspection_version}
+Requires: gobject-introspection%{?_isa}
 Requires: gtk3%{?_isa} >= %{gtk3_version}
 Requires: mozjs140%{?_isa} >= %{mozjs140_version}
 

                 reply	other threads:[~2026-07-25 23:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178502153268.1.5104823854468236583.rpms-cjs-edc846da2190@fedoraproject.org \
    --to=mschorm@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox