public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Michal Schorm <mschorm@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/cinnamon-screensaver] rawhide: Add missing BuildRequires: 'pkgconfig(xinerama)'
Date: Sat, 25 Jul 2026 17:49:13 GMT [thread overview]
Message-ID: <178500175308.1.17364131607722378279.rpms-cinnamon-screensaver-5240ddafb5df@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/cinnamon-screensaver
Branch : rawhide
Commit : 5240ddafb5dfa26664305070d87d2cf788535de6
Author : Michal Schorm <mschorm@redhat.com>
Date : 2026-07-25T15:56:48+02:00
Stats : +1/-0 in 1 file(s)
URL : https://src.fedoraproject.org/rpms/cinnamon-screensaver/c/5240ddafb5dfa26664305070d87d2cf788535de6?branch=rawhide
Log:
Add missing BuildRequires: 'pkgconfig(xinerama)'
'meson_options.txt' line 3: option('xinerama', type: 'boolean', value: true)
https://github.com/linuxmint/cinnamon-screensaver/blob/6.7.1-unstable/meson_options.txt#L3
'meson.build' line 84: dependency('xinerama')
https://github.com/linuxmint/cinnamon-screensaver/blob/6.7.1-unstable/meson.build#L84
The meson option 'xinerama' defaults to true. On Linux, 'meson.build'
calls dependency('xinerama') which requires the xinerama .pc file.
Without this BuildRequires, the build relies on 'libXinerama-devel'
being pulled in transitively.
'meson.build' lines 74-88: full xinerama handling block
https://github.com/linuxmint/cinnamon-screensaver/blob/6.7.1-unstable/meson.build#L74-L88
LM's 'debian/control' does not list 'libxinerama-dev' explicitly
either (likely pulled by 'libgtk-3-dev'), but for Fedora spec
correctness the dependency should be declared:
https://github.com/linuxmint/cinnamon-screensaver/blob/6.7.1-unstable/debian/control#L5-L19
Co-Authored-By: Claude AI <noreply@anthropic.com>
---
diff --git a/cinnamon-screensaver.spec b/cinnamon-screensaver.spec
index 41f2879..17f5e6a 100644
--- a/cinnamon-screensaver.spec
+++ b/cinnamon-screensaver.spec
@@ -27,6 +27,7 @@ BuildRequires: pkgconfig(xrandr)
BuildRequires: pkgconfig(libxdo)
BuildRequires: pkgconfig(dbus-1)
BuildRequires: pkgconfig(pam)
+BuildRequires: pkgconfig(xinerama)
BuildRequires: python3-packaging
Recommends: caribou%{?_isa}
reply other threads:[~2026-07-25 17:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178500175308.1.17364131607722378279.rpms-cinnamon-screensaver-5240ddafb5df@fedoraproject.org \
--to=mschorm@redhat.com \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox