public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Benjamin A. Beasley <code@musicinmybrain.net>
To: git-commits@fedoraproject.org
Subject: [rpms/gulrak-filesystem] epel10: Add a bcond to allow switching back to the bundled Catch2 2.x
Date: Fri, 24 Jul 2026 05:48:45 GMT	[thread overview]
Message-ID: <178487212573.1.1838218093609218463.rpms-gulrak-filesystem-df598a226301@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/gulrak-filesystem
Branch : epel10
Commit : df598a226301c35af8de4844c563023db735e006
Author : Benjamin A. Beasley <code@musicinmybrain.net>
Date   : 2026-01-09T13:08:34+00:00
Stats  : +14/-0 in 1 file(s)
URL    : https://src.fedoraproject.org/rpms/gulrak-filesystem/c/df598a226301c35af8de4844c563023db735e006?branch=epel10

Log:
Add a bcond to allow switching back to the bundled Catch2 2.x

---
diff --git a/gulrak-filesystem.spec b/gulrak-filesystem.spec
index 66c6231..bfc3312 100644
--- a/gulrak-filesystem.spec
+++ b/gulrak-filesystem.spec
@@ -1,3 +1,13 @@
+# Use the system Catch2? We need 2.x and cannot straightforwarly port to 3.x
+# (and upstream will not migrate to 3.x because they need to test C++11
+# support, https://github.com/gulrak/filesystem/issues/165). If a Catch2 2.x
+# compat package is no longer available, we can use the bundled single-header
+# copy. This would be:
+#    Provides:       bundled(catch2) = 2.13.7
+# except that it is only used to build test executables, and nothing from the
+# bundled Catch2 library is included in any of the binary RPMs.
+%bcond system_catch2 0
+
 Name:           gulrak-filesystem
 Version:        1.5.14
 Release:        %autorelease
@@ -12,9 +22,11 @@ BuildRequires:  gcc-c++
 BuildRequires:  cmake
 BuildRequires:  make
 
+%if %{with system_catch2}
 # Consider migrating to Catch2 v3
 # https://github.com/gulrak/filesystem/issues/165
 BuildRequires:  pkgconfig(catch2) < 3
+%endif
 
 # No compiled binaries are installed, so this would be empty.
 %global debug_package %{nil}
@@ -52,10 +64,12 @@ developing applications that use %{name}.
 %prep
 %autosetup -n filesystem-%{version}
 
+%if %{with system_catch2}
 # Remove bundled Catch library and use the system version
 rm -vf test/catch.hpp
 sed -r -i 's|(include[[:blank:]]+")(catch.hpp")|\1catch2/\2|' test/*.cpp
 sed -r -i 's|[[:blank:]]+catch\.hpp||' test/CMakeLists.txt
+%endif
 
 
 %conf

                 reply	other threads:[~2026-07-24  5:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178487212573.1.1838218093609218463.rpms-gulrak-filesystem-df598a226301@fedoraproject.org \
    --to=code@musicinmybrain.net \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox