public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Benjamin A. Beasley <code@musicinmybrain.net>
To: git-commits@fedoraproject.org
Subject: [rpms/python-trimesh] f44: Do not run BoundsTest::test_obb_mesh_large at all
Date: Thu, 23 Jul 2026 22:39:30 GMT	[thread overview]
Message-ID: <178484637050.1.5307460367660417047.rpms-python-trimesh-2122b0200898@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/python-trimesh
            Branch : f44
            Commit : 2122b020089819d20b65776bfd9e42c66803b179
            Author : Benjamin A. Beasley <code@musicinmybrain.net>
            Date   : 2026-07-23T23:20:33+01:00
            Stats  : +5/-4 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/python-trimesh/c/2122b020089819d20b65776bfd9e42c66803b179?branch=f44

            Log:
            Do not run BoundsTest::test_obb_mesh_large at all

It is purely a performance check, under assumptions that may not apply
downstream.

---
diff --git a/python-trimesh.spec b/python-trimesh.spec
index 2e9c44d..a59d9cb 100644
--- a/python-trimesh.spec
+++ b/python-trimesh.spec
@@ -303,15 +303,16 @@ deselect="${deselect-} --deselect=tests/test_color.py::test_data_model"
 k="${k-}${k+ and }not test_contains_cavity"
 %endif
 
-# This test fails if it doesn’t finish within 30 seconds, and executing it in
-# parallel with other tests tends to slow it down too much. We exclude it here,
-# then run it serially on its own.
+# This test fails if it doesn’t finish within 60 seconds, and executing it in
+# parallel with other tests tends to slow it down too much. Furthermore, the
+# only assertion in the test is the one on execution time, and builder hardware
+# may be quite different (and potentially slower) than what upstream is using
+# for development and CI, so it provides no real value downstream.
 # tests/test_bounds.py::BoundsTest::test_obb_mesh_large
 k="${k-}${k+ and }not (BoundsTest and test_obb_mesh_large)"
 
 export PYTHONPATH="${PWD}/_stub:%{buildroot}%{python3_sitelib}"
 %pytest -v -k "${k-}" -n auto ${deselect-}
-%pytest -v -k '(BoundsTest and test_obb_mesh_large)'
 
 
 %files -n python3-trimesh -f %{pyproject_files}

                 reply	other threads:[~2026-07-23 22:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178484637050.1.5307460367660417047.rpms-python-trimesh-2122b0200898@fedoraproject.org \
    --to=code@musicinmybrain.net \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox