public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Peter Lemenkov <lemenkov@gmail.com>
To: git-commits@fedoraproject.org
Subject: [rpms/rabbitmq-server] rawhide: Don't scare people with harmless messages
Date: Wed, 22 Jul 2026 19:27:25 GMT	[thread overview]
Message-ID: <178474844598.1.1144060757927939357.rpms-rabbitmq-server-5f6b0ed5089e@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/rabbitmq-server
            Branch : rawhide
            Commit : 5f6b0ed5089ebb9507c4026bf41d84615fd2d4d4
            Author : Peter Lemenkov <lemenkov@gmail.com>
            Date   : 2026-07-22T21:08:52+02:00
            Stats  : +36/-0 in 2 file(s)
            URL    : https://src.fedoraproject.org/rpms/rabbitmq-server/c/5f6b0ed5089ebb9507c4026bf41d84615fd2d4d4?branch=rawhide

            Log:
            Don't scare people with harmless messages

Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>

---
diff --git a/rabbitmq-server-0005-rabbit_plugins-demote-duplicate-plugin-warnings-from.patch b/rabbitmq-server-0005-rabbit_plugins-demote-duplicate-plugin-warnings-from.patch
new file mode 100644
index 0000000..30fa113
--- /dev/null
+++ b/rabbitmq-server-0005-rabbit_plugins-demote-duplicate-plugin-warnings-from.patch
@@ -0,0 +1,35 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Peter Lemenkov <lemenkov@gmail.com>
+Date: Wed, 22 Jul 2026 21:06:22 +0200
+Subject: [PATCH] rabbit_plugins: demote duplicate plugin warnings from stderr
+ to log
+
+Duplicate plugin entries are an expected and harmless condition in
+packaged deployments where both a versioned plugin directory and a
+convenience symlink/path are scanned. Reporting them via
+io:format(standard_error) alarmed users and operators unnecessarily.
+
+Split duplicate_plugin problems from genuine loading errors: duplicates
+are now reported via ?LOG_WARNING while real loading errors retain the
+stderr treatment.
+
+Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
+Assisted-by: Claude (Anthropic) <https://claude.ai>
+
+diff --git a/deps/rabbit/src/rabbit_plugins.erl b/deps/rabbit/src/rabbit_plugins.erl
+index 8b2f116ee2..7f3a774c9c 100644
+--- a/deps/rabbit/src/rabbit_plugins.erl
++++ b/deps/rabbit/src/rabbit_plugins.erl
+@@ -190,7 +190,11 @@ list(PluginsPath, IncludeRequiredDeps) ->
+     {UniquePlugins, DuplicateProblems} = remove_duplicate_plugins(AllPlugins),
+     Plugins1 = maybe_keep_required_deps(IncludeRequiredDeps, UniquePlugins),
+     Plugins2 = remove_plugins(Plugins1),
+-    maybe_report_plugin_loading_problems(LoadingProblems ++ DuplicateProblems),
++    case DuplicateProblems of
++        [] -> ok;
++        _  -> ?LOG_WARNING("Duplicate plugins found (harmless): ~tp", [DuplicateProblems])
++    end,
++    maybe_report_plugin_loading_problems(LoadingProblems),
+     ensure_dependencies(Plugins2).
+ 
+ %% @doc Read the list of enabled plugins from the supplied term file.

diff --git a/rabbitmq-server.spec b/rabbitmq-server.spec
index ec38ff0..2ae1d80 100644
--- a/rabbitmq-server.spec
+++ b/rabbitmq-server.spec
@@ -23,6 +23,7 @@ Patch: rabbitmq-server-0001-Use-default-EPMD-socket.patch
 Patch: rabbitmq-server-0002-Use-proto_dist-from-command-line.patch
 Patch: rabbitmq-server-0003-force-python3.patch
 Patch: rabbitmq-server-0004-Greatly-simplified-wrapper-script-which-works-proper.patch
+Patch: rabbitmq-server-0005-rabbit_plugins-demote-duplicate-plugin-warnings-from.patch
 
 URL: https://www.rabbitmq.com/
 BuildRequires: elixir

                 reply	other threads:[~2026-07-22 19:27 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178474844598.1.1144060757927939357.rpms-rabbitmq-server-5f6b0ed5089e@fedoraproject.org \
    --to=lemenkov@gmail.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox