public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Adam Williamson <awilliam@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/openqa] rawhide: Backport PR #7634 to fix build with Mojo 9.48+
Date: Tue, 21 Jul 2026 22:34:57 GMT	[thread overview]
Message-ID: <178467329778.1.5014822407378573716.rpms-openqa-683111420302@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/openqa
Branch : rawhide
Commit : 6831114203020374ce974a4077cbba242ee6596f
Author : Adam Williamson <awilliam@redhat.com>
Date   : 2026-07-21T15:34:30-07:00
Stats  : +33/-0 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/openqa/c/6831114203020374ce974a4077cbba242ee6596f?branch=rawhide

Log:
Backport PR #7634 to fix build with Mojo 9.48+

---
diff --git a/0001-fix-test-Drop-test-for-token-equality.patch b/0001-fix-test-Drop-test-for-token-equality.patch
new file mode 100644
index 0000000..47dce1a
--- /dev/null
+++ b/0001-fix-test-Drop-test-for-token-equality.patch
@@ -0,0 +1,30 @@
+From 8d6558680caffaafa4828a08c48a0a4cac4839e1 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Tina=20M=C3=BCller?= <tina.mueller@suse.com>
+Date: Fri, 17 Jul 2026 14:42:07 +0200
+Subject: [PATCH] fix(test): Drop test for token equality
+
+Due to security, CSRF tokens in Mojolicious 9.48 are now different with every
+request and even every form element, so it does not make sense to compare
+them anymore.
+
+Issue: https://progress.opensuse.org/issues/204255
+---
+ t/ui/02-csrf.t | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/t/ui/02-csrf.t b/t/ui/02-csrf.t
+index 54451a217..d5ffd7493 100644
+--- a/t/ui/02-csrf.t
++++ b/t/ui/02-csrf.t
+@@ -31,8 +31,6 @@ $t->get_ok('/api_keys');
+ ok $token =~ /[0-9a-z]{40}/, 'csrf token in meta tag';
+ ok $t->tx->res->dom->at('meta[name=csrf-param]')->attr('content') eq 'csrf_token', 'csrf param in meta tag';
+ 
+-is $token, $t->tx->res->dom->at('form input[name=csrf_token]')->{value}, 'token is the same in form';
+-
+ # test cancel with and without CSRF token
+ $t->post_ok('/api/v1/jobs/99928/cancel' => form => {csrf_token => 'foobar'})->status_is(403);
+ $t->post_ok('/api/v1/jobs/99928/cancel' => {'X-CSRF-Token' => $token} => form => {})->status_is(200);
+-- 
+2.54.0
+

diff --git a/openqa.spec b/openqa.spec
index 6b42788..8962b0f 100644
--- a/openqa.spec
+++ b/openqa.spec
@@ -147,6 +147,9 @@ Patch:          0001-t-Skip-earlier-in-tests_dependencies.t.patch
 # https://github.com/os-autoinst/openQA/pull/7509
 # Support invent.kde.org as a bug tracker (for bug links)
 Patch:          0001-fix-Support-invent.kde.org-and-work_items-in-bug-URL.patch
+# https://github.com/os-autoinst/openQA/pull/7634
+# Drop token equality test that is invalid with Mojolicious 9.48+
+Patch:          0001-fix-test-Drop-test-for-token-equality.patch
 
 BuildRequires: make
 BuildRequires:  %{python_scripts_requires}

                 reply	other threads:[~2026-07-21 22:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178467329778.1.5014822407378573716.rpms-openqa-683111420302@fedoraproject.org \
    --to=awilliam@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox