public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Simone Caronni <negativo17@gmail.com>
To: git-commits@fedoraproject.org
Subject: [rpms/transmission] epel10: Add upstream patch to allow building against miniupnpc 2.2.8
Date: Mon, 20 Jul 2026 20:37:55 GMT	[thread overview]
Message-ID: <178457987537.1.15018892503322774634.rpms-transmission-8d1d11c85321@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/transmission
Branch : epel10
Commit : 8d1d11c8532155e0851fadca208c32e66c6800ce
Author : Simone Caronni <negativo17@gmail.com>
Date   : 2024-10-08T19:03:32+02:00
Stats  : +21/-0 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/transmission/c/8d1d11c8532155e0851fadca208c32e66c6800ce?branch=epel10

Log:
Add upstream patch to allow building against miniupnpc 2.2.8

---
diff --git a/transmission-miniupnp228.patch b/transmission-miniupnp228.patch
new file mode 100644
index 0000000..0069c2e
--- /dev/null
+++ b/transmission-miniupnp228.patch
@@ -0,0 +1,20 @@
+diff --git a/libtransmission/port-forwarding-upnp.cc b/libtransmission/port-forwarding-upnp.cc
+index 6d7bbc7f7c2..a4146e0df13 100644
+--- a/libtransmission/port-forwarding-upnp.cc
++++ b/libtransmission/port-forwarding-upnp.cc
+@@ -261,8 +261,13 @@ tr_port_forwarding_state tr_upnpPulse(
+ 
+         FreeUPNPUrls(&handle->urls);
+         auto lanaddr = std::array<char, TR_ADDRSTRLEN>{};
+-        if (UPNP_GetValidIGD(devlist, &handle->urls, &handle->data, std::data(lanaddr), std::size(lanaddr) - 1) ==
+-            UPNP_IGD_VALID_CONNECTED)
++        if (
++#if (MINIUPNPC_API_VERSION >= 18)
++            UPNP_GetValidIGD(devlist, &handle->urls, &handle->data, std::data(lanaddr), std::size(lanaddr) - 1, nullptr, 0)
++#else
++            UPNP_GetValidIGD(devlist, &handle->urls, &handle->data, std::data(lanaddr), std::size(lanaddr) - 1)
++#endif
++            == UPNP_IGD_VALID_CONNECTED)
+         {
+             tr_logAddInfo(fmt::format(_("Found Internet Gateway Device '{url}'"), fmt::arg("url", handle->urls.controlURL)));
+             tr_logAddInfo(fmt::format(_("Local Address is '{address}'"), fmt::arg("address", lanaddr.data())));

diff --git a/transmission.spec b/transmission.spec
index dab0e56..8c51490 100644
--- a/transmission.spec
+++ b/transmission.spec
@@ -12,6 +12,7 @@ Source1:        https://raw.githubusercontent.com/gnome-design-team/gnome-icons/
 # Fix the DBus name to match the app name for flatpak builds
 # https://github.com/transmission/transmission/pull/847
 Patch0:         0001-gtk-use-com.transmissionbt.Transmission.-D-Bus-names.patch
+Patch1:         %{name}-miniupnp228.patch
 
 
 BuildRequires:  make

                 reply	other threads:[~2026-07-20 20:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178457987537.1.15018892503322774634.rpms-transmission-8d1d11c85321@fedoraproject.org \
    --to=negativo17@gmail.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox