public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Dominik 'Rathann' Mierzejewski <dominik@greysector.net>
To: git-commits@fedoraproject.org
Subject: [rpms/minidlna] epel9-next: drop broken patch
Date: Mon, 20 Jul 2026 18:20:41 GMT	[thread overview]
Message-ID: <178457164188.1.4433902098301950869.rpms-minidlna-73e965a71677@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/minidlna
Branch : epel9-next
Commit : 73e965a71677dd5bb035bf91b294162969050fa5
Author : Dominik 'Rathann' Mierzejewski <dominik@greysector.net>
Date   : 2023-07-08T19:11:55+02:00
Stats  : +4/-18 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/minidlna/c/73e965a71677dd5bb035bf91b294162969050fa5?branch=epel9-next

Log:
drop broken patch

---
diff --git a/minidlna-1.3.3-setgroups.patch b/minidlna-1.3.3-setgroups.patch
deleted file mode 100644
index 1445c1e..0000000
--- a/minidlna-1.3.3-setgroups.patch
+++ /dev/null
@@ -1,14 +0,0 @@
-diff -up minidlna-1.3.3/minidlna.c.orig minidlna-1.3.3/minidlna.c
---- minidlna-1.3.3/minidlna.c.orig	2023-05-31 10:25:59.000000000 +0200
-+++ minidlna-1.3.3/minidlna.c	2023-07-05 11:29:50.581828376 +0200
-@@ -1069,6 +1069,10 @@ init(int argc, char **argv)
- 		DPRINTF(E_FATAL, L_GENERAL, "Failed to switch to gid '%d'. [%s] EXITING.\n",
- 			gid, strerror(errno));
- 
-+	if (setgroups(0, NULL) == -1)
-+		DPRINTF(E_FATAL, L_GENERAL, "Failed to drop supplementary groups. [%s] EXITING.\n",
-+			strerror(errno));
-+
- 	if (uid > 0 && setuid(uid) == -1)
- 		DPRINTF(E_FATAL, L_GENERAL, "Failed to switch to uid '%d'. [%s] EXITING.\n",
- 			uid, strerror(errno));

diff --git a/minidlna.spec b/minidlna.spec
index 5fc7b36..df055d9 100644
--- a/minidlna.spec
+++ b/minidlna.spec
@@ -1,6 +1,6 @@
 Name:           minidlna
 Version:        1.3.3
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        Lightweight DLNA/UPnP-AV server targeted at embedded systems
 
 # see minidlna-licensing-breakdown.txt for complete breakdown
@@ -17,9 +17,6 @@ Source5:        %{name}.sysusers
 # Fix core dump
 # https://sourceforge.net/p/minidlna/bugs/333/
 Patch0:         %{name}-1.3.0-select_use_after_free.patch
-# drop supplementary groups before calling setuid()
-# https://sourceforge.net/p/minidlna/bugs/356/
-Patch1:         %{name}-1.3.3-setgroups.patch
 
 BuildRequires:  avahi-devel
 BuildRequires:  flac-devel
@@ -141,6 +138,9 @@ install -d -m 755 %{buildroot}%{_localstatedir}/log/%{name}/
 
 
 %changelog
+* Sat Jul 08 2023 Dominik Mierzejewski <dominik@greysector.net> - 1.3.3-3
+- drop broken patch
+
 * Wed Jul 05 2023 Dominik Mierzejewski <dominik@greysector.net> - 1.3.3-2
 - fix missing-call-to-setgroups-before-setuid rpmlint error
 - add weak dependency on logrotate

                 reply	other threads:[~2026-07-20 18:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178457164188.1.4433902098301950869.rpms-minidlna-73e965a71677@fedoraproject.org \
    --to=dominik@greysector.net \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox