public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Yaakov Selkowitz <yselkowi@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/vlc] epel9-next: Fix appstream data
Date: Mon, 20 Jul 2026 18:05:51 GMT [thread overview]
Message-ID: <178457075137.1.8850381696712870489.rpms-vlc-9a3013c3494c@fedoraproject.org> (raw)
A new commit has been pushed.
Repo : rpms/vlc
Branch : epel9-next
Commit : 9a3013c3494c8e441df4eccb471988a2738961b9
Author : Yaakov Selkowitz <yselkowi@redhat.com>
Date : 2024-01-16T13:32:06-05:00
Stats : +28/-2 in 2 file(s)
URL : https://src.fedoraproject.org/rpms/vlc/c/9a3013c3494c8e441df4eccb471988a2738961b9?branch=epel9-next
Log:
Fix appstream data
While the upstream appdata passes appstream-util validate-relax
(mandated by packaging guidelines), appstreamcli validate shows issues.
Since the latter's library is used in Software and Discover nowadays,
this may be why neither our package nor the Flathub flatpak are listed.
Resolves: rhbz#2258611
---
diff --git a/appdata.patch b/appdata.patch
new file mode 100644
index 0000000..2002a13
--- /dev/null
+++ b/appdata.patch
@@ -0,0 +1,19 @@
+diff --git a/share/vlc.appdata.xml.in.in b/share/vlc.appdata.xml.in.in
+index cc9c39a..3c55620 100644
+--- a/share/vlc.appdata.xml.in.in
++++ b/share/vlc.appdata.xml.in.in
+@@ -18,7 +18,7 @@
+ <url type="bugtracker">https://trac.videolan.org/vlc/</url>
+ <url type="donation">https://www.videolan.org/contribute.html</url>
+ <releases>
+- <release version="@VERSION@" />
++ <release version="@VERSION@" date="@DATE@" />
+ </releases>
+ <provides>
+ <library>libvlc.so.5</library>
+@@ -38,4 +38,5 @@
+ <image>http://images.videolan.org/vlc/screenshots/2.0.0/vlc-2.0-gnome3-debian.jpg</image>
+ </screenshot>
+ </screenshots>
++ <content_rating type="oars-1.1" />
+ </component>
diff --git a/vlc.spec b/vlc.spec
index 38ce111..0701355 100644
--- a/vlc.spec
+++ b/vlc.spec
@@ -40,7 +40,9 @@ Patch: fdk-aac2.patch
# separate avcodec-vaapi conditional from other vaapi modules
Patch: vaapi-without-ffmepg4.patch
# port from intel-mediasdk to oneVPL
-Patch: oneVPL.patch
+Patch: oneVPL.patch
+# fix appstreamcli validate to show in Software (rhbz#2258611)
+Patch: appdata.patch
%{load:%{S:1}}
%global __provides_exclude_from ^%{vlc_plugindir}/.*$
@@ -474,7 +476,12 @@ rm -f aclocal.m4 m4/lib*.m4 m4/lt*.m4
sed -i -e 's|\("qt-icon-change",\) true|\1 false|' modules/gui/qt/qt.cpp
# sync appstream app-id with Flathub
-sed -i -e 's|org\.videolan\.vlc|org.videolan.VLC|' share/vlc.appdata.xml.in.in
+# fill in release date from appstream.patch
+# https: https://code.videolan.org/videolan/vlc/-/merge_requests/1555 (4.0)
+sed -e 's|org\.videolan\.vlc|org.videolan.VLC|' \
+ -e 's|@DATE@|%(date +%F -r %{S:0})|' \
+ -e 's|http:|https:|g' \
+ -i share/vlc.appdata.xml.in.in
%if 0%{?flatpak}
# icons are renamed in order to be exported
reply other threads:[~2026-07-20 18:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178457075137.1.8850381696712870489.rpms-vlc-9a3013c3494c@fedoraproject.org \
--to=yselkowi@redhat.com \
--cc=git-commits@fedoraproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox