public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Benjamin A. Beasley <code@musicinmybrain.net>
To: git-commits@fedoraproject.org
Subject: [rpms/highfive] rawhide: Explicitly enable Boost/OpenCV/xtensor tests
Date: Sat, 18 Jul 2026 06:34:22 GMT	[thread overview]
Message-ID: <178435646237.1.1500064711710484900.rpms-highfive-34fc798ca910@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/highfive
            Branch : rawhide
            Commit : 34fc798ca91026c0981f8d24298f6664ad1241d6
            Author : Benjamin A. Beasley <code@musicinmybrain.net>
            Date   : 2026-07-18T07:33:36+01:00
            Stats  : +23/-7 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/highfive/c/34fc798ca91026c0981f8d24298f6664ad1241d6?branch=rawhide

            Log:
            Explicitly enable Boost/OpenCV/xtensor tests

- With this, we no longer need to manually skip them on riscv64

---
diff --git a/highfive.spec b/highfive.spec
index 520892e..05427b2 100644
--- a/highfive.spec
+++ b/highfive.spec
@@ -36,6 +36,16 @@ Known flaws:
 - The support of fixed length strings isn’t ideal.}
 
 %bcond tests 1
+# Currently, tests for half-float support would fail to compile with:
+#
+# […]/highfive/half_float.hpp:9:8: error: ‘AtomicType’ does not name a type
+#     9 | inline AtomicType<float16_t>::AtomicType() {
+#       |        ^~~~~~~~~~
+#
+# …which makes sense since AtomicType is defined in another highfive header,
+# and this header only includes <half.hpp>. While we could offer a patch, this
+# suggests that the feature is not well-tested upstream anyway.
+%bcond half 0
 
 # Header only, so no debuginfo is generated
 %global debug_package %{nil}
@@ -69,6 +79,9 @@ BuildRequires:  boost-devel
 BuildRequires:  (cmake(eigen3) with eigen3-static)
 BuildRequires:  (cmake(xtensor) with xtensor-static)
 BuildRequires:  cmake(opencv)
+%if %{with half}
+BuildRequires:  half-devel half-static
+%endif
 
 %description %_description
 
@@ -86,6 +99,9 @@ Requires:       boost-devel
 Requires:       (cmake(eigen3) with eigen3-static)
 Requires:       (cmake(xtensor) with xtensor-static)
 Requires:       cmake(opencv)
+%if %{with half}
+Requires:       half-devel
+%endif
 
 %description    devel
 The highfive-devel package contains libraries and header files for
@@ -102,10 +118,17 @@ developing applications that use HighFive.
 # we are more likely to notice any real problems.
 CXXFLAGS="${CXXFLAGS} -Wno-deprecated-declarations"
 %endif
+%if %{with tests} && %{with half}
+%global half_tests 1
+%endif
 %cmake \
     -DHIGHFIVE_CMAKE_INSTALL_DIR=%{_lib}/cmake/HighFive \
     -DHIGHFIVE_EXAMPLES:BOOL=TRUE \
     -DHIGHFIVE_UNIT_TESTS:BOOL=%{?with_tests:TRUE}%{?!with_tests:FALSE} \
+    -DHIGHFIVE_TEST_BOOST:BOOL=%{?with_tests:TRUE}%{?!with_tests:FALSE} \
+    -DHIGHFIVE_TEST_OPENCV:BOOL=%{?with_tests:TRUE}%{?!with_tests:FALSE} \
+    -DHIGHFIVE_TEST_XTENSOR:BOOL=%{?with_tests:TRUE}%{?!with_tests:FALSE} \
+    -DHIGHFIVE_TEST_HALF_FLOAT:BOOL=%{?half_tests:TRUE}%{?!half_tests:FALSE} \
     -DHIGHFIVE_BUILD_DOCS:BOOL=FALSE \
     -GNinja
 %cmake_build
@@ -117,15 +140,8 @@ CXXFLAGS="${CXXFLAGS} -Wno-deprecated-declarations"
 
 %check
 %if %{with tests}
-
-# on RISC-V we do not get (0-byte long) files needed for those tests to pass
-# they pass if we fake files
-%ifarch riscv64
-%ctest -VV -E "^(test_boost_NOT_BUILT|test_opencv_NOT_BUILT|test_xtensor_NOT_BUILT)"
-%else
 %ctest -VV
 %endif
-%endif
 
 
 %files devel

                 reply	other threads:[~2026-07-18  6:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178435646237.1.1500064711710484900.rpms-highfive-34fc798ca910@fedoraproject.org \
    --to=code@musicinmybrain.net \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox