public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Steve Dickson <steved@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/nfs-utils] f43: Pass ignore_hosts to export_create() in export_read()
Date: Wed, 15 Jul 2026 11:08:51 GMT	[thread overview]
Message-ID: <178411373187.1.1743554894724788689.rpms-nfs-utils-77d75e93a448@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/nfs-utils
            Branch : f43
            Commit : 77d75e93a448c0369acf952c57b9232eae42878e
            Author : Steve Dickson <steved@redhat.com>
            Date   : 2026-07-15T07:08:01-04:00
            Stats  : +40/-0 in 2 file(s)
            URL    : https://src.fedoraproject.org/rpms/nfs-utils/c/77d75e93a448c0369acf952c57b9232eae42878e?branch=f43

            Log:
            Pass ignore_hosts to export_create() in export_read()

Signed-off-by: Steve Dickson <steved@redhat.com>

---
diff --git a/nfs-utils-2.8.7-export-ignore-hosts.patch b/nfs-utils-2.8.7-export-ignore-hosts.patch
new file mode 100644
index 0000000..6b77ea2
--- /dev/null
+++ b/nfs-utils-2.8.7-export-ignore-hosts.patch
@@ -0,0 +1,38 @@
+Pass ignore_hosts to export_create() in export_read()
+
+Commit 8f3d12ce ("nfs-server-generator: avoid using external services.")
+added the 'ignore_hosts' flag to export_read() so nfs-server-generator
+can bypass DNS queries when calling it.  If the export doesn't
+already exist, export_read() calls export_create() with the 'canonical'
+argument hard-coded to 0, triggering a DNS query in client_lookup().
+An unresponsive DNS server can cause delays in nfs-server-generator and
+can even lead to 'systemctl daemon-reload' timing out, leading to
+further administrative issues.
+
+nfs-server-generator only cares about *what* is exported, so it can
+create the order-with-mounts.conf config drop-in.  It doesn't need to
+know *who* those filesystems are exported to, so it has no need to
+perform DNS queries.
+
+Pass the 'ignore_hosts' flag from export_read() to export_create() to
+avoid the unnecessary DNS queries.
+
+Fixes: 8f3d12ce ("nfs-server-generator: avoid using external services.")
+Signed-off-by: Scott Mayhew <smayhew@redhat.com>
+---
+ support/export/export.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/support/export/export.c b/support/export/export.c
+index 2c8c3335..3caee043 100644
+--- a/support/export/export.c
++++ b/support/export/export.c
+@@ -122,7 +122,7 @@ export_read(char *fname, int ignore_hosts)
+ 	while ((eep = getexportent(0)) != NULL) {
+ 		exp = export_lookup(eep->e_hostname, eep->e_path, ignore_hosts);
+ 		if (!exp) {
+-			if (export_create(eep, 0))
++			if (export_create(eep, ignore_hosts))
+ 				/* possible complaints already logged */
+ 				volumes++;
+ 		}

diff --git a/nfs-utils.spec b/nfs-utils.spec
index d8046a3..f580c13 100644
--- a/nfs-utils.spec
+++ b/nfs-utils.spec
@@ -20,6 +20,7 @@ Patch003: nfs-utils-2.8.7-libnfsidmap-empty-realms.patch
 Patch004: nfs-utils-2.8.7-getport-warning.patch
 Patch005: nfs-utils-2.8.7-nfsd-thread-count-zero.patch
 Patch006: nfs-utils-2.8.7-gssd-pthread.patch
+Patch007: nfs-utils-2.8.7-export-ignore-hosts.patch
 
 Patch100: nfs-utils-1.2.1-statdpath-man.patch
 Patch102: nfs-utils-1.2.5-idmap-errmsg.patch
@@ -456,6 +457,7 @@ rm -rf /etc/systemd/system/rpc-*.requires
 %changelog
 * Wed Jul 15 2026 Steve Dickson <steved@redhat.com> 2.8.7-5
 - rpc.gssd: Decrement client referece count on error paths
+- Pass ignore_hosts to export_create() in export_read()
 
 * Tue Jun 16 2026 Steve Dickson <steved@redhat.com> 2.8.7-4
 - nfsd: don't assume service is running when setting thread count to 0

                 reply	other threads:[~2026-07-15 11:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178411373187.1.1743554894724788689.rpms-nfs-utils-77d75e93a448@fedoraproject.org \
    --to=steved@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox