[rpms/bind] rawhide: Ghost files do not need explicit touch anymore -

public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed

To: git-commits@fedoraproject.org
Subject: [rpms/bind] rawhide: Ghost files do not need explicit touch anymore
Date: Wed, 15 Jul 2026 10:01:33 GMT	[thread overview]
Message-ID: <178410969380.1.15185891740905176302.rpms-bind-0049ee45a47d@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/bind
            Branch : rawhide
            Commit : 0049ee45a47d990c4678ba8af1c00e8723192b01
            Author : Petr Menšík <pemensik@redhat.com>
            Date   : 2026-07-08T20:32:23+02:00
            Stats  : +52/-79 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/bind/c/0049ee45a47d990c4678ba8af1c00e8723192b01?branch=rawhide

            Log:
            Ghost files do not need explicit touch anymore

Touches for ghost files are not necessary for a long time. Drop extra
touches. Use %attr instead to generate good permissions on such files.

Found at:
https://github.com/rpm-software-management/rpm/discussions/3380

---
diff --git a/bind.spec b/bind.spec
index ef4be45..f8d0be2 100644
--- a/bind.spec
+++ b/bind.spec
@@ -672,9 +672,6 @@ done
 cp -p doc/arm/_build/latex/Bv9ARM.pdf ${RPM_BUILD_ROOT}%{_pkgdocdir}
 %endif
 
-# Ghost config files:
-touch ${RPM_BUILD_ROOT}%{_localstatedir}/log/named.log
-
 # configuration files:
 install -m 640 %{SOURCE16} ${RPM_BUILD_ROOT}%{_sysconfdir}/named.conf
 touch ${RPM_BUILD_ROOT}%{_sysconfdir}/rndc.{key,conf}
@@ -737,30 +734,6 @@ mkdir -p ${RPM_BUILD_ROOT}%{_includedir}/bind9
 %global main_lib filter-{a,aaaa}
 %global main_libexec generate-rndc-key.sh
 
-# Alternatives touches symlinks targets
-for BIN in %{utils_bin1} %{main_bin1} %{dnssec_utils_bin1}; do
-  install -m 0755 /dev/null ${RPM_BUILD_ROOT}%{_bindir}/${BIN}
-  touch ${RPM_BUILD_ROOT}%{_mandir}/man1/${BIN}.1
-done
-
-for BIN in %{main_bin8}; do
-  install -m 0755 /dev/null ${RPM_BUILD_ROOT}%{_sbindir}/${BIN}
-  touch ${RPM_BUILD_ROOT}%{_mandir}/man8/${BIN}.8
-done
-
-for MAN in %{main_man5}; do
-  touch ${RPM_BUILD_ROOT}%{_mandir}/man5/$MAN.5
-done
-for MAN in %{utils_bin8}; do
-  touch ${RPM_BUILD_ROOT}%{_mandir}/man8/$MAN.8
-done
-
-# named-chroot*.service are missing intentionally now
-# let bind*-chroot conflict
-for UNIT in %{main_unit}; do
-  touch ${RPM_BUILD_ROOT}%{_unitdir}/$UNIT
-done
-
 
 %define altfbin() \\\
   --follower %{_bindir}/%{1} %{upname}-%{1} %{_bindir}/%{1}%{program_suffix}
@@ -1046,24 +1019,24 @@ fi;
 %{_sbindir}/named%{program_suffix}
 %{_sbindir}/rndc%{program_suffix}
 %{_sbindir}/rndc-confgen%{program_suffix}
-%ghost %{_unitdir}/named.service
-%ghost %{_unitdir}/named-setup-rndc.service
+%ghost %attr(0644,-,-) %{_unitdir}/named.service
+%ghost %attr(0644,-,-) %{_unitdir}/named-setup-rndc.service
 %ghost %attr(0755,-,-) %{_libdir}/bind/filter-a.so
 %ghost %attr(0755,-,-) %{_libdir}/bind/filter-aaaa.so
-%ghost %{_bindir}/named-checkconf
-%ghost %{_bindir}/named-journalprint
-%ghost %{_bindir}/named-rrchecker
-%ghost %{_bindir}/mdig
-%ghost %{_sbindir}/named
-%ghost %{_sbindir}/rndc
-%ghost %{_sbindir}/rndc-confgen
+%ghost %attr(0755,-,-) %{_bindir}/named-checkconf
+%ghost %attr(0755,-,-) %{_bindir}/named-journalprint
+%ghost %attr(0755,-,-) %{_bindir}/named-rrchecker
+%ghost %attr(0755,-,-) %{_bindir}/mdig
+%ghost %attr(0755,-,-) %{_sbindir}/named
+%ghost %attr(0755,-,-) %{_sbindir}/rndc
+%ghost %attr(0755,-,-) %{_sbindir}/rndc-confgen
 %if "%{_sbindir}" != "%{_bindir}"
 %{_sbindir}/named-checkconf%{program_suffix}
-%ghost %{_sbindir}/named-checkconf
+%ghost %attr(0755,-,-) %{_sbindir}/named-checkconf
 %endif
 %{_libexecdir}/%{name}/generate-rndc-key.sh
 %{_libexecdir}/%{name}/setup-named-softhsm.sh
-%ghost %{_libexecdir}/generate-rndc-key.sh
+%ghost %attr(0755,-,-) %{_libexecdir}/generate-rndc-key.sh
 # man pages
 %{_mandir}/man1/mdig%{program_suffix}.1*
 %{_mandir}/man1/named-checkconf%{program_suffix}.1*
@@ -1075,15 +1048,15 @@ fi;
 %{_mandir}/man8/named%{program_suffix}.8*
 %{_mandir}/man8/rndc-confgen%{program_suffix}.8*
 %{_mandir}/man8/filter-{a,aaaa}%{program_suffix}.8*
-%ghost %{_mandir}/man1/mdig.1*
-%ghost %{_mandir}/man1/named-checkconf.1*
-%ghost %{_mandir}/man1/named-journalprint.1*
-%ghost %{_mandir}/man1/named-rrchecker.1*
-%ghost %{_mandir}/man5/named.conf.5*
-%ghost %{_mandir}/man5/rndc.conf.5*
-%ghost %{_mandir}/man8/rndc.8*
-%ghost %{_mandir}/man8/named.8*
-%ghost %{_mandir}/man8/rndc-confgen.8*
+%ghost %attr(0644,-,-) %{_mandir}/man1/mdig.1*
+%ghost %attr(0644,-,-) %{_mandir}/man1/named-checkconf.1*
+%ghost %attr(0644,-,-) %{_mandir}/man1/named-journalprint.1*
+%ghost %attr(0644,-,-) %{_mandir}/man1/named-rrchecker.1*
+%ghost %attr(0644,-,-) %{_mandir}/man5/named.conf.5*
+%ghost %attr(0644,-,-) %{_mandir}/man5/rndc.conf.5*
+%ghost %attr(0644,-,-) %{_mandir}/man8/rndc.8*
+%ghost %attr(0644,-,-) %{_mandir}/man8/named.8*
+%ghost %attr(0644,-,-) %{_mandir}/man8/rndc-confgen.8*
 %ghost %attr(0644,-,-) %{_mandir}/man8/filter-a.8*
 %ghost %attr(0644,-,-) %{_mandir}/man8/filter-aaaa.8*
 %doc README.md named.conf.default
@@ -1100,7 +1073,7 @@ fi;
 %dir %{_localstatedir}/named/slaves
 %dir %{_localstatedir}/named/data
 %dir %{_localstatedir}/named/dynamic
-%ghost %{_localstatedir}/log/named.log
+%ghost %attr(0644,named,named) %{_localstatedir}/log/named.log
 %defattr(0640,root,named,0750)
 %{_datadir}/named/
 %config %verify(not link) %{_localstatedir}/named/named.ca
@@ -1108,9 +1081,9 @@ fi;
 %config %verify(not link) %{_localstatedir}/named/named.localhost
 %config %verify(not link) %{_localstatedir}/named/named.loopback
 %config %verify(not link) %{_localstatedir}/named/named.empty
-%ghost %config(noreplace) %{_sysconfdir}/rndc.key
+%ghost %attr(0640,root,named) %config(noreplace) %{_sysconfdir}/rndc.key
 # ^- rndc.key now created on first install only if it does not exist
-%ghost %config(noreplace) %{_sysconfdir}/rndc.conf
+%ghost %attr(0640,root,named) %config(noreplace) %{_sysconfdir}/rndc.conf
 # ^- The default rndc.conf which uses rndc.key is in named's default internal config -
 #    so rndc.conf is not necessary.
 %defattr(-,named,named,-)
@@ -1139,17 +1112,17 @@ fi;
 %{_bindir}/named-compilezone%{program_suffix}
 %{_sbindir}/ddns-confgen%{program_suffix}
 %{_sbindir}/tsig-keygen%{program_suffix}
-%ghost %{_bindir}/arpaname
-%ghost %{_bindir}/delv
-%ghost %{_bindir}/dig
-%ghost %{_bindir}/host
-%ghost %{_bindir}/nsec3hash
-%ghost %{_bindir}/nslookup
-%ghost %{_bindir}/nsupdate
-%ghost %{_bindir}/named-checkzone
-%ghost %{_bindir}/named-compilezone
-%ghost %{_sbindir}/ddns-confgen
-%ghost %{_sbindir}/tsig-keygen
+%ghost %attr(0755,-,-) %{_bindir}/arpaname
+%ghost %attr(0755,-,-) %{_bindir}/delv
+%ghost %attr(0755,-,-) %{_bindir}/dig
+%ghost %attr(0755,-,-) %{_bindir}/host
+%ghost %attr(0755,-,-) %{_bindir}/nsec3hash
+%ghost %attr(0755,-,-) %{_bindir}/nslookup
+%ghost %attr(0755,-,-) %{_bindir}/nsupdate
+%ghost %attr(0755,-,-) %{_bindir}/named-checkzone
+%ghost %attr(0755,-,-) %{_bindir}/named-compilezone
+%ghost %attr(0755,-,-) %{_sbindir}/ddns-confgen
+%ghost %attr(0755,-,-) %{_sbindir}/tsig-keygen
 %if "%{_sbindir}" != "%{_bindir}"
 %{_sbindir}/named-checkzone
 %{_sbindir}/named-compilezone
@@ -1157,14 +1130,14 @@ fi;
 %if %{with DNSTAP}
 %{_bindir}/dnstap-read%{program_suffix}
 %{_mandir}/man1/dnstap-read%{program_suffix}.1*
-%ghost %{_bindir}/dnstap-read
-%ghost %{_mandir}/man1/dnstap-read.1*
+%ghost %attr(0755,-,-) %{_bindir}/dnstap-read
+%ghost %attr(0644,-,-) %{_mandir}/man1/dnstap-read.1*
 %endif
 %if %{with LMDB}
 %{_bindir}/named-nzd2nzf%{program_suffix}
 %{_mandir}/man1/named-nzd2nzf%{program_suffix}.1*
-%ghost %{_bindir}/named-nzd2nzf
-%ghost %{_mandir}/man1/named-nzd2nzf.1*
+%ghost %attr(0755,-,-) %{_bindir}/named-nzd2nzf
+%ghost %attr(0644,-,-) %{_mandir}/man1/named-nzd2nzf.1*
 %endif
 %{_mandir}/man1/arpaname%{program_suffix}.1*
 %{_mandir}/man1/delv%{program_suffix}.1*
@@ -1177,24 +1150,24 @@ fi;
 %{_mandir}/man1/named-compilezone%{program_suffix}.1*
 %{_mandir}/man8/ddns-confgen%{program_suffix}.8*
 %{_mandir}/man8/tsig-keygen%{program_suffix}.8*
-%ghost %{_mandir}/man1/arpaname.1*
-%ghost %{_mandir}/man1/delv.1*
-%ghost %{_mandir}/man1/dig.1*
-%ghost %{_mandir}/man1/host.1*
-%ghost %{_mandir}/man1/nslookup.1*
-%ghost %{_mandir}/man1/nsupdate.1*
-%ghost %{_mandir}/man1/nsec3hash.1*
-%ghost %{_mandir}/man1/named-checkzone.1*
-%ghost %{_mandir}/man1/named-compilezone.1*
-%ghost %{_mandir}/man8/ddns-confgen.8*
-%ghost %{_mandir}/man8/tsig-keygen.8*
+%ghost %attr(0644,-,-) %{_mandir}/man1/arpaname.1*
+%ghost %attr(0644,-,-) %{_mandir}/man1/delv.1*
+%ghost %attr(0644,-,-) %{_mandir}/man1/dig.1*
+%ghost %attr(0644,-,-) %{_mandir}/man1/host.1*
+%ghost %attr(0644,-,-) %{_mandir}/man1/nslookup.1*
+%ghost %attr(0644,-,-) %{_mandir}/man1/nsupdate.1*
+%ghost %attr(0644,-,-) %{_mandir}/man1/nsec3hash.1*
+%ghost %attr(0644,-,-) %{_mandir}/man1/named-checkzone.1*
+%ghost %attr(0644,-,-) %{_mandir}/man1/named-compilezone.1*
+%ghost %attr(0644,-,-) %{_mandir}/man8/ddns-confgen.8*
+%ghost %attr(0644,-,-) %{_mandir}/man8/tsig-keygen.8*
 %{_sysconfdir}/trusted-key.key
 
 %files dnssec-utils
 %{_bindir}/%{dnssec_utils_bin1}%{program_suffix}
 %{_mandir}/man1/%{dnssec_utils_bin1}%{program_suffix}.1*
-%ghost %{_bindir}/%{dnssec_utils_bin1}
-%ghost %{_mandir}/man1/%{dnssec_utils_bin1}.1*
+%ghost %attr(0755,-,-) %{_bindir}/%{dnssec_utils_bin1}
+%ghost %attr(0644,-,-) %{_mandir}/man1/%{dnssec_utils_bin1}.1*
 
 %files devel
 %{_libdir}/libbind9-%{mver}.so
@@ -1204,7 +1177,7 @@ fi;
 %{_libdir}/libisc-%{mver}.so
 %{_libdir}/libisccfg-%{mver}.so
 %{_libdir}/libirs-%{mver}.so
-%ghost %{_includedir}/bind9
+%ghost %attr(0755,-,-) %{_includedir}/bind9
 %dir %{bind_include}
 %{bind_include}/isccc
 %{bind_include}/ns

                 reply	other threads:[~2026-07-15 10:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178410969380.1.15185891740905176302.rpms-bind-0049ee45a47d@fedoraproject.org \
    --to=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox