public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Emmanuel Seyman <emmanuel@seyman.fr>
To: git-commits@fedoraproject.org
Subject: [rpms/perl-CGI-Application-Structured-Tools] rawhide: Fix FTBFS with Module::Starter 1.80+ (#2427852)
Date: Tue, 14 Jul 2026 22:03:23 GMT	[thread overview]
Message-ID: <178406660360.1.13105447422235059661.rpms-perl-CGI-Application-Structured-Tools-1d3b2ef92396@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/perl-CGI-Application-Structured-Tools
Branch : rawhide
Commit : 1d3b2ef92396e2301c6ab665490325b52c5088a2
Author : Emmanuel Seyman <emmanuel@seyman.fr>
Date   : 2026-07-15T00:03:16+02:00
Stats  : +45/-10 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/perl-CGI-Application-Structured-Tools/c/1d3b2ef92396e2301c6ab665490325b52c5088a2?branch=rawhide

Log:
Fix FTBFS with Module::Starter 1.80+ (#2427852)

---
diff --git a/CGI-Application-Structured-Tools-0.015-author.patch b/CGI-Application-Structured-Tools-0.015-author.patch
new file mode 100644
index 0000000..b94fc06
--- /dev/null
+++ b/CGI-Application-Structured-Tools-0.015-author.patch
@@ -0,0 +1,24 @@
+diff -up ./lib/CGI/Application/Structured/Tools/Starter.pm.orig ./lib/CGI/Application/Structured/Tools/Starter.pm
+--- ./lib/CGI/Application/Structured/Tools/Starter.pm.orig	2026-07-14 22:39:01.711899496 +0200
++++ ./lib/CGI/Application/Structured/Tools/Starter.pm	2026-07-14 22:52:23.678162956 +0200
+@@ -89,6 +89,9 @@ sub create_distro {
+     my $self = $either;
+ 
+ 
++    if ( $self->{author} && ref $self->{author} ne 'ARRAY' ) {
++        $self->{author} = [ $self->{author} ];
++    }
+ 
+     # This plugin only works to create one module.  This is
+     # hangover from borrowed code and should be fixed to remove
+@@ -252,6 +255,10 @@ sub render {
+         $opts{$key} = $self->{$key};
+     }
+ 
++	if ( ref $opts{author} eq 'ARRAY' ) {
++        $opts{author} = join( ', ', @{ $opts{author} } );
++    }
++
+     # [1] HTML::Templates wants loops to be arrays of hashes not plain arrays
+     foreach my $key ( keys %opts ) {
+         if ( ref $opts{$key} eq 'ARRAY' ) {

diff --git a/perl-CGI-Application-Structured-Tools.spec b/perl-CGI-Application-Structured-Tools.spec
index 6ee7b34..1131cba 100644
--- a/perl-CGI-Application-Structured-Tools.spec
+++ b/perl-CGI-Application-Structured-Tools.spec
@@ -1,24 +1,30 @@
 Name:           perl-CGI-Application-Structured-Tools
 Version:        0.015
-Release:        39%{?dist}
+Release:        40%{?dist}
 Summary:        Tools to generate and maintain CGI::Application::Structured based web apps
-# Automatically converted from old format: GPL+ or Artistic - review is highly recommended.
 License:        GPL-1.0-or-later OR Artistic-1.0-Perl
-URL:            https://metacpan.org/release/CGI-Application-Structured-Tools
+URL:            https://metacpan.org/dist/CGI-Application-Structured-Tools
 Source0:        https://cpan.metacpan.org/authors/id/V/VA/VANAMBURG/CGI-Application-Structured-Tools-%{version}.tar.gz
 Patch0:         CGI-Application-Structured-Tools-0.015-Adapt-to-Module-Starter-1.71.patch
+Patch1:         CGI-Application-Structured-Tools-0.015-author.patch
 BuildArch:      noarch
-BuildRequires: make
+# build requirements
+BuildRequires:  coreutils
+BuildRequires:  make
 BuildRequires:  perl-generators
+BuildRequires:  perl-interpreter
+BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76
+BuildRequires:  sed
+# runtime requirements
 BuildRequires:  perl(CGI::Application::Structured)
 BuildRequires:  perl(DBIx::Class::Schema::Loader)
-BuildRequires:  perl(ExtUtils::MakeMaker) >= 6.76
 BuildRequires:  perl(File::Slurp)
 BuildRequires:  perl(HTML::Template)
 BuildRequires:  perl(Module::Signature)
 BuildRequires:  perl(Module::Starter)
 BuildRequires:  perl(Module::Starter::Plugin::Template)
 BuildRequires:  perl(Module::Starter::Simple)
+# test requirements
 BuildRequires:  perl(Pod::Coverage)
 BuildRequires:  perl(Probe::Perl)
 BuildRequires:  perl(Test::More)
@@ -41,6 +47,7 @@ and helper scripts to provide a rapid development environment.
 %prep
 %setup -q -n CGI-Application-Structured-Tools-%{version}
 %patch -P0
+%patch -P1
 
 cat << \EOF > %{name}-req
 #!/bin/sh
@@ -66,15 +73,15 @@ chmod 644 index.tmpl config-dev.pl
 sed -i -e '1i#!/usr/bin/perl' server.pl
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1
-make %{?_smp_mflags}
+/usr/bin/perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
+%{make_build}
 
 %install
-make pure_install DESTDIR=$RPM_BUILD_ROOT
-%{_fixperms} $RPM_BUILD_ROOT/*
+%{make_install}
+%{_fixperms} %{buildroot}/*
 
 %check
-make test
+%{make_build} test
 
 %files
 %doc Changes README Todo
@@ -85,6 +92,10 @@ make test
 %{_bindir}/cas-starter.pl
 
 %changelog
+* Tue Jul 14 2026 Emmanuel Seyman <emmanuel@seyman.fr> - 0.015-40
+- Fix compatibility with Module::Starter 1.80+ author arrayref rhbz#2427852 (Filipe Rosset)
+- Modernize spec file
+
 * Fri Jan 16 2026 Fedora Release Engineering <releng@fedoraproject.org> - 0.015-39
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_44_Mass_Rebuild
 

                 reply	other threads:[~2026-07-14 22:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178406660360.1.13105447422235059661.rpms-perl-CGI-Application-Structured-Tools-1d3b2ef92396@fedoraproject.org \
    --to=emmanuel@seyman.fr \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox