public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/virtualbox-guest-additions] alext-upd-to-7.2.12: Fix build with gcc8
Date: Sun, 12 Jul 2026 20:57:37 GMT	[thread overview]
Message-ID: <178388985799.1.4841277007231617794.rpms-virtualbox-guest-additions-09d8bc174fde@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/virtualbox-guest-additions
Branch : alext-upd-to-7.2.12
Commit : 09d8bc174fde6dfdc2fb71eb265d96de5c31d6b3
Author : Hans de Goede <hdegoede@redhat.com>
Date   : 2018-02-14T08:56:03+01:00
Stats  : +16/-0 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/virtualbox-guest-additions/c/09d8bc174fde6dfdc2fb71eb265d96de5c31d6b3?branch=alext-upd-to-7.2.12

Log:
Fix build with gcc8

---
diff --git a/VirtualBox-5.2.6-gcc8.patch b/VirtualBox-5.2.6-gcc8.patch
new file mode 100644
index 0000000..37a0348
--- /dev/null
+++ b/VirtualBox-5.2.6-gcc8.patch
@@ -0,0 +1,14 @@
+diff -up VirtualBox-5.2.6/configure~ VirtualBox-5.2.6/configure
+--- VirtualBox-5.2.6/configure~	2018-01-15 15:49:37.000000000 +0100
++++ VirtualBox-5.2.6/configure	2018-02-14 08:53:25.602712747 +0100
+@@ -440,8 +440,8 @@ check_gcc()
+       elif [ $cc_maj -lt 4 \
+              -o \( $cc_maj -eq 4 -a $cc_min -lt 4 -a "$OS" != "darwin" \) \
+              -o \( $cc_maj -eq 4 -a $cc_min -lt 2 -a "$OS"  = "darwin" \) \
+-             -o $cc_maj -gt 7 ]; then
+-        log_failure "gcc version $cc_maj.$cc_min found, expected gcc 4.x...7.x"
++             -o $cc_maj -gt 8 ]; then
++        log_failure "gcc version $cc_maj.$cc_min found, expected gcc 4.x...8.x"
+         fail really
+       else
+         log_success "found version $cc_ver"

diff --git a/virtualbox-guest-additions.spec b/virtualbox-guest-additions.spec
index 01f7c09..c1b44d8 100644
--- a/virtualbox-guest-additions.spec
+++ b/virtualbox-guest-additions.spec
@@ -19,6 +19,8 @@ Patch1:     VirtualBox-5.0.18-xserver_guest.patch
 Patch2:     0001-VBoxServiceAutoMount-Change-Linux-mount-code-to-use-.patch
 # Do not show an error dialog when not running under vbox
 Patch3:     VirtualBox-5.2.6-xclient.patch
+# Fix build with gcc8
+Patch4:     VirtualBox-5.2.6-gcc8.patch
 
 BuildRequires:  kBuild >= 0.1.9998
 BuildRequires:  desktop-file-utils

                 reply	other threads:[~2026-07-12 20:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178388985799.1.4841277007231617794.rpms-virtualbox-guest-additions-09d8bc174fde@fedoraproject.org \
    --to=hdegoede@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox