public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Tom Rix <Tom.Rix@amd.com>
To: git-commits@fedoraproject.org
Subject: [rpms/hipblas] epel10: Fix test building on epel
Date: Fri, 10 Jul 2026 12:57:35 GMT	[thread overview]
Message-ID: <178368825558.1.12036972851108179719.rpms-hipblas-b73766d2e65a@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/hipblas
            Branch : epel10
            Commit : b73766d2e65ac402688f1d52294fe14528807a9a
            Author : Tom Rix <Tom.Rix@amd.com>
            Date   : 2026-07-10T05:57:02-07:00
            Stats  : +10/-1 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/hipblas/c/b73766d2e65ac402688f1d52294fe14528807a9a?branch=epel10

            Log:
            Fix test building on epel

Signed-off-by: Tom Rix <Tom.Rix@amd.com>

---
diff --git a/hipblas.spec b/hipblas.spec
index d79ed92..8b553e4 100644
--- a/hipblas.spec
+++ b/hipblas.spec
@@ -127,6 +127,11 @@ BuildRequires:  gtest-devel
 BuildRequires:  cblas-devel
 BuildRequires:  lapack-devel
 %else
+# On RHEL, this error
+#        ld.lld: error: undefined symbol: _gfortran_transfer_character_write
+#        >>> referenced by xerbla.f.o:(xerbla_) in archive /usr/lib64/libblas64.a
+# but also hipblas/clients/include/cblas_interface.h has a hardcoded dependence on cblas_ functions
+%global blas_static OFF
 BuildRequires:  blas-static
 BuildRequires:  lapack-static
 BuildRequires:  python3-pyyaml
@@ -191,8 +196,11 @@ sed -i -e 's@find_package(Git REQUIRED)@#find_package(Git REQUIRED)@' library/CM
 # LINK_BLIS
 #   ON: use AOCL BLIS
 #   OFF: use lapack, cblas
+#
+# It can be painful figuring out where your blas library is, add this to the command line
+#    --debug-find-pkg=BLAS --debug-trycompile
 %cmake \
-    -DAMDGPU_TARGETS=%{rocm_gpu_list_default} \
+    -DBLA_STATIC=%blas_static \
     -DBUILD_FILE_REORG_BACKWARD_COMPATIBILITY=OFF \
     -DBUILD_CLIENTS_BENCHMARKS=%{build_test} \
     -DBUILD_CLIENTS_TESTS=%{build_test} \
@@ -211,6 +219,7 @@ sed -i -e 's@find_package(Git REQUIRED)@#find_package(Git REQUIRED)@' library/CM
     -DCMAKE_PREFIX_PATH=%{rocmllvm_cmakedir}/.. \
     -DCMAKE_SKIP_RPATH=%{skip_install_rpath} \
     -DCMAKE_SKIP_INSTALL_RPATH=%{skip_install_rpath} \
+    -DGPU_TARGETS=%{rocm_gpu_list_default} \
     -DROCM_SYMLINK_LIBS=OFF \
     -DHIP_PLATFORM=amd \
     -DLINK_BLIS=OFF

                 reply	other threads:[~2026-07-10 12:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178368825558.1.12036972851108179719.rpms-hipblas-b73766d2e65a@fedoraproject.org \
    --to=tom.rix@amd.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox