public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
To: git-commits@fedoraproject.org
Subject: [rpms/pyproject-rpm-macros] rawhide: Define dummy %pyproject_files in the SRPM macros
Date: Fri, 10 Jul 2026 10:49:51 GMT	[thread overview]
Message-ID: <178368059167.1.8446456019458940908.rpms-pyproject-rpm-macros-2a21dbd31123@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/pyproject-rpm-macros
            Branch : rawhide
            Commit : 2a21dbd31123f44a25a5992af5dd3c26b8e2f029
            Author : Miro Hrončok <miro@hroncok.cz>
            Date   : 2026-07-09T12:19:57+02:00
            Stats  : +4/-0 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/pyproject-rpm-macros/c/2a21dbd31123f44a25a5992af5dd3c26b8e2f029?branch=rawhide

            Log:
            Define dummy %pyproject_files in the SRPM macros

Apparently, when the macro is undefined and used like this:

    %files -n python3-markupsafe -f %{pyproject_files -D markupsafe}

RPM expands it literally and the -D is passed to %files, leading to:

    error: line ...: Bad option -D: %files -n python3-markupsafe -f %{pyproject_files -D markupsafe}

---
diff --git a/macros.aaa-pyproject-srpm b/macros.aaa-pyproject-srpm
index 5795c7b..dfacb68 100644
--- a/macros.aaa-pyproject-srpm
+++ b/macros.aaa-pyproject-srpm
@@ -6,6 +6,10 @@
 # Note: This takes arbitrary options, to ease addition of new options to the real macro.
 %pyproject_buildrequires(-) echo 'pyproject-rpm-macros'
 
+# Similarly, we define a dummy (to be overridden) %%pyproject_files, to avoid:
+#   error: Bad option -D: %%files -n python3-... -f %%{pyproject_files -D ...}
+%pyproject_files(-) dummy
+
 # We need to define %%pyproject_patch_dependency here in the srpm macros, along with any path-related macros it uses,
 # because this macro is normally used in %%prep, before any generated BR is installed.
 # - The backward-compatible %%_pyproject_files_pkgversion suffix is used in all pyproject-rpm-macros directories.

                 reply	other threads:[~2026-07-10 10:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178368059167.1.8446456019458940908.rpms-pyproject-rpm-macros-2a21dbd31123@fedoraproject.org \
    --to=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox