public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Benjamin A. Beasley <code@musicinmybrain.net>
To: git-commits@fedoraproject.org
Subject: [rpms/python-tiktoken] rawhide: Add a comment to justify not running the tests
Date: Mon, 06 Jul 2026 18:13:22 GMT	[thread overview]
Message-ID: <178336160291.1.2869443118853693216.rpms-python-tiktoken-7e4c9bf6931f@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/python-tiktoken
Branch : rawhide
Commit : 7e4c9bf6931f8eff81ac0a671ff14a6544dcf3a9
Author : Benjamin A. Beasley <code@musicinmybrain.net>
Date   : 2026-07-06T11:10:32+01:00
Stats  : +7/-0 in 1 file(s)
URL    : https://src.fedoraproject.org/rpms/python-tiktoken/c/7e4c9bf6931f8eff81ac0a671ff14a6544dcf3a9?branch=rawhide

Log:
Add a comment to justify not running the tests

---
diff --git a/python-tiktoken.spec b/python-tiktoken.spec
index 6a7c52a..b6a6dfd 100644
--- a/python-tiktoken.spec
+++ b/python-tiktoken.spec
@@ -61,6 +61,13 @@ Summary:        %{summary}
 
 %check
 %pyproject_check_import
+# All or nearly all tests require data files downloaded from the Internet; see
+# tiktoken_ext/openai_public.py. We *could* add these as additional sources,
+# copy them into a directory (renaming each file to the hexadecimal SHA1 digest
+# of its original URL), and set the TIKTOKEN_CACHE_DIR environment variable
+# when running the tests to use these “pre-downloaded” data files. However, not
+# only would this be fussy, but it means we would have to try to figure out
+# what licenses, if any, apply to these data files.
 
 
 %files -n python3-tiktoken -f %{pyproject_files}

                 reply	other threads:[~2026-07-06 18:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178336160291.1.2869443118853693216.rpms-python-tiktoken-7e4c9bf6931f@fedoraproject.org \
    --to=code@musicinmybrain.net \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox