public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: raveit65 <raveit65.sun@gmail.com>
To: git-commits@fedoraproject.org
Subject: [rpms/mate-menus] f43: update to 1.28.1
Date: Sun, 05 Jul 2026 18:53:45 GMT	[thread overview]
Message-ID: <178327762586.1.7806450343510151212.rpms-mate-menus-8947b6d232b7@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/mate-menus
            Branch : f43
            Commit : 8947b6d232b7dac41e9d4e53bedb5b4c713f8779
            Author : raveit65 <raveit65.sun@gmail.com>
            Date   : 2026-07-05T20:53:31+02:00
            Stats  : +67/-6 in 4 file(s)
            URL    : https://src.fedoraproject.org/rpms/mate-menus/c/8947b6d232b7dac41e9d4e53bedb5b4c713f8779?branch=f43

            Log:
            update to 1.28.1

- build: don't strip safety checks

---
diff --git a/.gitignore b/.gitignore
index 0b23c2a..b954064 100644
--- a/.gitignore
+++ b/.gitignore
@@ -29,3 +29,4 @@
 /mate-menus-1.26.0.tar.xz
 /mate-menus-1.26.1.tar.xz
 /mate-menus-1.28.0.tar.xz
+/mate-menus-1.28.1.tar.xz

diff --git a/mate-menus.spec b/mate-menus.spec
index 3ba64fc..52c4a4d 100644
--- a/mate-menus.spec
+++ b/mate-menus.spec
@@ -1,15 +1,13 @@
 Name:          mate-menus
-Version:       1.28.0
+Version:       1.28.1
 Release:       %autorelease
 Summary:       Displays menus for MATE Desktop
 # Automatically converted from old format: GPLv2+ and LGPLv2+ - review is highly recommended.
 License:       GPL-2.0-or-later AND LicenseRef-Callaway-LGPLv2+
 URL:           http://mate-desktop.org
 Source0:       http://pub.mate-desktop.org/releases/1.28/%{name}-%{version}.tar.xz
-# >= f43 , see rhbz (#2411809)
-%if 0%{?fedora} && 0%{?fedora} >= 43
-Patch1:        mate-menus_glib2-2.86.patch
-%endif
+# https://github.com/mate-desktop/mate-menus/pull/129
+Patch1:        mate-menus_0001-build-don-t-strip-safety-checks.patch
 
 BuildRequires: make
 BuildRequires: gobject-introspection-devel

diff --git a/mate-menus_0001-build-don-t-strip-safety-checks.patch b/mate-menus_0001-build-don-t-strip-safety-checks.patch
new file mode 100644
index 0000000..aae101f
--- /dev/null
+++ b/mate-menus_0001-build-don-t-strip-safety-checks.patch
@@ -0,0 +1,62 @@
+From 7607deba9354522a7ba124a2224c3253d23ef676 Mon Sep 17 00:00:00 2001
+From: Victor Kareh <vkareh@redhat.com>
+Date: Fri, 3 Jul 2026 11:58:18 -0400
+Subject: [PATCH] build: don't strip safety checks
+
+Both meson and autotools were stripping g_return_if_fail calls in the
+preprocessor. This meant that when mozo hit a NULL tree root during menu
+reload, the guard in matemenu_tree_item_ref did nothing and it crashed
+instead of returning gracefully.
+
+We change the guards to direct NULL checks and enable debug mode as the
+default to fix this.
+
+Fixes mate-desktop/mozo#90
+---
+ configure.ac            | 2 +-
+ libmenu/matemenu-tree.c | 9 +++++++--
+ 3 files changed, 8 insertions(+), 7 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index 4261842..d8335ee 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -10,7 +10,7 @@ AC_CONFIG_HEADERS(config.h)
+ 
+ AM_MAINTAINER_MODE
+ MATE_MAINTAINER_MODE_DEFINES
+-MATE_DEBUG_CHECK([no])
++MATE_DEBUG_CHECK
+ MATE_COMPILE_WARNINGS
+ 
+ # Before making a release, the LT_VERSION string should be modified.
+diff --git a/libmenu/matemenu-tree.c b/libmenu/matemenu-tree.c
+index f1ffa9d..293018b 100644
+--- a/libmenu/matemenu-tree.c
++++ b/libmenu/matemenu-tree.c
+@@ -1807,7 +1807,10 @@ gpointer
+ matemenu_tree_item_ref (gpointer itemp)
+ {
+   MateMenuTreeItem* item = (MateMenuTreeItem*) itemp;
+-  g_return_val_if_fail(item != NULL, NULL);
++
++  if (item == NULL)
++    return NULL;
++
+   g_return_val_if_fail(item->refcount > 0, NULL);
+ 
+   g_atomic_int_inc (&item->refcount);
+@@ -1822,7 +1825,9 @@ matemenu_tree_item_unref (gpointer itemp)
+ 
+   item = (MateMenuTreeItem *) itemp;
+ 
+-  g_return_if_fail (item != NULL);
++  if (item == NULL)
++    return;
++
+   g_return_if_fail (item->refcount > 0);
+ 
+   if (g_atomic_int_dec_and_test (&(item->refcount)))
+-- 
+2.54.0
+

diff --git a/sources b/sources
index f57913b..721df1f 100644
--- a/sources
+++ b/sources
@@ -1 +1 @@
-SHA512 (mate-menus-1.28.0.tar.xz) = 23baff3fc76d19df82fc36a94f1178a96cfec2aa57171b0d4839ff1d431e56169f09a277254cf3991fd5bb3d7f8c2d67cb41f30e94cedd50c934b561793d15af
+SHA512 (mate-menus-1.28.1.tar.xz) = 3cabe784e988f13c6ade52edf7f619a0c779f2689e6507d6b98d8adb3b5f35162ee38443bcc7faeb3fcd0ed7973cf2a8516df36092afe70ac3f6049941417f90

                 reply	other threads:[~2026-07-05 18:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178327762586.1.7806450343510151212.rpms-mate-menus-8947b6d232b7@fedoraproject.org \
    --to=raveit65.sun@gmail.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox