public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/gdb] gdb-17.2-rebase-f44: Remove gdb-rhbz1149205-catch-syscall-after-fork-test.patch
Date: Sun, 28 Jun 2026 00:02:10 GMT	[thread overview]
Message-ID: <178260493035.1.14496545179109554755.rpms-gdb-660c52fea5bd@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/gdb
            Branch : gdb-17.2-rebase-f44
            Commit : 660c52fea5bdc3728f08d18c56fbccce2a9dcdcb
            Author : Keith Seitz <keiths@redhat.com>
            Date   : 2025-05-12T10:50:12-07:00
            Stats  : +7/-133 in 5 file(s)
            URL    : https://src.fedoraproject.org/rpms/gdb/c/660c52fea5bdc3728f08d18c56fbccce2a9dcdcb?branch=gdb-17.2-rebase-f44

            Log:
            Remove gdb-rhbz1149205-catch-syscall-after-fork-test.patch

This has been superseded by the upstream commit:

commit a19c78180e083196ac741ffde4bc94d529c6808c
Date:   Mon May 12 09:28:02 2025 -0700

    [PATCH] Add syscall tests when following/detaching from fork

---
diff --git a/_gdb.spec.Patch.include b/_gdb.spec.Patch.include
index 6b821a4..5adebfe 100644
--- a/_gdb.spec.Patch.include
+++ b/_gdb.spec.Patch.include
@@ -9,11 +9,6 @@ Patch002: gdb-6.3-mapping-zero-inode-test.patch
 #=fedoratest
 Patch003: gdb-archer-next-over-throw-cxx-exec.patch
 
-# Fix '`catch syscall' doesn't work for parent after `fork' is called'
-# (Philippe Waroquiers, RH BZ 1149205).
-#=fedoratest
-Patch004: gdb-rhbz1149205-catch-syscall-after-fork-test.patch
-
 # Update gdb-add-index.sh such that, when the GDB environment
 # variable is not set, the script is smarter than just looking for
 # 'gdb' in the $PATH.
@@ -26,12 +21,12 @@ Patch004: gdb-rhbz1149205-catch-syscall-after-fork-test.patch
 #   https://fedoraproject.org/wiki/Changes/Minimal_GDB_in_buildroot
 #
 #=fedora
-Patch005: gdb-add-index.patch
+Patch004: gdb-add-index.patch
 
 # Not a backport.  Add a new script which hooks into GDB and suggests
 # RPMs to install when GDB finds an objfile with no debug info.
-Patch006: gdb-add-rpm-suggestion-script.patch
+Patch005: gdb-add-rpm-suggestion-script.patch
 
 # Backport "Fix another timeout in gdb.base/bg-execution-repeat.exp"
-Patch007: gdb-fix-bg-execution-repeat.patch
+Patch006: gdb-fix-bg-execution-repeat.patch
 

diff --git a/_gdb.spec.patch.include b/_gdb.spec.patch.include
index f6a9246..5885b36 100644
--- a/_gdb.spec.patch.include
+++ b/_gdb.spec.patch.include
@@ -4,4 +4,3 @@
 %patch -p1 -P004
 %patch -p1 -P005
 %patch -p1 -P006
-%patch -p1 -P007

diff --git a/_patch_order b/_patch_order
index bd788a3..de49aec 100644
--- a/_patch_order
+++ b/_patch_order
@@ -1,7 +1,6 @@
 gdb-6.3-rh-testversion-20041202.patch
 gdb-6.3-mapping-zero-inode-test.patch
 gdb-archer-next-over-throw-cxx-exec.patch
-gdb-rhbz1149205-catch-syscall-after-fork-test.patch
 gdb-add-index.patch
 gdb-add-rpm-suggestion-script.patch
 gdb-fix-bg-execution-repeat.patch

diff --git a/gdb-rhbz1149205-catch-syscall-after-fork-test.patch b/gdb-rhbz1149205-catch-syscall-after-fork-test.patch
deleted file mode 100644
index 63c4051..0000000
--- a/gdb-rhbz1149205-catch-syscall-after-fork-test.patch
+++ /dev/null
@@ -1,123 +0,0 @@
-From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
-From: Fedora GDB patches <invalid@email.com>
-Date: Fri, 27 Oct 2017 21:07:50 +0200
-Subject: gdb-rhbz1149205-catch-syscall-after-fork-test.patch
-
-;; Fix '`catch syscall' doesn't work for parent after `fork' is called'
-;; (Philippe Waroquiers, RH BZ 1149205).
-;;=fedoratest
-
-URL: <https://sourceware.org/ml/gdb-patches/2013-05/msg00364.html>
-Message-ID: <1368136582.30058.7.camel@soleil>
-
-  From: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
-  To: gdb-patches at sourceware dot org
-  Subject: RFA: fix gdb_assert caused by 'catch signal ...' and fork
-  Date: Thu, 09 May 2013 23:56:22 +0200
-
-  The attached patch fixes a gdb_assert caused by the combination of catch
-  signal and fork:
-    break-catch-sig.c:152: internal-error: signal_catchpoint_remove_location: Assertion `signal_catch_counts[iter] > 0' failed.
-
-  The problem is that the signal_catch_counts is decremented by detach_breakpoints.
-  The fix consists in not detaching breakpoint locations of type bp_loc_other.
-  The patch introduces a new test.
-
-Comments by Sergio Durigan Junior:
-
-  I addded a specific testcase for this patch, which tests exactly the
-  issue that the customer is facing.  This patch does not solve the
-  whole problem of catching a syscall and forking (for more details,
-  see <https://sourceware.org/bugzilla/show_bug.cgi?id=13457>,
-  specifically comment #3), but it solves the issue reported by the
-  customer.
-
-  I also removed the original testcase of this patch, because it
-  relied on "catch signal", which is a command that is not implemented
-  in this version of GDB.
-
-commit bd9673a4ded96ea5c108601501c8e59003ea1be6
-Author: Philippe Waroquiers <philippe@sourceware.org>
-Date:   Tue May 21 18:47:05 2013 +0000
-
-    Fix internal error caused by interaction between catch signal and fork
-
-diff --git a/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.c b/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.c
-new file mode 100644
---- /dev/null
-+++ b/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.c
-@@ -0,0 +1,11 @@
-+#include <stdio.h>
-+#include <unistd.h>
-+
-+int
-+main (int argc, char **argv)
-+{
-+  if (fork () == 0)
-+    sleep (1);
-+  chdir (".");
-+  return 0;
-+}
-diff --git a/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.exp b/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.exp
-new file mode 100644
---- /dev/null
-+++ b/gdb/testsuite/gdb.base/gdb-rhbz1149205-catch-syscall-fork.exp
-@@ -0,0 +1,58 @@
-+# Copyright 2015 Free Software Foundation, Inc.
-+
-+# This program is free software; you can redistribute it and/or modify
-+# it under the terms of the GNU General Public License as published by
-+# the Free Software Foundation; either version 3 of the License, or
-+# (at your option) any later version.
-+#
-+# This program is distributed in the hope that it will be useful,
-+# but WITHOUT ANY WARRANTY; without even the implied warranty of
-+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-+# GNU General Public License for more details.
-+#
-+# You should have received a copy of the GNU General Public License
-+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-+
-+if { [is_remote target] || ![isnative] } then {
-+    continue
-+}
-+
-+set testfile "gdb-rhbz1149205-catch-syscall-fork"
-+set srcfile ${testfile}.c
-+set binfile [standard_output_file ${testfile}]
-+
-+# Until "catch syscall" is implemented on other targets...
-+if {![istarget "hppa*-hp-hpux*"] && ![istarget "*-linux*"]} then {
-+    continue
-+}
-+
-+# This shall be updated whenever 'catch syscall' is implemented
-+# on some architecture.
-+#if { ![istarget "i\[34567\]86-*-linux*"]
-+if { ![istarget "x86_64-*-linux*"] && ![istarget "i\[34567\]86-*-linux*"]
-+     && ![istarget "powerpc-*-linux*"] && ![istarget "powerpc64-*-linux*"]
-+     && ![istarget "sparc-*-linux*"] && ![istarget "sparc64-*-linux*"] } {
-+     continue
-+}
-+
-+if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
-+    untested ${testfile}.exp
-+    return -1
-+}
-+
-+gdb_exit
-+gdb_start
-+gdb_reinitialize_dir $srcdir/$subdir
-+gdb_load $binfile
-+
-+if { ![runto_main] } {
-+    return -1
-+}
-+
-+gdb_test "catch syscall chdir" \
-+  "Catchpoint $decimal \\\(syscall (.)?chdir(.)? \\\[$decimal\\\]\\\)" \
-+  "catch syscall chdir"
-+
-+gdb_test "continue" \
-+  "Continuing\.\r\n.*\r\nCatchpoint $decimal \\\(call to syscall .?chdir.?.*" \
-+  "continue from catch syscall after fork"

diff --git a/gdb.spec b/gdb.spec
index e647994..f431b1e 100644
--- a/gdb.spec
+++ b/gdb.spec
@@ -923,6 +923,10 @@ fi
 # endif scl
 
 %changelog
+* Mon May 12 2025 Keith Seitz <keiths@redhat.com>
+- Remove gdb-rhbz1149205-catch-syscall-after-fork-test.patch
+  in favor of upstream commit.
+
 * Wed May 07 2025 Andrew Burgess <aburgess@redhat.com>
 - Remove gdb-6.8-bz466901-backtrace-full-prelinked.patch.  Prelinking
   is no longer supported, there seems little point keeping this test.

                 reply	other threads:[~2026-06-28  0:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178260493035.1.14496545179109554755.rpms-gdb-660c52fea5bd@fedoraproject.org \
    --to=keiths@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox