public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/gdb] gdb-17.2-rebase-f44: Remove gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch
Date: Sun, 28 Jun 2026 00:02:06 GMT	[thread overview]
Message-ID: <178260492614.1.3765144111028470708.rpms-gdb-a65de0f14d05@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/gdb
            Branch : gdb-17.2-rebase-f44
            Commit : a65de0f14d05a1fa2d8dd5a2fc2782ec115c9d24
            Author : Kevin Buettner <kevinb@redhat.com>
            Date   : 2025-03-06T14:15:04-07:00
            Stats  : +9/-246 in 5 file(s)
            URL    : https://src.fedoraproject.org/rpms/gdb/c/a65de0f14d05a1fa2d8dd5a2fc2782ec115c9d24?branch=gdb-17.2-rebase-f44

            Log:
            Remove gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch

These are architecture specific tests for s390x and ppc64 that are
intended to test a non-architecture-specific fix that was upstreamed
in 2015.  At that time, the test 'gdb.arch/amd64-prologue-skip.exp'
was also pushed to upstream.  This test should be sufficient to test
that non-architecture-specific fix.

If, at some point, we decided that we do want to upstream the s390x
and ppc64 tests, .S files should be written for these architectures
which mimic gdb.arch/amd64-prologue-skip.S.  These tests should be
made to PASS with current GDB but also demonstrate the original
failure in sources without the 2015 fix.  Since there's already an
upstream test for x86_64 (which is tested regularly), it doesn't seem
especially important to also provide tests for these other
architectures.

---
diff --git a/_gdb.spec.Patch.include b/_gdb.spec.Patch.include
index cdd71ed..72c2589 100644
--- a/_gdb.spec.Patch.include
+++ b/_gdb.spec.Patch.include
@@ -22,11 +22,6 @@ Patch005: gdb-rhbz-818343-set-solib-absolute-prefix-testcase.patch
 #=fedoratest
 Patch006: gdb-rhbz1149205-catch-syscall-after-fork-test.patch
 
-# Fix '[ppc64] and [s390x] wrong prologue skip on -O2 -g code' (Jan
-# Kratochvil, RH BZ 1084404).
-#=fedoratest
-Patch007: gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch
-
 # Update gdb-add-index.sh such that, when the GDB environment
 # variable is not set, the script is smarter than just looking for
 # 'gdb' in the $PATH.
@@ -39,19 +34,19 @@ Patch007: gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch
 #   https://fedoraproject.org/wiki/Changes/Minimal_GDB_in_buildroot
 #
 #=fedora
-Patch008: gdb-add-index.patch
+Patch007: gdb-add-index.patch
 
 # Not a backport.  Add a new script which hooks into GDB and suggests
 # RPMs to install when GDB finds an objfile with no debug info.
-Patch009: gdb-add-rpm-suggestion-script.patch
+Patch008: gdb-add-rpm-suggestion-script.patch
 
 # Backport upstream commit 2fc56106422 which fixes a possible
 # segfault when opening a core file.  This will drop out when we
 # rebase to 16.3 or 17.1
-Patch010: core-target-open-segfault.patch
+Patch009: core-target-open-segfault.patch
 
 # Backport upstream commit 2b646bb8767, this fixes an issue where
 # TUI output was not flushed to the screen in some cases.  This will
 # drop out when we rebase on 16.3 or 17.1.
-Patch011: tui-wrefresh-issue.patch
+Patch010: tui-wrefresh-issue.patch
 

diff --git a/_gdb.spec.patch.include b/_gdb.spec.patch.include
index a409d9f..6295406 100644
--- a/_gdb.spec.patch.include
+++ b/_gdb.spec.patch.include
@@ -8,4 +8,3 @@
 %patch -p1 -P008
 %patch -p1 -P009
 %patch -p1 -P010
-%patch -p1 -P011

diff --git a/_patch_order b/_patch_order
index 3ac50ab..5d657e8 100644
--- a/_patch_order
+++ b/_patch_order
@@ -4,7 +4,6 @@ gdb-6.8-bz466901-backtrace-full-prelinked.patch
 gdb-archer-next-over-throw-cxx-exec.patch
 gdb-rhbz-818343-set-solib-absolute-prefix-testcase.patch
 gdb-rhbz1149205-catch-syscall-after-fork-test.patch
-gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch
 gdb-add-index.patch
 gdb-add-rpm-suggestion-script.patch
 core-target-open-segfault.patch

diff --git a/gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch b/gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch
deleted file mode 100644
index d92bfc3..0000000
--- a/gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch
+++ /dev/null
@@ -1,235 +0,0 @@
-From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
-From: Fedora GDB patches <invalid@email.com>
-Date: Fri, 27 Oct 2017 21:07:50 +0200
-Subject: gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch
-
-;; Fix '[ppc64] and [s390x] wrong prologue skip on -O2 -g code' (Jan
-;; Kratochvil, RH BZ 1084404).
-;;=fedoratest
-
-These testcases have been created by compiling glibc-2.17-78 on
-RHEL-7.1 s390x/ppc64 boxes, and then taking the "select.o" file
-present at $builddir/misc/select.o.
-
-diff --git a/gdb/testsuite/gdb.arch/ppc64-prologue-skip.exp b/gdb/testsuite/gdb.arch/ppc64-prologue-skip.exp
-new file mode 100644
---- /dev/null
-+++ b/gdb/testsuite/gdb.arch/ppc64-prologue-skip.exp
-@@ -0,0 +1,34 @@
-+# Copyright 2015 Free Software Foundation, Inc.
-+
-+# This program is free software; you can redistribute it and/or modify
-+# it under the terms of the GNU General Public License as published by
-+# the Free Software Foundation; either version 3 of the License, or
-+# (at your option) any later version.
-+#
-+# This program is distributed in the hope that it will be useful,
-+# but WITHOUT ANY WARRANTY; without even the implied warranty of
-+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-+# GNU General Public License for more details.
-+#
-+# You should have received a copy of the GNU General Public License
-+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-+
-+if { ![istarget powerpc64-*linux-*] || ![is_lp64_target] } {
-+    verbose "Skipping ppc64-prologue-skip.exp"
-+    return
-+}
-+
-+set testfile "ppc64-prologue-skip"
-+set uufile "${srcdir}/${subdir}/${testfile}.o.uu"
-+set ofile "${srcdir}/${subdir}/${testfile}.o"
-+
-+if { [catch "system \"uudecode -o ${ofile} ${uufile}\"" ] != 0 } {
-+    untested "failed uudecode"
-+    return -1
-+}
-+
-+gdb_exit
-+gdb_start
-+gdb_load $ofile
-+
-+gdb_test "break ___newselect_nocancel" "Breakpoint $decimal at 0xc: file ../sysdeps/unix/syscall-template.S, line 81." "breakpoint on ___newselect_nocancel"
-diff --git a/gdb/testsuite/gdb.arch/ppc64-prologue-skip.o.uu b/gdb/testsuite/gdb.arch/ppc64-prologue-skip.o.uu
-new file mode 100644
---- /dev/null
-+++ b/gdb/testsuite/gdb.arch/ppc64-prologue-skip.o.uu
-@@ -0,0 +1,70 @@
-+begin 644 ppc64-skip-prologue.o.uu
-+M?T5,1@("`0`````````````!`!4````!````````````````````````````
-+M``-(``````!```````!``!0`$8%-B-`L"@``0,(`-#@``(Y$```"3.,`('P(
-+M`J;X`0`0^"'_D4@```%@````Z`$`@#@A`'!\"`.F3H``(/@A_X%]*`*F^2$`
-+MD/CA`-#XP0#(^*$`P/B!`+CX80"P2````6````#X80!PZ.$`T.C!`,CHH0#`
-+MZ($`N.AA`+`X``".1````GP``";X80!X^`$`B.AA`'!(```!8````.DA`)#H
-+M`0"(Z&$`>'TH`Z9\#_$@."$`@$SC`"!+__]@```````,($``````````O``(
-+M7U]S96QE8W0```````````````````````````!6``(````Y!`'[#@T``0$!
-+M`0````$```$N+B]S>7-D97!S+W5N:7@``'-Y<V-A;&PM=&5M<&QA=&4N4P`!
-+M``````D"```````````#T``!`BT3`@D``0$```"/``(`````"`$`````````
-+M`````````````````"XN+W-Y<V1E<',O=6YI>"]S>7-C86QL+71E;7!L871E
-+M+E,`+W)O;W0O9VQI8F,O9VQI8F,M,BXQ-RTW."YE;#<N<W)C+V=L:6)C+3(N
-+M,3<M8S<U.&$V.#8O;6ES8P!'3E4@05,@,BXR,RXU,BXP+C$`@`$!$0`0!A$!
-+M$@$#"!L()0@3!0`````````````````L``(`````"```````````````````
-+M````````V``````````````````````````0``````%Z4@`$>$$!&PP!````
-+M`#`````8`````````+P`20YP$4%^1`X`009!0@Z``4(107Y2$49_20X`!D$&
-+M1@``````+G-Y;71A8@`N<W1R=&%B`"YS:'-T<G1A8@`N<F5L82YT97AT`"YD
-+M871A`"YB<W,`+G)E;&$N;W!D`"YN;W1E+D=.52US=&%C:P`N<F5L82YD96)U
-+M9U]L:6YE`"YR96QA+F1E8G5G7VEN9F\`+F1E8G5G7V%B8G)E=@`N<F5L82YD
-+M96)U9U]A<F%N9V5S`"YR96QA+F5H7V9R86UE````````````````````````
-+M````````````````````````````````````````````````````````````
-+M`````````"`````!``````````8```````````````````!``````````-@`
-+M```````````````````$```````````````;````!```````````````````
-+M```````````*>`````````!(````$@````$`````````"``````````8````
-+M)@````$``````````P```````````````````1@`````````````````````
-+M``````````$``````````````"P````(``````````,`````````````````
-+M``$8```````````````````````````````!```````````````V`````0``
-+M```````#```````````````````!&``````````0````````````````````
-+M"```````````````,0````0`````````````````````````````"L``````
-+M````,````!(````%``````````@`````````&````#L````!````````````
-+M``````````````````$H```````````````````````````````!````````
-+M``````!0`````0`````````````````````````````!*`````````!:````
-+M`````````````````0``````````````2P````0`````````````````````
-+M````````"O``````````&````!(````(``````````@`````````&````&$`
-+M```!``````````````````````````````&"`````````),`````````````
-+M```````!``````````````!<````!``````````````````````````````+
-+M"`````````!@````$@````H`````````"``````````8````;0````$`````
-+M`````````````````````````A4`````````%`````````````````````$`
-+M`````````````(`````!``````````````````````````````(P````````
-+M`#`````````````````````0``````````````![````!```````````````
-+M```````````````+:``````````P````$@````T`````````"``````````8
-+M````E`````$``````````@```````````````````F``````````2```````
-+M``````````````@``````````````(\````$````````````````````````
-+M``````N8`````````!@````2````#P`````````(`````````!@````1````
-+M`P`````````````````````````````"J`````````">````````````````
-+M`````0```````````````0````(`````````````````````````````"$@`
-+M```````!L````!,````+``````````@`````````&`````D````#````````
-+M``````````````````````GX`````````'H````````````````````!````
-+M`````````````````````````````````````````````P```0``````````
-+M`````````````````P```P```````````````````````````P``!```````
-+M`````````````````````P``!0```````````````````````````P``"@``
-+M`````````````````````````P``#````````````````````````````P``
-+M"````````````````````````````P``#0``````````````````````````
-+M`P``#P```````````````````````````P``!P``````````````````````
-+M```!$@``!0```````````````````-@````*$@```0`````````,````````
-+M`#`````@$``````````````````````````````P$```````````````````
-+M``````````!*$`````````````````````````````!E(@``!0``````````
-+M`````````-@```!S(@``!0```````````````````-@`7U]S96QE8W0`7U]?
-+M;F5W<V5L96-T7VYO8V%N8V5L`%]?<WES8V%L;%]E<G)O<@!?7VQI8F-?96YA
-+M8FQE7V%S>6YC8V%N8V5L`%]?;&EB8U]D:7-A8FQE7V%S>6YC8V%N8V5L`%]?
-+M;&EB8U]S96QE8W0`<V5L96-T```````````````````D````#0````H`````
-+M``````````````!<````#@````H```````````````````"4````#P````H`
-+M`````````````````````````0```"8````````````````````(````````
-+M`#,```````````````````!&`````0```"8````````````````````&````
-+M!@````$````````````````````,````!P````$````````````````````0
-+M`````0```"8````````````````````8`````0```"8`````````V```````
-+M```&````!0````$````````````````````0`````0```"8`````````````
-+6```````<`````0```!H`````````````
-+`
-+end
-diff --git a/gdb/testsuite/gdb.arch/s390x-prologue-skip.exp b/gdb/testsuite/gdb.arch/s390x-prologue-skip.exp
-new file mode 100644
---- /dev/null
-+++ b/gdb/testsuite/gdb.arch/s390x-prologue-skip.exp
-@@ -0,0 +1,34 @@
-+# Copyright 2015 Free Software Foundation, Inc.
-+
-+# This program is free software; you can redistribute it and/or modify
-+# it under the terms of the GNU General Public License as published by
-+# the Free Software Foundation; either version 3 of the License, or
-+# (at your option) any later version.
-+#
-+# This program is distributed in the hope that it will be useful,
-+# but WITHOUT ANY WARRANTY; without even the implied warranty of
-+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-+# GNU General Public License for more details.
-+#
-+# You should have received a copy of the GNU General Public License
-+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-+
-+if { ![istarget s390x-*linux-*] || ![is_lp64_target] } {
-+    verbose "Skipping s390x-prologue-skip.exp"
-+    return
-+}
-+
-+set testfile "s390x-prologue-skip"
-+set uufile "${srcdir}/${subdir}/${testfile}.o.uu"
-+set ofile "${srcdir}/${subdir}/${testfile}.o"
-+
-+if { [catch "system \"uudecode -o ${ofile} ${uufile}\"" ] != 0 } {
-+    untested "failed uudecode"
-+    return -1
-+}
-+
-+gdb_exit
-+gdb_start
-+gdb_load $ofile
-+
-+gdb_test "break select" "Breakpoint $decimal at 0x48: file ../sysdeps/unix/syscall-template.S, line 81." "breakpoint on select"
-diff --git a/gdb/testsuite/gdb.arch/s390x-prologue-skip.o.uu b/gdb/testsuite/gdb.arch/s390x-prologue-skip.o.uu
-new file mode 100644
---- /dev/null
-+++ b/gdb/testsuite/gdb.arch/s390x-prologue-skip.o.uu
-@@ -0,0 +1,64 @@
-+begin 644 s390x-prologue-skip.o.uu
-+M?T5,1@("`0`````````````!`!8````!````````````````````````````
-+M``+```````!```````!``!(`#^LE\!``).O?\&@`)+D$`.^G^_]@X^#P```D
-+MP.4`````N00``NLE\+``!`J.N00`TKD$`"#`Y0````"Y!``MZ]_Q"``$I_0`
-+M"L`0`````+\/$`"G=/_7"HZG2?`!N2$`),"T``````?^````5@`"````.0$!
-+M^PX-``$!`0$````!```!+BXO<WES9&5P<R]U;FEX``!S>7-C86QL+71E;7!L
-+M871E+E,``0`````)`@```````````]```0)F$P("``$!````CP`"``````@!
-+M```````````````````````````N+B]S>7-D97!S+W5N:7@O<WES8V%L;"UT
-+M96UP;&%T92Y3`"]R;V]T+V=L:6)C+V=L:6)C+3(N,3<M-S@N96PW+G-R8R]G
-+M;&EB8RTR+C$W+6,W-3AA-C@V+VUI<V,`1TY5($%3(#(N,C,N-3(N,"XQ`(`!
-+M`1$`$`81`1(!`P@;""4($P4`````````````````+``"``````@`````````
-+M`````````````````&@`````````````````````````%``````!>E(``7@.
-+M`1L,#Z`!````````&````!P`````````1`!,CP6.!HT'2`[``@```!`````X
-+M`````````"```````"YS>6UT86(`+G-T<G1A8@`N<VAS=')T86(`+G)E;&$N
-+M=&5X=``N9&%T80`N8G-S`"YN;W1E+D=.52US=&%C:P`N<F5L82YD96)U9U]L
-+M:6YE`"YR96QA+F1E8G5G7VEN9F\`+F1E8G5G7V%B8G)E=@`N<F5L82YD96)U
-+M9U]A<F%N9V5S`"YR96QA+F5H7V9R86UE````````````````````````````
-+M````````````````````````````````````````````````````````````
-+M````````(`````$`````````!@```````````````````$``````````:```
-+M``````````````````0``````````````!L````$````````````````````
-+M``````````F``````````&`````0`````0`````````(`````````!@````F
-+M`````0`````````#````````````````````J```````````````````````
-+M````````!```````````````+`````@``````````P``````````````````
-+M`*@```````````````````````````````0``````````````#$````!````
-+M``````````````````````````"H```````````````````````````````!
-+M``````````````!&`````0``````````````````````````````J```````
-+M``!:`````````````````````0``````````````00````0`````````````
-+M````````````````">``````````&````!`````&``````````@`````````
-+M&````%<````!``````````````````````````````$"`````````),`````
-+M```````````````!``````````````!2````!```````````````````````
-+M```````)^`````````!@````$`````@`````````"``````````8````8P``
-+M``$``````````````````````````````94`````````%```````````````
-+M``````$``````````````'8````!``````````````````````````````&P
-+M`````````#`````````````````````0``````````````!Q````!```````
-+M```````````````````````*6``````````P````$`````L`````````"```
-+M```````8````B@````$``````````@```````````````````>``````````
-+M2`````````````````````@``````````````(4````$````````````````
-+M``````````````J(`````````#`````0````#0`````````(`````````!@`
-+M```1`````P`````````````````````````````"*`````````"4````````
-+M`````````````0```````````````0````(`````````````````````````
-+M````!T`````````!L````!$````*``````````@`````````&`````D````#
-+M``````````````````````````````CP`````````(X`````````````````
-+M```!`````````````````````````````````````````````````P```0``
-+M`````````````````````````P```P```````````````````````````P``
-+M!````````````````````````````P``"```````````````````````````
-+M`P``"@```````````````````````````P``!@``````````````````````
-+M`````P``"P```````````````````````````P``#0``````````````````
-+M`````````P``!0`````````````````````````!$```````````````````
-+M```````````;$``````````````````````````````V$@```0````````!(
-+M`````````"`````_$`````````````````````````````!7$@```0``````
-+M``!6`````````!````!I$`````````````````````````````!Y(@```0``
-+M``````!(`````````"````"'(@```0````````!(`````````"``7U]L:6)C
-+M7V5N86)L95]A<WEN8V-A;F-E;`!?7VQI8F-?9&ES86)L95]A<WEN8V-A;F-E
-+M;`!?7W-E;&5C=`!?7VQI8F-?;75L=&EP;&5?=&AR96%D<P!?7W-E;&5C=%]N
-+M;V-A;F-E;`!?7W-Y<V-A;&Q?97)R;W(`7U]L:6)C7W-E;&5C=`!S96QE8W0`
-+M````````````'`````H````3``````````(`````````-@````L````3````
-+M``````(`````````2@````T````3``````````(`````````8@````\````3
-+M``````````(`````````1@````$````6````````````````````!@````4`
-+M```$````````````````````#`````8````$````````````````````$```
-+M``$````6````````````````````&`````$````6`````````&@`````````
-+M!@````0````$````````````````````$`````$````6````````````````
-+L````(`````$````%````````````````````/`````$````%`````````$@`
-+`
-+end

diff --git a/gdb.spec b/gdb.spec
index 10a7aa4..5834d16 100644
--- a/gdb.spec
+++ b/gdb.spec
@@ -923,6 +923,11 @@ fi
 # endif scl
 
 %changelog
+* Thu Mar 06 2025 Kevin Buettner <kevinb@redhat.com>
+- Remove gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch.
+  The upstream test 'gdb.arch/amd64-prologue-skip.exp' should be
+  sufficient for testing an upstream fix which was pushed in 2015.
+
 * Wed Mar 05 2025 Guinevere Larsen <guinevere@redhat.com>
 - Remove gdb-6.5-gcore-buffer-limit-test.patch. A similar test has been
   added upstream, which will trickle down soon.

                 reply	other threads:[~2026-06-28  0:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178260492614.1.3765144111028470708.rpms-gdb-a65de0f14d05@fedoraproject.org \
    --to=kevinb@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox