[rpms/gdb] gdb-17.2-rebase-f44: Remove gdb-6.5-bz243845-stale-testing-zombie-test.patch

[Kevin Buettner <kevinb@redhat.com>]

            A new commit has been pushed.

            Repo   : rpms/gdb
            Branch : gdb-17.2-rebase-f44
            Commit : a2f2e9ec887ad1f7c4b0ff2436cf07d2d8ec840e
            Author : Kevin Buettner <kevinb@redhat.com>
            Date   : 2024-11-14T11:33:08-07:00
            Stats  : +22/-112 in 5 file(s)
            URL    : https://src.fedoraproject.org/rpms/gdb/c/a2f2e9ec887ad1f7c4b0ff2436cf07d2d8ec840e?branch=gdb-17.2-rebase-f44

            Log:
            Remove gdb-6.5-bz243845-stale-testing-zombie-test.patch

This was a test for a fix to a function that was named
linux_test_for_tracefork - it was removed in 2022 in upstream commit
a288518611d.

The bug associated with this patch was RHBZ 243845:

https://bugzilla.redhat.com/show_bug.cgi?id=243845

The fix, made by Nick Roberts in 2006, added a call to waitpid() (via
a wrapper named my_waitpid) to linux_test_for_tracefork.  That call
to waitpid() reaped a zombie after a fork call.  The purpose of the
now removed function was to determine whether the PTRACE_O_TRACEFORK
facility is available in the running kernel.  This function was
removed by Simon Marchi because this facility has, in 2022, been in
the Linux kernel for a long time.

Since the function in question has been entirely removed without
migrating it's functionality elsewhere, this test, which made sure
that the zombie was being reaped, is no longer useful.

It may be worthwhile to test other scenarios for zombies, but such
tests can be written and added as bugs are found and fixed.

---
diff --git a/_gdb.spec.Patch.include b/_gdb.spec.Patch.include
index 16b5c94..0f6cac1 100644
--- a/_gdb.spec.Patch.include
+++ b/_gdb.spec.Patch.include
@@ -14,67 +14,63 @@ Patch003: gdb-6.5-bz218379-ppc-solib-trampoline-test.patch
 #=fedoratest
 Patch004: gdb-6.6-bz237572-ppc-atomic-sequence-test.patch
 
-# Test leftover zombie process (BZ 243845).
-#=fedoratest
-Patch005: gdb-6.5-bz243845-stale-testing-zombie-test.patch
-
 # New locating of the matching binaries from the pure core file (build-id).
 #=push+jan
-Patch006: gdb-6.6-buildid-locate.patch
+Patch005: gdb-6.6-buildid-locate.patch
 
 # Fix loading of core files without build-ids but with build-ids in executables.
 # Load strictly build-id-checked core files only if no executable is specified
 # (Jan Kratochvil, RH BZ 1339862).
 #=push+jan
-Patch007: gdb-6.6-buildid-locate-solib-missing-ids.patch
+Patch006: gdb-6.6-buildid-locate-solib-missing-ids.patch
 
 # Test gcore memory and time requirements for large inferiors.
 #=fedoratest
-Patch008: gdb-6.5-gcore-buffer-limit-test.patch
+Patch007: gdb-6.5-gcore-buffer-limit-test.patch
 
 # Test GCORE for shmid 0 shared memory mappings.
 #=fedoratest: But it is broken anyway, sometimes the case being tested is not reproducible.
-Patch009: gdb-6.3-mapping-zero-inode-test.patch
+Patch008: gdb-6.3-mapping-zero-inode-test.patch
 
 # Fix resolving of variables at locations lists in prelinked libs (BZ 466901).
 #=fedoratest
-Patch010: gdb-6.8-bz466901-backtrace-full-prelinked.patch
+Patch009: gdb-6.8-bz466901-backtrace-full-prelinked.patch
 
 # Fix follow-exec for C++ programs (bugreported by Martin Stransky).
 #=fedoratest
-Patch011: gdb-archer-next-over-throw-cxx-exec.patch
+Patch010: gdb-archer-next-over-throw-cxx-exec.patch
 
 # [delayed-symfile] Test a backtrace regression on CFIs without DIE (BZ 614604).
 #=fedoratest
-Patch012: gdb-test-bt-cfi-without-die.patch
+Patch011: gdb-test-bt-cfi-without-die.patch
 
 # Testcase for `Setting solib-absolute-prefix breaks vDSO' (BZ 818343).
 #=fedoratest
-Patch013: gdb-rhbz-818343-set-solib-absolute-prefix-testcase.patch
+Patch012: gdb-rhbz-818343-set-solib-absolute-prefix-testcase.patch
 
 # Fix 'gdb gives highly misleading error when debuginfo pkg is present,
 # but not corresponding binary pkg' (RH BZ 981154).
 #=push+jan
-Patch014: gdb-6.6-buildid-locate-misleading-warning-missing-debuginfo-rhbz981154.patch
+Patch013: gdb-6.6-buildid-locate-misleading-warning-missing-debuginfo-rhbz981154.patch
 
 # Testcase for '[SAP] Recursive dlopen causes SAP HANA installer to
 # crash.' (RH BZ 1156192).
 #=fedoratest
-Patch015: gdb-rhbz1156192-recursive-dlopen-test.patch
+Patch014: gdb-rhbz1156192-recursive-dlopen-test.patch
 
 # Fix '`catch syscall' doesn't work for parent after `fork' is called'
 # (Philippe Waroquiers, RH BZ 1149205).
 #=fedoratest
-Patch016: gdb-rhbz1149205-catch-syscall-after-fork-test.patch
+Patch015: gdb-rhbz1149205-catch-syscall-after-fork-test.patch
 
 # Fix '[ppc64] and [s390x] wrong prologue skip on -O2 -g code' (Jan
 # Kratochvil, RH BZ 1084404).
 #=fedoratest
-Patch017: gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch
+Patch016: gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch
 
 # [aarch64] Fix hardware watchpoints (RH BZ 1261564).
 #=fedoratest
-Patch018: gdb-rhbz1261564-aarch64-hw-watchpoint-test.patch
+Patch017: gdb-rhbz1261564-aarch64-hw-watchpoint-test.patch
 
 # Update gdb-add-index.sh such that, when the GDB environment
 # variable is not set, the script is smarter than just looking for
@@ -88,15 +84,15 @@ Patch018: gdb-rhbz1261564-aarch64-hw-watchpoint-test.patch
 #   https://fedoraproject.org/wiki/Changes/Minimal_GDB_in_buildroot
 #
 #=fedora
-Patch019: gdb-add-index.patch
+Patch018: gdb-add-index.patch
 
 # Backport upstream commit 7db795bc67a.
-Patch020: gdb-remove-use-of-py-isascii
+Patch019: gdb-remove-use-of-py-isascii
 
 # Not a backport.  Add a new script which hooks into GDB and suggests
 # RPMs to install when GDB finds an objfile with no debug info.
-Patch021: gdb-add-rpm-suggestion-script.patch
+Patch020: gdb-add-rpm-suggestion-script.patch
 
 
-Patch022: gdb-catchpoint-re-set.patch
+Patch021: gdb-catchpoint-re-set.patch
 

diff --git a/_gdb.spec.patch.include b/_gdb.spec.patch.include
index 09361bf..2799cc4 100644
--- a/_gdb.spec.patch.include
+++ b/_gdb.spec.patch.include
@@ -19,4 +19,3 @@
 %patch -p1 -P019
 %patch -p1 -P020
 %patch -p1 -P021
-%patch -p1 -P022

diff --git a/_patch_order b/_patch_order
index 4bd22a2..d2afeab 100644
--- a/_patch_order
+++ b/_patch_order
@@ -2,7 +2,6 @@ gdb-6.3-rh-testversion-20041202.patch
 gdb-6.3-gstack-20050411.patch
 gdb-6.5-bz218379-ppc-solib-trampoline-test.patch
 gdb-6.6-bz237572-ppc-atomic-sequence-test.patch
-gdb-6.5-bz243845-stale-testing-zombie-test.patch
 gdb-6.6-buildid-locate.patch
 gdb-6.6-buildid-locate-solib-missing-ids.patch
 gdb-6.5-gcore-buffer-limit-test.patch

diff --git a/gdb-6.5-bz243845-stale-testing-zombie-test.patch b/gdb-6.5-bz243845-stale-testing-zombie-test.patch
deleted file mode 100644
index 2d62949..0000000
--- a/gdb-6.5-bz243845-stale-testing-zombie-test.patch
+++ /dev/null
@@ -1,89 +0,0 @@
-From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
-From: Fedora GDB patches <invalid@email.com>
-Date: Fri, 27 Oct 2017 21:07:50 +0200
-Subject: gdb-6.5-bz243845-stale-testing-zombie-test.patch
-
-;; Test leftover zombie process (BZ 243845).
-;;=fedoratest
-
-diff --git a/gdb/testsuite/gdb.base/tracefork-zombie.exp b/gdb/testsuite/gdb.base/tracefork-zombie.exp
-new file mode 100644
---- /dev/null
-+++ b/gdb/testsuite/gdb.base/tracefork-zombie.exp
-@@ -0,0 +1,76 @@
-+# Copyright 2007 Free Software Foundation, Inc.
-+
-+# This program is free software; you can redistribute it and/or modify
-+# it under the terms of the GNU General Public License as published by
-+# the Free Software Foundation; either version 2 of the License, or
-+# (at your option) any later version.
-+#
-+# This program is distributed in the hope that it will be useful,
-+# but WITHOUT ANY WARRANTY; without even the implied warranty of
-+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-+# GNU General Public License for more details.
-+#
-+# You should have received a copy of the GNU General Public License
-+# along with this program; if not, write to the Free Software
-+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  */
-+
-+# are we on a target board
-+if {[use_gdb_stub]} {
-+    untested "skipping test because of use_gdb_stub"
-+    return -1
-+}
-+
-+# Start the program running and then wait for a bit, to be sure
-+# that it can be attached to.
-+
-+gdb_exit
-+gdb_start
-+gdb_load sleep
-+
-+set gdb_pid [exp_pid -i [board_info host fileid]]
-+set test "identified the child GDB"
-+if {$gdb_pid != "" && $gdb_pid > 0} {
-+    pass $test
-+    verbose -log "Child GDB PID $gdb_pid"
-+} else {
-+    fail $test
-+}
-+
-+set testpid [eval exec sleep 10 &]
-+exec sleep 2
-+
-+set test "attach"
-+gdb_test_multiple "attach $testpid" "$test" {
-+    -re "Attaching to program.*`?.*'?, process $testpid..*$gdb_prompt $" {
-+	pass "$test"
-+    }
-+    -re "Attaching to program.*`?.*\.exe'?, process $testpid.*\[Switching to thread $testpid\..*\].*$gdb_prompt $" {
-+	# Response expected on Cygwin
-+	pass "$test"
-+    }
-+}
-+
-+# Some time to let GDB spawn its testing child.
-+exec sleep 2
-+
-+set found none
-+foreach procpid [glob -directory /proc -type d {[0-9]*}] {
-+    if {[catch {open $procpid/status} statusfi]} {
-+	continue
-+    }
-+    set status [read $statusfi]
-+    close $statusfi
-+    if {1
-+         && [regexp -line {^Name:\tgdb$} $status]
-+         && [regexp -line {^PPid:\t1$} $status]
-+         && [regexp -line "^TracerPid:\t$gdb_pid$" $status]} {
-+	set found $procpid
-+	verbose -log "Found linux_test_for_tracefork zombie PID $procpid"
-+    }
-+}
-+set test "linux_test_for_tracefork leaves no zombie"
-+if {$found eq {none}} {
-+    pass $test
-+} else {
-+    fail $test
-+}

diff --git a/gdb.spec b/gdb.spec
index 1336095..3bbc87f 100644
--- a/gdb.spec
+++ b/gdb.spec
@@ -928,6 +928,11 @@ fi
 # endif scl
 
 %changelog
+* Thu Nov 14 2024 Kevin Buettner <kevinb@redhat.com>
+- Remove gdb-6.5-bz243845-stale-testing-zombie-test.patch.  This was a
+  test for a fix to a function that was named linux_test_for_tracefork,
+  which was removed in 2022 in upstream commit a288518611d.
+
 * Wed Nov 13 2024 Alexandra Hájková <ahajkova@redhat.com>
 - Remove upstreamed (21dc8b8d287) gdb-test-dw2-aranges.patch.