[rpms/gdb] gdb-17.2-rebase-f44: Remove gdb-core-open-vdso-warning.patch

[Kevin Buettner <kevinb@redhat.com>]

            A new commit has been pushed.

            Repo   : rpms/gdb
            Branch : gdb-17.2-rebase-f44
            Commit : a2474061b215d9e4c9b307338e76f98137c60d46
            Author : Kevin Buettner <kevinb@redhat.com>
            Date   : 2024-06-18T18:07:12-07:00
            Stats  : +38/-99 in 5 file(s)
            URL    : https://src.fedoraproject.org/rpms/gdb/c/a2474061b215d9e4c9b307338e76f98137c60d46?branch=gdb-17.2-rebase-f44

            Log:
            Remove gdb-core-open-vdso-warning.patch

The tests added by this patch are similar to those of upstream test
gdb.base/vdso-warning.exp.  I think that the upstream patch provides
better coverage in that it also provides tests involving core files.

This patch started out as a change to gdb in Jan 2010 changing
gdb/solib-svr4.c.  There were no tests included in this initial
commit.

Tests were added in a commit from June 19, 2012, changing files
gdb.base/solib-symbol.exp and gdb.base/corefile.exp.  There were also
changes made to gdb/solib.c.

Tweaks to the test cases were made in commits from July 3, 2012,
July 6, 2012, and Jan 19, 2013.

Many, maybe all, of the solib-svr4.c and solib.c changes were
removed in a commit from Feb 7, 2014.  The gdb.base/corefile.exp
changes were removed at the same time.  There is no explanation
in the log for why this was done.  However, after reading some
gdb-patches discussion from that period, it appears that Jan
believed that the correct fix was in glibc and that having a
workaround in gdb weakened the argument for what he believed
to be a proper fix in glibc.  Roland McGrath and Ulrich Drepper
disagreed with Jan regarding his proposed glibc change (from 2009).

An upstream ChangeLog entry from Oct 2014 shows that Jan and Pedro
added upstream test gdb.base/vdso-warning.exp.  Also, at that time,
new code was added to GDB for handling the vdso problem.  See
upstream PR 14466:

  https://sourceware.org/bugzilla/show_bug.cgi?id=14466)

All further/subsequent changes to the local patch
gdb-core-open-vdso-warning.patch are rebase related.

Bottom line is that the remaining tests in gdb.base/solib-symbol.exp
are covered by an existing upstream test.  The upstream test also
handles the core file case which had also once been handled by this
local test.

---
diff --git a/_gdb.spec.Patch.include b/_gdb.spec.Patch.include
index 84e1966..4d42546 100644
--- a/_gdb.spec.Patch.include
+++ b/_gdb.spec.Patch.include
@@ -60,63 +60,58 @@ Patch014: gdb-6.8-bz466901-backtrace-full-prelinked.patch
 #=fedoratest
 Patch015: gdb-simultaneous-step-resume-breakpoint-test.patch
 
-# Fix GNU/Linux core open: Can't read pathname for load map: Input/output error.
-# Fix regression of undisplayed missing shared libraries caused by a fix for.
-#=fedoratest: It should be in glibc: libc-alpha: <20091004161706.GA27450@.*>
-Patch016: gdb-core-open-vdso-warning.patch
-
 # Fix follow-exec for C++ programs (bugreported by Martin Stransky).
 #=fedoratest
-Patch017: gdb-archer-next-over-throw-cxx-exec.patch
+Patch016: gdb-archer-next-over-throw-cxx-exec.patch
 
 # [delayed-symfile] Test a backtrace regression on CFIs without DIE (BZ 614604).
 #=fedoratest
-Patch018: gdb-test-bt-cfi-without-die.patch
+Patch017: gdb-test-bt-cfi-without-die.patch
 
 # [archer-tromey-delayed-symfile] New test gdb.dwarf2/dw2-aranges.exp.
 #=fedoratest
-Patch019: gdb-test-dw2-aranges.patch
+Patch018: gdb-test-dw2-aranges.patch
 
 # Workaround PR libc/14166 for inferior calls of strstr.
 #=fedoratest: Compatibility with RHELs (unchecked which ones).
-Patch020: gdb-glibc-strstr-workaround.patch
+Patch019: gdb-glibc-strstr-workaround.patch
 
 # Testcase for `Setting solib-absolute-prefix breaks vDSO' (BZ 818343).
 #=fedoratest
-Patch021: gdb-rhbz-818343-set-solib-absolute-prefix-testcase.patch
+Patch020: gdb-rhbz-818343-set-solib-absolute-prefix-testcase.patch
 
 # Import regression test for `gdb/findvar.c:417: internal-error:
 # read_var_value: Assertion `frame' failed.' (RH BZ 947564) from RHEL 6.5.
 #=fedoratest
-Patch022: gdb-rhbz947564-findvar-assertion-frame-failed-testcase.patch
+Patch021: gdb-rhbz947564-findvar-assertion-frame-failed-testcase.patch
 
 # Fix 'memory leak in infpy_read_memory()' (RH BZ 1007614)
 #=fedoratest
-Patch023: gdb-rhbz1007614-memleak-infpy_read_memory-test.patch
+Patch022: gdb-rhbz1007614-memleak-infpy_read_memory-test.patch
 
 # Fix 'gdb gives highly misleading error when debuginfo pkg is present,
 # but not corresponding binary pkg' (RH BZ 981154).
 #=push+jan
-Patch024: gdb-6.6-buildid-locate-misleading-warning-missing-debuginfo-rhbz981154.patch
+Patch023: gdb-6.6-buildid-locate-misleading-warning-missing-debuginfo-rhbz981154.patch
 
 # Testcase for '[SAP] Recursive dlopen causes SAP HANA installer to
 # crash.' (RH BZ 1156192).
 #=fedoratest
-Patch025: gdb-rhbz1156192-recursive-dlopen-test.patch
+Patch024: gdb-rhbz1156192-recursive-dlopen-test.patch
 
 # Fix '`catch syscall' doesn't work for parent after `fork' is called'
 # (Philippe Waroquiers, RH BZ 1149205).
 #=fedoratest
-Patch026: gdb-rhbz1149205-catch-syscall-after-fork-test.patch
+Patch025: gdb-rhbz1149205-catch-syscall-after-fork-test.patch
 
 # Fix '[ppc64] and [s390x] wrong prologue skip on -O2 -g code' (Jan
 # Kratochvil, RH BZ 1084404).
 #=fedoratest
-Patch027: gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch
+Patch026: gdb-rhbz1084404-ppc64-s390x-wrong-prologue-skip-O2-g-3of3.patch
 
 # [aarch64] Fix hardware watchpoints (RH BZ 1261564).
 #=fedoratest
-Patch028: gdb-rhbz1261564-aarch64-hw-watchpoint-test.patch
+Patch027: gdb-rhbz1261564-aarch64-hw-watchpoint-test.patch
 
 # Update gdb-add-index.sh such that, when the GDB environment
 # variable is not set, the script is smarter than just looking for
@@ -130,75 +125,75 @@ Patch028: gdb-rhbz1261564-aarch64-hw-watchpoint-test.patch
 #   https://fedoraproject.org/wiki/Changes/Minimal_GDB_in_buildroot
 #
 #=fedora
-Patch029: gdb-add-index.patch
+Patch028: gdb-add-index.patch
 
 # Back-port upstream commit 1f0fab7ff86 as part of a fix for
 # non-deterministic gdb-index generation (RH BZ 2232086).
-Patch030: gdb-rhbz2232086-refactor-selftest-support.patch
+Patch029: gdb-rhbz2232086-refactor-selftest-support.patch
 
 # Back-port upstream commit aa19bc1d259 as part of a fix for
 # non-deterministic gdb-index generation (RH BZ 2232086).
-Patch031: gdb-rhbz-2232086-reduce-size-of-gdb-index.patch
+Patch030: gdb-rhbz-2232086-reduce-size-of-gdb-index.patch
 
 # Back-port upstream commit acc117b57f7 as part of a fix for
 # non-deterministic gdb-index generation (RH BZ 2232086).
-Patch032: gdb-rhbz-2232086-cpp-ify-mapped-symtab.patch
+Patch031: gdb-rhbz-2232086-cpp-ify-mapped-symtab.patch
 
 # Back-port upstream commit aff250145af as part of a fix for
 # non-deterministic gdb-index generation (RH BZ 2232086).
-Patch033: gdb-rhbz-2232086-generate-gdb-index-consistently.patch
+Patch032: gdb-rhbz-2232086-generate-gdb-index-consistently.patch
 
 # Back-port upstream commit 3644f41dc80 as part of a fix for
 # non-deterministic gdb-index generation (RH BZ 2232086).
-Patch034: gdb-rhbz-2232086-generate-dwarf-5-index-consistently.patch
+Patch033: gdb-rhbz-2232086-generate-dwarf-5-index-consistently.patch
 
 
-Patch035: gdb-rhbz2250652-gdbpy_gil.patch
+Patch034: gdb-rhbz2250652-gdbpy_gil.patch
 
 
-Patch036: gdb-rhbz2250652-avoid-PyOS_ReadlineTState.patch
+Patch035: gdb-rhbz2250652-avoid-PyOS_ReadlineTState.patch
 
 
-Patch037: gdb-ftbs-swapped-calloc-args.patch
+Patch036: gdb-ftbs-swapped-calloc-args.patch
 
 # Backport upstream workaround for GCC 14 problem which cause assertion
 # failures in GDB.
-Patch038: gdb-rhbz2261580-intrusive_list-assertion-fix.patch
+Patch037: gdb-rhbz2261580-intrusive_list-assertion-fix.patch
 
 # Backport upstream commit 7628a997f27.
-Patch039: gdb-sync-coffread-with-elfread.patch
+Patch038: gdb-sync-coffread-with-elfread.patch
 
 # Backport upstream commit 27807da5849.
-Patch040: gdb-merge-debug-symbol-lookup.patch
+Patch039: gdb-merge-debug-symbol-lookup.patch
 
 # Backport upstream commit 6234ba17598.
-Patch041: gdb-refactor-find-and-add-separate-symbol-file.patch
+Patch040: gdb-refactor-find-and-add-separate-symbol-file.patch
 
 # Backport upstream commit 661d98a3331.
-Patch042: gdb-add-missing-debug-ext-lang-hook.patch
+Patch041: gdb-add-missing-debug-ext-lang-hook.patch
 
 # Backport upstream commit 8f6c452b5a4.
-Patch043: gdb-add-missing-debug-info-python-hook.patch
+Patch042: gdb-add-missing-debug-info-python-hook.patch
 
 # Backport upstream commit 7db795bc67a.
-Patch044: gdb-remove-use-of-py-isascii
+Patch043: gdb-remove-use-of-py-isascii
 
 # Backport upstream commit 1146d27749f.
-Patch045: gdb-remove-path-in-test-name.patch
+Patch044: gdb-remove-path-in-test-name.patch
 
 # Backport upstream commit e8c3dafa5f5.
-Patch046: gdb-do-not-import-py-curses-ascii-module.patch
+Patch045: gdb-do-not-import-py-curses-ascii-module.patch
 
 # Backport upstream commit dd5516bf98f.
-Patch047: gdb-reformat-missing-debug-py-file.patch
+Patch046: gdb-reformat-missing-debug-py-file.patch
 
 # Backport upstream commit 7d21600b31fe.
-Patch048: gdb-handle-no-python-gdb-module.patch
+Patch047: gdb-handle-no-python-gdb-module.patch
 
 # Not a backport.  Add a new script which hooks into GDB and suggests
 # RPMs to install when GDB finds an objfile with no debug info.
-Patch049: gdb-add-rpm-suggestion-script.patch
+Patch048: gdb-add-rpm-suggestion-script.patch
 
 # Update x86 disassembler
-Patch050: gdb-rhbz2277160-apx-disasm.patch
+Patch049: gdb-rhbz2277160-apx-disasm.patch
 

diff --git a/_gdb.spec.patch.include b/_gdb.spec.patch.include
index f84adba..2ca0c1f 100644
--- a/_gdb.spec.patch.include
+++ b/_gdb.spec.patch.include
@@ -47,4 +47,3 @@
 %patch -p1 -P047
 %patch -p1 -P048
 %patch -p1 -P049
-%patch -p1 -P050

diff --git a/_patch_order b/_patch_order
index 7f709c2..f68103d 100644
--- a/_patch_order
+++ b/_patch_order
@@ -13,7 +13,6 @@ gdb-6.3-mapping-zero-inode-test.patch
 gdb-6.5-section-num-fixup-test.patch
 gdb-6.8-bz466901-backtrace-full-prelinked.patch
 gdb-simultaneous-step-resume-breakpoint-test.patch
-gdb-core-open-vdso-warning.patch
 gdb-archer-next-over-throw-cxx-exec.patch
 gdb-test-bt-cfi-without-die.patch
 gdb-test-dw2-aranges.patch

diff --git a/gdb-core-open-vdso-warning.patch b/gdb-core-open-vdso-warning.patch
deleted file mode 100644
index fdd06fb..0000000
--- a/gdb-core-open-vdso-warning.patch
+++ /dev/null
@@ -1,58 +0,0 @@
-From FEDORA_PATCHES Mon Sep 17 00:00:00 2001
-From: Fedora GDB patches <invalid@email.com>
-Date: Fri, 27 Oct 2017 21:07:50 +0200
-Subject: gdb-core-open-vdso-warning.patch
-
-;; Fix GNU/Linux core open: Can't read pathname for load map: Input/output error.
-;; Fix regression of undisplayed missing shared libraries caused by a fix for.
-;;=fedoratest: It should be in glibc: libc-alpha: <20091004161706.GA27450@.*>
-
-http://sourceware.org/ml/gdb-patches/2009-10/msg00142.html
-Subject: [patch] Fix GNU/Linux core open: Can't read pathname for load map:  Input/output error.
-
-[ New patch variant.  ]
-
-commit 7d760051ffb8a23cdc51342d4e6243fbc462f73f
-Author: Ulrich Weigand <uweigand@de.ibm.com>
-Date:   Wed Sep 25 11:52:50 2013 +0000
-
-diff --git a/gdb/testsuite/gdb.base/solib-symbol.exp b/gdb/testsuite/gdb.base/solib-symbol.exp
---- a/gdb/testsuite/gdb.base/solib-symbol.exp
-+++ b/gdb/testsuite/gdb.base/solib-symbol.exp
-@@ -27,6 +27,7 @@ set testfile "solib-symbol-main"
- set srcfile ${srcdir}/${subdir}/${testfile}.c
- set binfile [standard_output_file ${testfile}]
- set bin_flags [list debug shlib=${binfile_lib}]
-+set executable ${testfile}
- 
- if { [gdb_compile_shlib ${srcfile_lib} ${binfile_lib} $lib_flags] != ""
-      || [gdb_compile ${srcfile} ${binfile} executable $bin_flags] != "" } {
-@@ -61,4 +62,28 @@ gdb_test "br foo2" \
- 	 "Breakpoint.*: foo2. .2 locations..*" \
- 	 "foo2 in mdlib"
- 
-+# Test GDB warns for shared libraris which have not been found.
-+
-+gdb_test "info sharedlibrary" "/${libname}.*"
-+
-+clean_restart ${executable}
-+gdb_breakpoint "main"
-+gdb_run_cmd
-+set test "no warning for missing libraries"
-+gdb_test_multiple "" $test {
-+    -re "warning: Could not load shared library symbols for \[0-9\]+ libraries,.*\r\n$gdb_prompt $" {
-+	fail $test
-+    }
-+    -re "Breakpoint \[0-9\]+, main .*\r\n$gdb_prompt $" {
-+	pass $test
-+    }
-+}
-+
-+clean_restart ${executable}
-+gdb_test_no_output "set solib-absolute-prefix /doESnotEXIST"
-+gdb_breakpoint "main"
-+gdb_run_cmd
-+gdb_test "" "warning: Could not load shared library symbols for \[0-9\]+ libraries,.*\r\nBreakpoint \[0-9\]+, main .*" \
-+	 "warning for missing libraries"
-+
- gdb_exit

diff --git a/gdb.spec b/gdb.spec
index 9fd356f..38ee314 100644
--- a/gdb.spec
+++ b/gdb.spec
@@ -926,6 +926,10 @@ fi
 # endif scl
 
 %changelog
+* Tue Jun 18 2024 Kevin Buettner <kevinb@redhat.com>
+- Remove gdb-core-open-vdso-warning.patch.  This tests added by this
+  patch are similar to those of upstream test gdb.base/vdso-warning.exp.
+
 * Tue Jun 18 2024 Kevin Buettner <kevinb@redhat.com> - 14.2-12
 - Revise rpm-suggestions.py script so that message regarding
   a not-found 'rpm' module is output to stderr.  (RHBZ 2275274)