public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/gdb] gdb-17.2-rebase-f44: Backport a fix for clang && -gsplit-dwarf debuggees (RH BZ 1482892).
Date: Sat, 27 Jun 2026 23:58:18 GMT	[thread overview]
Message-ID: <178260469899.1.7556767937072981047.rpms-gdb-99b34dc7843b@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/gdb
Branch : gdb-17.2-rebase-f44
Commit : 99b34dc7843b09667bc4cc8e81ed6934d683ef09
Author : Jan Kratochvil <jan.kratochvil@redhat.com>
Date   : 2017-08-18T14:04:02+02:00
Stats  : +83/-1 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/gdb/c/99b34dc7843b09667bc4cc8e81ed6934d683ef09?branch=gdb-17.2-rebase-f44

Log:
Backport a fix for clang && -gsplit-dwarf debuggees (RH BZ 1482892).

---
diff --git a/gdb-upstream.patch b/gdb-upstream.patch
index 28fda28..6af0998 100644
--- a/gdb-upstream.patch
+++ b/gdb-upstream.patch
@@ -469,3 +469,82 @@ Date:   Tue Jul 25 11:38:50 2017 +0100
  # End of tests.
  
  return 0
+
+
+
+commit 16eb6b2db49e6cf2fdca56efd37689fcc170cd37
+Author: Leszek Swirski <leszeks@google.com>
+Date:   Mon Aug 7 16:40:38 2017 +0200
+
+    Fix dwarf2_string_attr for -gsplit-dwarf
+    
+    The dwarf2_string_attr did not allow DW_FORM_GNU_str_index as a form for
+    string types. This manifested as null strings in the namespace_name
+    lookup (replaced with "(anonymous namespace)") when debugging
+    Fission-compiled code.
+    
+    gdb/ChangeLog:
+    
+            * dwarf2read.c (dwarf2_string_attr): Allow DW_FORM_GNU_strp_alt.
+
+### a/gdb/ChangeLog
+### b/gdb/ChangeLog
+## -1,3 +1,7 @@
++2017-08-07  Leszek Swirski  <leszeks@google.com>
++
++	* dwarf2read.c (dwarf2_string_attr): Allow DW_FORM_GNU_strp_alt.
++
+ 2017-08-07  Simon Marchi  <simon.marchi@ericsson.com>
+ 
+ 	* remote-sim.c (gdbsim_load): Remove char **argv local variable.
+--- a/gdb/dwarf2read.c
++++ b/gdb/dwarf2read.c
+@@ -17623,7 +17623,8 @@ dwarf2_string_attr (struct die_info *die, unsigned int name, struct dwarf2_cu *c
+   if (attr != NULL)
+     {
+       if (attr->form == DW_FORM_strp || attr->form == DW_FORM_line_strp
+-	  || attr->form == DW_FORM_string || attr->form == DW_FORM_GNU_strp_alt)
++	  || attr->form == DW_FORM_string || DW_FORM_GNU_str_index
++	  || attr->form == DW_FORM_GNU_strp_alt)
+ 	str = DW_STRING (attr);
+       else
+         complaint (&symfile_complaints,
+
+
+
+commit b33404388e5bbd8a1fddfde73cd4593ae2b557e8
+Author: H.J. Lu <hjl.tools@gmail.com>
+Date:   Wed Aug 9 05:01:55 2017 -0700
+
+    gdb: Fix build failure with GCC 7
+    
+    Fix:
+    
+    /export/gnu/import/git/sources/binutils-gdb/gdb/dwarf2read.c: In function ‘const char* dwarf2_string_attr(die_info*, unsigned int, dwarf2_cu*)’:
+    /export/gnu/import/git/sources/binutils-gdb/gdb/dwarf2read.c:17626:39: error: enum constant in boolean context [-Werror=int-in-bool-context]
+        || attr->form == DW_FORM_string || DW_FORM_GNU_str_index
+    
+            * dwarf2read.c (dwarf2_string_attr): Fix a typo.
+
+### a/gdb/ChangeLog
+### b/gdb/ChangeLog
+## -1,3 +1,7 @@
++2017-08-09  H.J. Lu  <hongjiu.lu@intel.com>
++
++	* dwarf2read.c (dwarf2_string_attr): Fix a typo.
++
+ 2017-08-09  Alex Lindsay  <alexlindsay239@gmail.com>
+ 	    Yao Qi  <yao.qi@linaro.org>
+ 
+--- a/gdb/dwarf2read.c
++++ b/gdb/dwarf2read.c
+@@ -17623,7 +17623,8 @@ dwarf2_string_attr (struct die_info *die, unsigned int name, struct dwarf2_cu *c
+   if (attr != NULL)
+     {
+       if (attr->form == DW_FORM_strp || attr->form == DW_FORM_line_strp
+-	  || attr->form == DW_FORM_string || DW_FORM_GNU_str_index
++	  || attr->form == DW_FORM_string
++	  || attr->form == DW_FORM_GNU_str_index
+ 	  || attr->form == DW_FORM_GNU_strp_alt)
+ 	str = DW_STRING (attr);
+       else

diff --git a/gdb.spec b/gdb.spec
index b60fe91..a123a48 100644
--- a/gdb.spec
+++ b/gdb.spec
@@ -26,7 +26,7 @@ Version: 8.0
 
 # The release always contains a leading reserved number, start it at 1.
 # `upstream' is not a part of `name' to stay fully rpm dependencies compatible for the testing.
-Release: 21%{?dist}
+Release: 22%{?dist}
 
 License: GPLv3+ and GPLv3+ with exceptions and GPLv2+ and GPLv2+ with exceptions and GPL+ and LGPLv2+ and LGPLv3+ and BSD and Public Domain and GFDL
 Group: Development/Debuggers
@@ -1643,6 +1643,9 @@ then
 fi
 
 %changelog
+* Fri Aug 18 2017 Jan Kratochvil <jan.kratochvil@redhat.com> - 8.0-22.fc26
+- Backport a fix for clang && -gsplit-dwarf debuggees (RH BZ 1482892).
+
 * Sun Aug 13 2017 Jan Kratochvil <jan.kratochvil@redhat.com> - 8.0-21.fc26
 - Fix compatibility with F-27 debuginfo packaging.
 - Fix compatibility with F-27 librpm version 8.

                 reply	other threads:[~2026-06-27 23:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178260469899.1.7556767937072981047.rpms-gdb-99b34dc7843b@fedoraproject.org \
    --to=jan.kratochvil@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox