public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/gdb] gdb-17.2-rebase-f44: [aarch64] Backport two breakpoint/watchpoint fixes.
Date: Sat, 27 Jun 2026 23:56:26 GMT	[thread overview]
Message-ID: <178260458607.1.1862347259513968628.rpms-gdb-0f5a62e3a0d8@fedoraproject.org> (raw)

A new commit has been pushed.

Repo   : rpms/gdb
Branch : gdb-17.2-rebase-f44
Commit : 0f5a62e3a0d8ba3e919475c134fd8a05d3f97f73
Author : Jan Kratochvil <jan.kratochvil@redhat.com>
Date   : 2013-12-25T20:55:37+01:00
Stats  : +130/-1 in 2 file(s)
URL    : https://src.fedoraproject.org/rpms/gdb/c/0f5a62e3a0d8ba3e919475c134fd8a05d3f97f73?branch=gdb-17.2-rebase-f44

Log:
[aarch64] Backport two breakpoint/watchpoint fixes.

---
diff --git a/gdb-upstream.patch b/gdb-upstream.patch
index 776aa40..da4c127 100644
--- a/gdb-upstream.patch
+++ b/gdb-upstream.patch
@@ -75,3 +75,129 @@ index 8e66425..bcfcce2 100644
    set_solib_svr4_fetch_link_map_offsets (gdbarch,
  					 svr4_lp64_fetch_link_map_offsets);
  
+
+
+
+pre-req for:
+[PATCH, AArch64] Fix bug in hardware watchpoint/breakpoint handling
+commit c623a6ef72a8d7dbbb646345f75646710cb9bb68
+Author: Will Newton <willnewton@sourceware.org>
+Date:   Mon Sep 16 14:22:19 2013 +0000
+
+    gdbserver, aarch64: Zero out regs in aarch64_linux_set_debug_regs.
+    
+    Apply the same fix that was applied to aarch64-linux-nat.c.
+    
+    2013-09-16  Will Newton  <will.newton@linaro.org>
+    
+    	* linux-aarch64-low.c (aarch64_linux_set_debug_regs): Zero
+    	out regs.
+
+diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
+index 73191f4..1082e78 100644
+### a/gdb/gdbserver/ChangeLog
+### b/gdb/gdbserver/ChangeLog
+## -1,3 +1,8 @@
++2013-09-16  Will Newton  <will.newton@linaro.org>
++
++	* linux-aarch64-low.c (aarch64_linux_set_debug_regs): Zero
++	out regs.
++
+ 2013-09-06  Pedro Alves  <palves@redhat.com>
+ 
+ 	* Makefile.in (gdb_proc_service_h, regdef_h, regcache_h)
+diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c
+index e37f602..93246b3 100644
+--- a/gdb/gdbserver/linux-aarch64-low.c
++++ b/gdb/gdbserver/linux-aarch64-low.c
+@@ -600,6 +600,7 @@ aarch64_linux_set_debug_regs (const struct aarch64_debug_reg_state *state,
+   const CORE_ADDR *addr;
+   const unsigned int *ctrl;
+ 
++  memset (&regs, 0, sizeof (regs));
+   iov.iov_base = &regs;
+   iov.iov_len = sizeof (regs);
+   count = watchpoint ? aarch64_num_wp_regs : aarch64_num_bp_regs;
+
+
+
+[PATCH, AArch64] Fix bug in hardware watchpoint/breakpoint handling
+https://sourceware.org/ml/gdb-patches/2013-12/msg00707.html
+commit f45c82da381e0ce5ce51b7fb24d0d28611d266b8
+Author: Yufeng Zhang <yufeng.zhang@arm.com>
+Date:   Wed Dec 18 16:47:33 2013 +0000
+
+    gdb/
+    
+    	* aarch64-linux-nat.c (aarch64_linux_set_debug_regs): Set
+    	iov.iov_len with the real length in use.
+    
+    gdb/gdbserver/
+    
+    	* linux-aarch64-low.c (aarch64_linux_set_debug_regs): Set
+    	iov.iov_len with the real length in use.
+
+diff --git a/gdb/ChangeLog b/gdb/ChangeLog
+index 7d9308f..513c593 100644
+### a/gdb/ChangeLog
+### b/gdb/ChangeLog
+## -1,3 +1,8 @@
++2013-12-18  Yufeng Zhang  <yufeng.zhang@arm.com>
++
++	* aarch64-linux-nat.c (aarch64_linux_set_debug_regs): Set
++	iov.iov_len with the real length in use.
++
+ 2013-12-18  Yao Qi  <yao@codesourcery.com>
+ 
+ 	* target.h (target_xfer_partial_ftype): New typedef.
+diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
+index 256725b..7d76833 100644
+--- a/gdb/aarch64-linux-nat.c
++++ b/gdb/aarch64-linux-nat.c
+@@ -314,10 +314,13 @@ aarch64_linux_set_debug_regs (const struct aarch64_debug_reg_state *state,
+ 
+   memset (&regs, 0, sizeof (regs));
+   iov.iov_base = &regs;
+-  iov.iov_len = sizeof (regs);
+   count = watchpoint ? aarch64_num_wp_regs : aarch64_num_bp_regs;
+   addr = watchpoint ? state->dr_addr_wp : state->dr_addr_bp;
+   ctrl = watchpoint ? state->dr_ctrl_wp : state->dr_ctrl_bp;
++  if (count == 0)
++    return;
++  iov.iov_len = (offsetof (struct user_hwdebug_state, dbg_regs[count - 1])
++		 + sizeof (regs.dbg_regs [count - 1]));
+ 
+   for (i = 0; i < count; i++)
+     {
+diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
+index c73840f..2847796 100644
+### a/gdb/gdbserver/ChangeLog
+### b/gdb/gdbserver/ChangeLog
+## -1,3 +1,8 @@
++2013-12-18  Yufeng Zhang  <yufeng.zhang@arm.com>
++
++	* linux-aarch64-low.c (aarch64_linux_set_debug_regs): Set
++	iov.iov_len with the real length in use.
++
+ 2013-12-13  Joel Brobecker  <brobecker@adacore.com>
+ 
+ 	* Makefile.in (safe-ctype.o, lbasename.o): New rules.
+diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c
+index 93246b3..c2d271a 100644
+--- a/gdb/gdbserver/linux-aarch64-low.c
++++ b/gdb/gdbserver/linux-aarch64-low.c
+@@ -602,10 +602,13 @@ aarch64_linux_set_debug_regs (const struct aarch64_debug_reg_state *state,
+ 
+   memset (&regs, 0, sizeof (regs));
+   iov.iov_base = &regs;
+-  iov.iov_len = sizeof (regs);
+   count = watchpoint ? aarch64_num_wp_regs : aarch64_num_bp_regs;
+   addr = watchpoint ? state->dr_addr_wp : state->dr_addr_bp;
+   ctrl = watchpoint ? state->dr_ctrl_wp : state->dr_ctrl_bp;
++  if (count == 0)
++    return;
++  iov.iov_len = (offsetof (struct user_hwdebug_state, dbg_regs[count - 1])
++		 + sizeof (regs.dbg_regs [count - 1]));
+ 
+   for (i = 0; i < count; i++)
+     {

diff --git a/gdb.spec b/gdb.spec
index 0a88357..1067ac8 100644
--- a/gdb.spec
+++ b/gdb.spec
@@ -38,7 +38,7 @@ Version: 7.6.50.%{snap}
 
 # The release always contains a leading reserved number, start it at 1.
 # `upstream' is not a part of `name' to stay fully rpm dependencies compatible for the testing.
-Release: 17%{?dist}
+Release: 18%{?dist}
 
 License: GPLv3+ and GPLv3+ with exceptions and GPLv2+ and GPLv2+ with exceptions and GPL+ and LGPLv2+ and BSD and Public Domain
 Group: Development/Debuggers
@@ -1346,6 +1346,9 @@ fi
 %endif # 0%{!?el5:1} || "%{_target_cpu}" == "noarch"
 
 %changelog
+* Wed Dec 25 2013 Jan Kratochvil <jan.kratochvil@redhat.com> - 7.6.50.20130731-18.fc20
+- [aarch64] Backport two breakpoint/watchpoint fixes.
+
 * Mon Nov 18 2013 Jan Kratochvil <jan.kratochvil@redhat.com> - 7.6.50.20130731-17.fc20
 - [rhel7] [--with testsuite] Remove gcc-java&co. BuildRequires.
 

                 reply	other threads:[~2026-06-27 23:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178260458607.1.1862347259513968628.rpms-gdb-0f5a62e3a0d8@fedoraproject.org \
    --to=jan.kratochvil@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox