public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Tulio Magno Quites Machado Filho <tuliom@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/llvm] rawhide: Remove LLVM_LIBDIR_SUFFIX workaround on LLVM >= 23
Date: Thu, 25 Jun 2026 19:49:20 GMT	[thread overview]
Message-ID: <178241696079.1.16058794684911050540.rpms-llvm-11bc3c61959e@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/llvm
            Branch : rawhide
            Commit : 11bc3c61959ebda6a40d80bfe3179ade60879cfd
            Author : Tulio Magno Quites Machado Filho <tuliom@redhat.com>
            Date   : 2026-06-25T16:48:33-03:00
            Stats  : +2/-2 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/llvm/c/11bc3c61959ebda6a40d80bfe3179ade60879cfd?branch=rawhide

            Log:
            Remove LLVM_LIBDIR_SUFFIX workaround on LLVM >= 23

We have a workaround that is not needed anymore on LLVM 23 due to
https://github.com/llvm/llvm-project/issues/159762 getting fixed there.
We still need this workaround on previous versions though.

[skip changelog]

---
diff --git a/llvm.spec b/llvm.spec
index c9c9282..fbb9943 100644
--- a/llvm.spec
+++ b/llvm.spec
@@ -1788,10 +1788,10 @@ CLANG_LDFLAGS=$(strip_specs "$LDFLAGS $CLANG_LDFLAGS_EXTRA")
   -DRUNTIMES_nvptx64-nvidia-cuda_CMAKE_STATIC_LINKER_FLAGS="" \\\
   -DRUNTIMES_amdgcn-amd-amdhsa_LLVM_ENABLE_RUNTIMES="openmp"
 
-%if 0%{?__isa_bits} == 64
+%if 0%{?__isa_bits} == 64 && %{maj_ver} <= 22
 # The following shouldn't be required, but due to a bug, we have to be
 # explicit about LLVM_LIBDIR_SUFFIX for nvptx64-nvidia-cuda.
-# TODO: Remove this after fixing
+# This got fixed in LLVM 23.
 # https://github.com/llvm/llvm-project/issues/159762
 %global cmake_config_args %{cmake_config_args} \\\
 	-DRUNTIMES_nvptx64-nvidia-cuda_LLVM_LIBDIR_SUFFIX=64

                 reply	other threads:[~2026-06-25 19:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178241696079.1.16058794684911050540.rpms-llvm-11bc3c61959e@fedoraproject.org \
    --to=tuliom@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox