public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Michal Schorm <mschorm@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/mariadb-connector-c] f43: [cleanup] Remove deprecated 'ldconfig' scriptlets from '-test' subpackage
Date: Thu, 25 Jun 2026 18:20:07 GMT	[thread overview]
Message-ID: <178241160725.1.16708475344252195031.rpms-mariadb-connector-c-16a7609a46ac@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/mariadb-connector-c
            Branch : f43
            Commit : 16a7609a46aced687ede16403ffe5d1d74cd5c5e
            Author : Michal Schorm <mschorm@redhat.com>
            Date   : 2026-06-24T00:40:24+02:00
            Stats  : +0/-6 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/mariadb-connector-c/c/16a7609a46aced687ede16403ffe5d1d74cd5c5e?branch=f43

            Log:
            [cleanup] Remove deprecated 'ldconfig' scriptlets from '-test' subpackage

Remove the explicit '%post'/'%postun' 'ldconfig' calls from the '-test'
subpackage. Since Fedora 28, glibc's 'transfiletriggerin' on '/usr/lib64'
handles 'ldconfig' automatically. The '-test' subpackage's 'libcctap.so'
lives under '/usr/lib64/mariadb/connector-c/tests/' which matches the
trigger prefix, so 'ldconfig' is called by file triggers after install
and uninstall.

The main package (shipping 'libmariadb.so.3' in '/usr/lib64') already
relies entirely on file triggers with no explicit 'ldconfig' scriptlets.

This also removes an unnecessary 'Requires: /usr/bin/ldconfig' that the
'-p' scriptlet form generates.

Verified in a 'fedora:rawhide' container ('podman'):
  - 'rpmbuild --rebuild': all 9 RPMs built successfully
  - 'rpm -q --scripts mariadb-connector-c-test': empty (no scriptlets)
  - 'ldconfig -p | grep libmariadb': found (file trigger works)
  - 'ldconfig -p | grep libcctap': found (file trigger works for
    non-standard path via 'ld.so.conf.d' entry)
  - All 20 test binaries loaded 'libcctap.so' and executed (exit 0)

Co-Authored-By: Claude AI <noreply@anthropic.com>

---
diff --git a/mariadb-connector-c.spec b/mariadb-connector-c.spec
index 165f03d..2f03c92 100644
--- a/mariadb-connector-c.spec
+++ b/mariadb-connector-c.spec
@@ -195,12 +195,6 @@ install -D -p -m 0644 %{name}.conf %{buildroot}%{_sysconfdir}/ld.so.conf.d/%{nam
 %ctest --test-dir %{__cmake_builddir}/unittest/libmariadb/
 %endif
 
-%if %{with testsuite}
-%post -n %{name}-test -p /usr/bin/ldconfig
-
-%postun -n %{name}-test -p /usr/bin/ldconfig
-%endif
-
 
 %files
 %{_libdir}/libmariadb.so.3

                 reply	other threads:[~2026-06-25 18:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178241160725.1.16708475344252195031.rpms-mariadb-connector-c-16a7609a46ac@fedoraproject.org \
    --to=mschorm@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox