public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Michal Schorm <mschorm@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/mariadb-connector-c] f44: [cleanup] Use '%autosetup' instead of '%setup' + conditional '%patch'
Date: Thu, 25 Jun 2026 18:19:44 GMT	[thread overview]
Message-ID: <178241158444.1.14752117191523086901.rpms-mariadb-connector-c-c6f58f1af53e@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/mariadb-connector-c
            Branch : f44
            Commit : c6f58f1af53e1365640876ab45d603da6224f679
            Author : Michal Schorm <mschorm@redhat.com>
            Date   : 2026-06-24T00:40:49+02:00
            Stats  : +1/-4 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/mariadb-connector-c/c/c6f58f1af53e1365640876ab45d603da6224f679?branch=f44

            Log:
            [cleanup] Use '%autosetup' instead of '%setup' + conditional '%patch'

The 'Patch1' tag is already conditional on the testsuite '%bcond', so
when the bcond is off, no patches exist in the parsed spec.
'%autosetup' handles this correctly -- it applies all declared patches
(zero when testsuite is off, one when on).

Verified in 'fedora:rawhide' container:
  - testsuite ON:  patch applied, full build + test RPMs produced
  - testsuite OFF: no patches applied, build succeeds without '-test'

Co-Authored-By: Claude AI <noreply@anthropic.com>

---
diff --git a/mariadb-connector-c.spec b/mariadb-connector-c.spec
index 2e46c08..72277df 100644
--- a/mariadb-connector-c.spec
+++ b/mariadb-connector-c.spec
@@ -102,10 +102,7 @@ and require this package, so the /etc/my.cnf file is present.
 
 
 %prep
-%setup -q -n %{name}-%{version}-src
-%if %{with testsuite}
-%patch -P1 -p1
-%endif
+%autosetup -p1 -n %{name}-%{version}-src
 
 # Remove unused parts
 rm -r win win-iconv external/zlib

                 reply	other threads:[~2026-06-25 18:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178241158444.1.14752117191523086901.rpms-mariadb-connector-c-c6f58f1af53e@fedoraproject.org \
    --to=mschorm@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox