public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Michal Schorm <mschorm@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/mariadb-connector-c] f44: [cleanup] Modernize '%bcond' declarations to explicit 0/1 format
Date: Thu, 25 Jun 2026 18:19:43 GMT	[thread overview]
Message-ID: <178241158304.1.5925861197451945114.rpms-mariadb-connector-c-8db6086eaee7@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/mariadb-connector-c
            Branch : f44
            Commit : 8db6086eaee718dee816e6c7901f8d0e323960f6
            Author : Michal Schorm <mschorm@redhat.com>
            Date   : 2026-06-24T00:40:49+02:00
            Stats  : +2/-2 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/mariadb-connector-c/c/8db6086eaee718dee816e6c7901f8d0e323960f6?branch=f44

            Log:
            [cleanup] Modernize '%bcond' declarations to explicit 0/1 format

Use the modern '%bcond' syntax with explicit default values:
  '%bcond debug 0'        (was: '%bcond_with debug')
  '%bcond testsuite 1'    (was: '%bcond_without testsuite')

The old '%bcond_with'/'%bcond_without' form is confusing because the
name is the opposite of the default ('bcond_with' means "off by
default", 'bcond_without' means "on by default"). The new form
makes the default value explicit and self-documenting.

https://rpm-software-management.github.io/rpm/manual/conditionalbuilds.html

Co-Authored-By: Claude AI <noreply@anthropic.com>

---
diff --git a/mariadb-connector-c.spec b/mariadb-connector-c.spec
index 94c41ae..f2f94a9 100644
--- a/mariadb-connector-c.spec
+++ b/mariadb-connector-c.spec
@@ -1,7 +1,7 @@
 # For deep debugging we need to build binaries with extra debug info
-%bcond_with     debug
+%bcond debug 0
 # Enable building and packing of the testsuite
-%bcond_without  testsuite
+%bcond testsuite 1
 
 # Override all optimization flags when making a debug build
 %if %{with debug}

                 reply	other threads:[~2026-06-25 18:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178241158304.1.5925861197451945114.rpms-mariadb-connector-c-8db6086eaee7@fedoraproject.org \
    --to=mschorm@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox