public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Stephen Gallagher <sgallagh@redhat.com>
To: git-commits@fedoraproject.org
Subject: [rpms/fedora-packager] epel10.2: fkinit: Use herestring for pass/OTP
Date: Thu, 25 Jun 2026 13:20:51 GMT	[thread overview]
Message-ID: <178239365114.1.7372571209519714186.rpms-fedora-packager-d68c55fa44a6@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/fedora-packager
            Branch : epel10.2
            Commit : d68c55fa44a6ec7424ceaa6515d8db284277ebc0
            Author : Stephen Gallagher <sgallagh@redhat.com>
            Date   : 2025-02-06T14:39:00-05:00
            Stats  : +1/-1 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/fedora-packager/c/d68c55fa44a6ec7424ceaa6515d8db284277ebc0?branch=epel10.2

            Log:
            fkinit: Use herestring for pass/OTP

For added security, pass the password and OTP directly via a BASH
herestring instead of via `echo`. This will avoid putting the value into
the process table.

Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>

---
diff --git a/fkinit b/fkinit
index 4ec0766..1d53287 100755
--- a/fkinit
+++ b/fkinit
@@ -106,7 +106,7 @@ kinit -n @$domain -c FILE:$armorcache
 F_PASSWORD=$(systemd-ask-password "FAS password:")
 F_OTP=$(systemd-ask-password "FAS OTP (leave blank if not configured):")
 
-echo -n ${F_PASSWORD}${F_OTP} | kinit -T FILE:$armorcache $_arg_user@$domain >/dev/null
+kinit -T FILE:$armorcache $_arg_user@$domain <<< "${F_PASSWORD}${F_OTP}" >/dev/null
 unset F_PASSWORD
 unset F_OTP
 

                 reply	other threads:[~2026-06-25 13:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178239365114.1.7372571209519714186.rpms-fedora-packager-d68c55fa44a6@fedoraproject.org \
    --to=sgallagh@redhat.com \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox