public inbox for git-commits@fedoraproject.org
help / color / mirror / Atom feed
From: Otto Liljalaakso <otto.liljalaakso@iki.fi>
To: git-commits@fedoraproject.org
Subject: [rpms/fedora-packager] epel10: Recommend fedora-review
Date: Thu, 25 Jun 2026 13:19:44 GMT	[thread overview]
Message-ID: <178239358415.1.12704823057552630227.rpms-fedora-packager-42690c1fe892@fedoraproject.org> (raw)

            A new commit has been pushed.

            Repo   : rpms/fedora-packager
            Branch : epel10
            Commit : 42690c1fe892d57214f743e8a4f1515f20692812
            Author : Otto Liljalaakso <otto.liljalaakso@iki.fi>
            Date   : 2025-01-18T19:44:59+00:00
            Stats  : +3/-0 in 1 file(s)
            URL    : https://src.fedoraproject.org/rpms/fedora-packager/c/42690c1fe892d57214f743e8a4f1515f20692812?branch=epel10

            Log:
            Recommend fedora-review

fedora-review is included in the packages to install in Installing
Packager Tools [1], the only other package being fedora-packager. Make
the setup a bit simpler by getting everything from fedora-packager.

(As a side note, nothing in Package Maintainer Docs actually mentions
*using* fedora review. So the other way to fix the issue would be to
not ask to install fedora-review in Installing Packager Tools. But
since it is a useful packager tool, it seems valid to included it in
fedora-packager.)

[1]: https://docs.fedoraproject.org/en-US/package-maintainers/Installing_Packager_Tools/

---
diff --git a/fedora-packager.spec b/fedora-packager.spec
index b804867..b2af40b 100644
--- a/fedora-packager.spec
+++ b/fedora-packager.spec
@@ -46,6 +46,9 @@ Recommends:     rpmdistro-repoquery
 # Needed for koji edit-sidetag
 Recommends:     python3-koji-cli-plugins
 
+# A CLI tool that helps conduct package reviews
+Recommends:     fedora-review
+
 BuildArch:      noarch
 
 %description

                 reply	other threads:[~2026-06-25 13:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178239358415.1.12704823057552630227.rpms-fedora-packager-42690c1fe892@fedoraproject.org \
    --to=otto.liljalaakso@iki.fi \
    --cc=git-commits@fedoraproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox